From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9Oz3-0001IK-Rz for qemu-devel@nongnu.org; Tue, 22 Nov 2016 23:16:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9Oz0-0001xk-MG for qemu-devel@nongnu.org; Tue, 22 Nov 2016 23:16:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46784) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c9Oz0-0001xD-G1 for qemu-devel@nongnu.org; Tue, 22 Nov 2016 23:16:30 -0500 From: Eric Blake Date: Tue, 22 Nov 2016 22:16:25 -0600 Message-Id: <1479874588-1969-1-git-send-email-eblake@redhat.com> Subject: [Qemu-devel] [PATCH for-2.8 0/3] Fix MacOS runtime failure of qobject_from_jsonf() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: programmingkidx@gmail.com, armbru@redhat.com, pbonzini@redhat.com programmingkidx@gmail.com[*] reported a runtime failure on a 32-bit Mac OS compilation, where "%"PRId64 expands to "%qd". Fortunately, we had very few spots that were relying on our pseudo-printf JSON parsing of 64-bit numbers, so it was easier to just convert callers and rip out the 64-bit support. The remaining uses of pseudo-printf handling are more complex; there are only 3 users in the released codebased, but LOTS of users in the testsuite (via wrapper functions like qmp()); I will be posting a followup series that rips out the remaining uses of dynamic JSON, but it will be 2.9 material, while these three patches qualify for 2.8. [*] git log shows the name John, but the particular email that sparked this only stated the non-descript name 'G 3', which makes it a bit hard for me to know which form is preferred when lending credit. In patch 3, I chose to remove existing support for 64-bit dynamic JSON on all platforms, so that we quickly see a failure in an attempt to use such a construct even on mainstream glibc development environments, rather than only on the less-frequent 32-bit Mac OS build environment. Eric Blake (3): qmp-event: Avoid qobject_from_jsonf("%"PRId64) test-qga: Avoid qobject_from_jsonf("%"PRId64) qapi: Drop support for qobject_from_jsonf("%"PRId64) qapi/qmp-event.c | 12 +++++++----- qobject/json-lexer.c | 28 ---------------------------- qobject/json-parser.c | 5 ----- tests/check-qjson.c | 10 ---------- tests/test-qga.c | 9 +++++++-- tests/test-qobject-input-visitor.c | 5 +++-- 6 files changed, 17 insertions(+), 52 deletions(-) -- 2.7.4