From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935893AbcKWLdr (ORCPT <rfc822;w@1wt.eu>);
        Wed, 23 Nov 2016 06:33:47 -0500
Received: from smtprelay0177.hostedemail.com ([216.40.44.177]:39085 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S935712AbcKWLdq (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 23 Nov 2016 06:33:46 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:960:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3867:3868:3873:4321:5007:7903:10004:10400:10848:11026:11232:11473:11657:11658:11914:12043:12048:12438:12740:12760:13069:13311:13357:13439:14181:14659:21080:21433:30051:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-HE-Tag: rose74_737e4824f5626
X-Filterd-Recvd-Size: 1566
Message-ID: <1479900792.17782.10.camel@perches.com>
Subject: Re: [PATCH] Staging: iio: adc: fix sysfs files modes in ad7192.c
From: Joe Perches <joe@perches.com>
To: Boyan Vladinov <nayobix@nayobix.org>, gregkh@linuxfoundation.org,
        lars@metafoo.de, Michael.Hennerich@analog.com
Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Date: Wed, 23 Nov 2016 03:33:12 -0800
In-Reply-To: <1479885914-17615-1-git-send-email-nayobix@nayobix.org>
References: <1479885914-17615-1-git-send-email-nayobix@nayobix.org>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.22.1-0ubuntu2 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2016-11-22 at 23:25 -0800, Boyan Vladinov wrote:
> Fixes sysfs entries user/group modes and coding style warnings
> found by checkpatch.pl tool
[]
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
[]
>  static ssize_t ad7192_show_ac_excitation(struct device *dev,
> @@ -412,11 +412,11 @@ static ssize_t ad7192_set(struct device *dev,
>  	return ret ? ret : len;
>  }
>  
> -static IIO_DEVICE_ATTR(bridge_switch_en, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(bridge_switch_en, 0444 | 0200,

If you are going to submit S_<FOO> -> octal conversions,
please collapse the multiple octal values into one value

0444 | 0200 => 0644