All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Namjae Jeon <namjae.jeon@samsung.com>, linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, "Christoph Hellwig" <hch@lst.de>,
	"Daniel Wagner" <dwagner@suse.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Nikolay Borisov" <nborisov@suse.com>,
	"Sungjong Seo" <sj1557.seo@samsung.com>,
	"Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
	linkinjeon@gmail.com
Subject: Re: [PATCH v5 10/13] exfat: add nls operations
Date: Mon, 25 Nov 2019 09:50:32 +0100	[thread overview]
Message-ID: <147eac54-5846-ffe1-4b6b-ebf611d1252b@web.de> (raw)
In-Reply-To: <20191125000326.24561-11-namjae.jeon@samsung.com>

…
> +++ b/fs/exfat/nls.c
…
> +static int exfat_load_upcase_table(struct super_block *sb,
> +		sector_t sector, unsigned long long num_sectors,
> +		unsigned int utbl_checksum)
> +{
…
> +	unsigned int i, index = 0, checksum = 0;
…
> +			checksum = ((checksum & 1) ? 0x80000000 : 0) +
> +				(checksum >> 1) +
> +				*(((unsigned char *)bh->b_data) + (i + 1));
…
> +	if (index >= 0xFFFF && utbl_checksum == checksum)
> +		return 0;

* Can it be that a type other than “int” would be more portable
  for the desired data processing at these source code places?

* How do you think about to use more meaningful identifiers for
  two of the shown literals?

Regards,
Markus

  reply	other threads:[~2019-11-25  8:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20191125000627epcas1p376a5a32c90e491f8cac92d053fb5e453@epcas1p3.samsung.com>
2019-11-25  0:03 ` [PATCH v5 00/13] add the latest exfat driver Namjae Jeon
     [not found]   ` <CGME20191125000628epcas1p14efb75a7348fca8f5d8cbe3a055df0e2@epcas1p1.samsung.com>
2019-11-25  0:03     ` [PATCH v5 01/13] exfat: add in-memory and on-disk structures and headers Namjae Jeon
     [not found]   ` <CGME20191125000628epcas1p28c532d9b7f184945c40e019ce9ef0dd0@epcas1p2.samsung.com>
2019-11-25  0:03     ` [PATCH v5 02/13] exfat: add super block operations Namjae Jeon
2019-12-06 10:25       ` Valdis Klētnieks
2019-12-06 21:55         ` Namjae Jeon
     [not found]   ` <CGME20191125000629epcas1p111239cbadac31bb201d83f620b96afec@epcas1p1.samsung.com>
2019-11-25  0:03     ` [PATCH v5 03/13] exfat: add inode operations Namjae Jeon
     [not found]   ` <CGME20191125000630epcas1p23c2ac4216a044a19916f6aeb99166fde@epcas1p2.samsung.com>
2019-11-25  0:03     ` [PATCH v5 04/13] exfat: add directory operations Namjae Jeon
2019-11-25  9:26       ` Markus Elfring
     [not found]   ` <CGME20191125000630epcas1p2f4bf0b1ca1a8cc4327f120060ca0a9f1@epcas1p2.samsung.com>
2019-11-25  0:03     ` [PATCH v5 05/13] exfat: add file operations Namjae Jeon
     [not found]   ` <CGME20191125000631epcas1p19c6023ffa6388994d77d182a799e27bc@epcas1p1.samsung.com>
2019-11-25  0:03     ` [PATCH v5 06/13] exfat: add exfat entry operations Namjae Jeon
     [not found]   ` <CGME20191125000631epcas1p4fd916646ab2d25f8ae06cb1dfbf15e89@epcas1p4.samsung.com>
2019-11-25  0:03     ` [PATCH v5 07/13] exfat: add bitmap operations Namjae Jeon
     [not found]   ` <CGME20191125000632epcas1p3d57f4e255dcdeb79707332a5a3dfb2bc@epcas1p3.samsung.com>
2019-11-25  0:03     ` [PATCH v5 08/13] exfat: add exfat cache Namjae Jeon
     [not found]   ` <CGME20191125000632epcas1p1b9c9adefdad82bc538f914924ce9fa21@epcas1p1.samsung.com>
2019-11-25  0:03     ` [PATCH v5 09/13] exfat: add misc operations Namjae Jeon
     [not found]   ` <CGME20191125000633epcas1p1bce48f6e0fdd552fe74dbdb7976d5182@epcas1p1.samsung.com>
2019-11-25  0:03     ` [PATCH v5 10/13] exfat: add nls operations Namjae Jeon
2019-11-25  8:50       ` Markus Elfring [this message]
2019-12-18  7:00         ` [v5 " Markus Elfring
     [not found]   ` <CGME20191125000633epcas1p3366266bfed68fd63566c086d98988259@epcas1p3.samsung.com>
2019-11-25  0:03     ` [PATCH v5 11/13] exfat: add Kconfig and Makefile Namjae Jeon
     [not found]   ` <CGME20191125000634epcas1p4a2d87cec8621b42a85bd94ecc5803e5c@epcas1p4.samsung.com>
2019-11-25  0:03     ` [PATCH v5 12/13] exfat: add exfat in fs/Kconfig and fs/Makefile Namjae Jeon
     [not found]   ` <CGME20191125000634epcas1p2e99dba9fd777b57618bb57bf9fa44c53@epcas1p2.samsung.com>
2019-11-25  0:03     ` [PATCH v5 13/13] MAINTAINERS: add exfat filesystem Namjae Jeon
2019-11-25  8:19   ` [PATCH v5 00/13] add the latest exfat driver Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=147eac54-5846-ffe1-4b6b-ebf611d1252b@web.de \
    --to=markus.elfring@web.de \
    --cc=dwagner@suse.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@lst.de \
    --cc=linkinjeon@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namjae.jeon@samsung.com \
    --cc=nborisov@suse.com \
    --cc=sj1557.seo@samsung.com \
    --cc=valdis.kletnieks@vt.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.