From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752790AbcKYEzk (ORCPT ); Thu, 24 Nov 2016 23:55:40 -0500 Received: from mail-pg0-f45.google.com ([74.125.83.45]:33397 "EHLO mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752731AbcKYEz1 (ORCPT ); Thu, 24 Nov 2016 23:55:27 -0500 From: Kirtika Ruchandani To: tj@kernel.org, Li Zefan Cc: Kirtika Ruchandani , arnd@arndb.de, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] cpuset: Remove unused 'struct cpuset*' variable Date: Thu, 24 Nov 2016 20:55:12 -0800 Message-Id: <1480049712-17224-1-git-send-email-kirtika@chromium.org> X-Mailer: git-send-email 2.8.0.rc3.226.g39d4020 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 'struct cpuset* cs' that is set but not used, was introduced in commit 1f7dd3e5a6e4 ("cgroup: fix handling of multi-destination migration from subtree_control enabling"). cpuset_cancel_attach() uses css_cs(css) instead. Compiling with W=1 gives the folllowing harmless warning, which we'd like to fix to reduce the noise with W=1 in the kernel. kernel/cpuset.c: In function ‘cpuset_cancel_attach’: kernel/cpuset.c:1502:17: warning: variable ‘cs’ set but not used [-Wunused-but-set-variable] struct cpuset *cs; ^ Fixes: 1f7dd3e5a6e4 ("cgroup: fix handling of multi-destination migration from subtree_control enabling"). Cc: Tejun Heo Signed-off-by: Kirtika Ruchandani --- kernel/cpuset.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/kernel/cpuset.c b/kernel/cpuset.c index 29f815d..af51460 100644 --- a/kernel/cpuset.c +++ b/kernel/cpuset.c @@ -1499,10 +1499,8 @@ static int cpuset_can_attach(struct cgroup_taskset *tset) static void cpuset_cancel_attach(struct cgroup_taskset *tset) { struct cgroup_subsys_state *css; - struct cpuset *cs; cgroup_taskset_first(tset, &css); - cs = css_cs(css); mutex_lock(&cpuset_mutex); css_cs(css)->attach_in_progress--; -- 2.8.0.rc3.226.g39d4020