From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755782AbcK1Wnq (ORCPT ); Mon, 28 Nov 2016 17:43:46 -0500 Received: from botnar.kaiser.cx ([176.28.20.183]:51456 "EHLO botnar.kaiser.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755375AbcK1Wni (ORCPT ); Mon, 28 Nov 2016 17:43:38 -0500 From: Martin Kaiser To: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Sascha Hauer , linux-fbdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH] video: imxfb: remove the macros for initializing the DMACR Date: Mon, 28 Nov 2016 23:43:09 +0100 Message-Id: <1480372989-6413-1-git-send-email-martin@kaiser.cx> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <20161125084303.GA14156@botnar.kaiser.cx> References: <20161125084303.GA14156@botnar.kaiser.cx> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The current definitions of DMACR_HM() and DMACR_TM() are correct only for imx1, they're wrong for imx21. The macros are meant for legacy board files only, they're not applicable for boards using device tree. At the moment, there are no boards are using the macros. So it should be safe to drop them rather than making them work for both imx1 and imx21, which would require a change in the platform data struct. Signed-off-by: Martin Kaiser --- include/linux/platform_data/video-imxfb.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/include/linux/platform_data/video-imxfb.h b/include/linux/platform_data/video-imxfb.h index 18e9083..a5c0a71 100644 --- a/include/linux/platform_data/video-imxfb.h +++ b/include/linux/platform_data/video-imxfb.h @@ -47,10 +47,6 @@ #define LSCR1_GRAY2(x) (((x) & 0xf) << 4) #define LSCR1_GRAY1(x) (((x) & 0xf)) -#define DMACR_BURST (1 << 31) -#define DMACR_HM(x) (((x) & 0xf) << 16) -#define DMACR_TM(x) ((x) & 0xf) - struct imx_fb_videomode { struct fb_videomode mode; u32 pcr; -- 1.7.10.4 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Kaiser Date: Mon, 28 Nov 2016 22:43:09 +0000 Subject: [PATCH] video: imxfb: remove the macros for initializing the DMACR Message-Id: <1480372989-6413-1-git-send-email-martin@kaiser.cx> List-Id: References: <20161125084303.GA14156@botnar.kaiser.cx> In-Reply-To: <20161125084303.GA14156@botnar.kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Sascha Hauer , linux-fbdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Martin Kaiser The current definitions of DMACR_HM() and DMACR_TM() are correct only for imx1, they're wrong for imx21. The macros are meant for legacy board files only, they're not applicable for boards using device tree. At the moment, there are no boards are using the macros. So it should be safe to drop them rather than making them work for both imx1 and imx21, which would require a change in the platform data struct. Signed-off-by: Martin Kaiser --- include/linux/platform_data/video-imxfb.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/include/linux/platform_data/video-imxfb.h b/include/linux/platform_data/video-imxfb.h index 18e9083..a5c0a71 100644 --- a/include/linux/platform_data/video-imxfb.h +++ b/include/linux/platform_data/video-imxfb.h @@ -47,10 +47,6 @@ #define LSCR1_GRAY2(x) (((x) & 0xf) << 4) #define LSCR1_GRAY1(x) (((x) & 0xf)) -#define DMACR_BURST (1 << 31) -#define DMACR_HM(x) (((x) & 0xf) << 16) -#define DMACR_TM(x) ((x) & 0xf) - struct imx_fb_videomode { struct fb_videomode mode; u32 pcr; -- 1.7.10.4