From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:60488 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756417AbcK2JEq (ORCPT ); Tue, 29 Nov 2016 04:04:46 -0500 From: Laurent Pinchart To: dri-devel@lists.freedesktop.org Cc: linux-renesas-soc@vger.kernel.org, Archit Taneja Subject: [PATCH v3 02/13] drm: Fix compilation warning caused by static inline forward declaration Date: Tue, 29 Nov 2016 11:04:32 +0200 Message-Id: <1480410283-28698-3-git-send-email-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: <1480410283-28698-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> References: <1480410283-28698-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: The drm_crtc_mask() function used in is a static inline defined in . If the first header is included in a compilation unit without the second one, the following compilation warning will be issued. In file included from /drivers/gpu/drm/drm_bridge.c:29:0: /include/drm/drm_encoder.h:192:95: warning: ‘drm_crtc_mask’ used but never defined static inline uint32_t drm_crtc_mask(const struct drm_crtc *crtc); Fix this by including the header defining the function instead of using a forward declaration. Signed-off-by: Laurent Pinchart --- include/drm/drm_encoder.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/include/drm/drm_encoder.h b/include/drm/drm_encoder.h index cec6ac45c6cc..5f58f65344e0 100644 --- a/include/drm/drm_encoder.h +++ b/include/drm/drm_encoder.h @@ -25,6 +25,7 @@ #include #include +#include #include #include @@ -191,9 +192,6 @@ static inline unsigned int drm_encoder_index(struct drm_encoder *encoder) return encoder->index; } -/* FIXME: We have an include file mess still, drm_crtc.h needs untangling. */ -static inline uint32_t drm_crtc_mask(const struct drm_crtc *crtc); - /** * drm_encoder_crtc_ok - can a given crtc drive a given encoder? * @encoder: encoder to test -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: [PATCH v3 02/13] drm: Fix compilation warning caused by static inline forward declaration Date: Tue, 29 Nov 2016 11:04:32 +0200 Message-ID: <1480410283-28698-3-git-send-email-laurent.pinchart+renesas@ideasonboard.com> References: <1480410283-28698-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id C3EFF6E214 for ; Tue, 29 Nov 2016 09:04:34 +0000 (UTC) In-Reply-To: <1480410283-28698-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: linux-renesas-soc@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org VGhlIGRybV9jcnRjX21hc2soKSBmdW5jdGlvbiB1c2VkIGluIDxkcm0vZHJtX2VuY29kZXIuaD4g aXMgYSBzdGF0aWMKaW5saW5lIGRlZmluZWQgaW4gPGRybS9kcm1fY3J0Yy5oPi4gSWYgdGhlIGZp cnN0IGhlYWRlciBpcyBpbmNsdWRlZCBpbiBhCmNvbXBpbGF0aW9uIHVuaXQgd2l0aG91dCB0aGUg c2Vjb25kIG9uZSwgdGhlIGZvbGxvd2luZyBjb21waWxhdGlvbgp3YXJuaW5nIHdpbGwgYmUgaXNz dWVkLgoKSW4gZmlsZSBpbmNsdWRlZCBmcm9tIDxsaW51eD4vZHJpdmVycy9ncHUvZHJtL2RybV9i cmlkZ2UuYzoyOTowOgo8bGludXg+L2luY2x1ZGUvZHJtL2RybV9lbmNvZGVyLmg6MTkyOjk1OiB3 YXJuaW5nOiDigJhkcm1fY3J0Y19tYXNr4oCZIHVzZWQgYnV0IG5ldmVyIGRlZmluZWQKIHN0YXRp YyBpbmxpbmUgdWludDMyX3QgZHJtX2NydGNfbWFzayhjb25zdCBzdHJ1Y3QgZHJtX2NydGMgKmNy dGMpOwoKRml4IHRoaXMgYnkgaW5jbHVkaW5nIHRoZSBoZWFkZXIgZGVmaW5pbmcgdGhlIGZ1bmN0 aW9uIGluc3RlYWQgb2YgdXNpbmcKYSBmb3J3YXJkIGRlY2xhcmF0aW9uLgoKU2lnbmVkLW9mZi1i eTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydCtyZW5lc2FzQGlkZWFzb25ib2Fy ZC5jb20+Ci0tLQogaW5jbHVkZS9kcm0vZHJtX2VuY29kZXIuaCB8IDQgKy0tLQogMSBmaWxlIGNo YW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2luY2x1 ZGUvZHJtL2RybV9lbmNvZGVyLmggYi9pbmNsdWRlL2RybS9kcm1fZW5jb2Rlci5oCmluZGV4IGNl YzZhYzQ1YzZjYy4uNWY1OGY2NTM0NGUwIDEwMDY0NAotLS0gYS9pbmNsdWRlL2RybS9kcm1fZW5j b2Rlci5oCisrKyBiL2luY2x1ZGUvZHJtL2RybV9lbmNvZGVyLmgKQEAgLTI1LDYgKzI1LDcgQEAK IAogI2luY2x1ZGUgPGxpbnV4L2xpc3QuaD4KICNpbmNsdWRlIDxsaW51eC9jdHlwZS5oPgorI2lu Y2x1ZGUgPGRybS9kcm1fY3J0Yy5oPgogI2luY2x1ZGUgPGRybS9kcm1fbW9kZS5oPgogI2luY2x1 ZGUgPGRybS9kcm1fbW9kZV9vYmplY3QuaD4KIApAQCAtMTkxLDkgKzE5Miw2IEBAIHN0YXRpYyBp bmxpbmUgdW5zaWduZWQgaW50IGRybV9lbmNvZGVyX2luZGV4KHN0cnVjdCBkcm1fZW5jb2RlciAq ZW5jb2RlcikKIAlyZXR1cm4gZW5jb2Rlci0+aW5kZXg7CiB9CiAKLS8qIEZJWE1FOiBXZSBoYXZl IGFuIGluY2x1ZGUgZmlsZSBtZXNzIHN0aWxsLCBkcm1fY3J0Yy5oIG5lZWRzIHVudGFuZ2xpbmcu ICovCi1zdGF0aWMgaW5saW5lIHVpbnQzMl90IGRybV9jcnRjX21hc2soY29uc3Qgc3RydWN0IGRy bV9jcnRjICpjcnRjKTsKLQogLyoqCiAgKiBkcm1fZW5jb2Rlcl9jcnRjX29rIC0gY2FuIGEgZ2l2 ZW4gY3J0YyBkcml2ZSBhIGdpdmVuIGVuY29kZXI/CiAgKiBAZW5jb2RlcjogZW5jb2RlciB0byB0 ZXN0Ci0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==