All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: linux-renesas-soc@vger.kernel.org,
	Archit Taneja <architt@codeaurora.org>
Subject: [PATCH v3 06/13] drm: bridge: Add LVDS encoder driver
Date: Tue, 29 Nov 2016 11:04:36 +0200	[thread overview]
Message-ID: <1480410283-28698-7-git-send-email-laurent.pinchart+renesas@ideasonboard.com> (raw)
In-Reply-To: <1480410283-28698-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>

The LVDS encoder driver is a DRM bridge driver that supports the
parallel to LVDS encoders that don't require any configuration. The
driver thus doesn't interact with the device, but creates an LVDS
connector for the panel and exposes its size and timing based on
information retrieved from DT.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 drivers/gpu/drm/bridge/Kconfig        |   8 ++
 drivers/gpu/drm/bridge/Makefile       |   1 +
 drivers/gpu/drm/bridge/lvds-encoder.c | 217 ++++++++++++++++++++++++++++++++++
 3 files changed, 226 insertions(+)
 create mode 100644 drivers/gpu/drm/bridge/lvds-encoder.c

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index bd6acc829f97..a4d9657c9477 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -24,6 +24,14 @@ config DRM_DUMB_VGA_DAC
 	help
 	  Support for RGB to VGA DAC based bridges
 
+config DRM_LVDS_ENCODER
+	tristate "Transparent parallel to LVDS encoder support"
+	depends on OF
+	select DRM_KMS_HELPER
+	help
+	  Support for transparent parallel to LVDS encoders that don't require
+	  any configuration.
+
 config DRM_DW_HDMI
 	tristate
 	select DRM_KMS_HELPER
diff --git a/drivers/gpu/drm/bridge/Makefile b/drivers/gpu/drm/bridge/Makefile
index 97ed1a5fea9a..7e0bf849c30d 100644
--- a/drivers/gpu/drm/bridge/Makefile
+++ b/drivers/gpu/drm/bridge/Makefile
@@ -2,6 +2,7 @@ ccflags-y := -Iinclude/drm
 
 obj-$(CONFIG_DRM_ANALOGIX_ANX78XX) += analogix-anx78xx.o
 obj-$(CONFIG_DRM_DUMB_VGA_DAC) += dumb-vga-dac.o
+obj-$(CONFIG_DRM_LVDS_ENCODER) += lvds-encoder.o
 obj-$(CONFIG_DRM_DW_HDMI) += dw-hdmi.o
 obj-$(CONFIG_DRM_DW_HDMI_AHB_AUDIO) += dw-hdmi-ahb-audio.o
 obj-$(CONFIG_DRM_NXP_PTN3460) += nxp-ptn3460.o
diff --git a/drivers/gpu/drm/bridge/lvds-encoder.c b/drivers/gpu/drm/bridge/lvds-encoder.c
new file mode 100644
index 000000000000..576770ea8d7e
--- /dev/null
+++ b/drivers/gpu/drm/bridge/lvds-encoder.c
@@ -0,0 +1,217 @@
+/*
+ * Copyright (C) 2016 Laurent Pinchart <laurent.pinchart@ideasonboard.com>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ */
+
+#include <drm/drmP.h>
+#include <drm/drm_atomic_helper.h>
+#include <drm/drm_connector.h>
+#include <drm/drm_crtc_helper.h>
+#include <drm/drm_encoder.h>
+#include <drm/drm_modeset_helper_vtables.h>
+#include <drm/drm_panel.h>
+
+#include <linux/of_graph.h>
+
+struct lvds_encoder {
+	struct device *dev;
+
+	struct drm_bridge bridge;
+	struct drm_connector connector;
+	struct drm_panel *panel;
+};
+
+static inline struct lvds_encoder *
+drm_bridge_to_lvds_encoder(struct drm_bridge *bridge)
+{
+	return container_of(bridge, struct lvds_encoder, bridge);
+}
+
+static inline struct lvds_encoder *
+drm_connector_to_lvds_encoder(struct drm_connector *connector)
+{
+	return container_of(connector, struct lvds_encoder, connector);
+}
+
+static int lvds_connector_get_modes(struct drm_connector *connector)
+{
+	struct lvds_encoder *lvds = drm_connector_to_lvds_encoder(connector);
+
+	return drm_panel_get_modes(lvds->panel);
+}
+
+static const struct drm_connector_helper_funcs lvds_connector_helper_funcs = {
+	.get_modes = lvds_connector_get_modes,
+};
+
+static enum drm_connector_status
+lvds_connector_detect(struct drm_connector *connector, bool force)
+{
+	return connector_status_connected;
+}
+
+static const struct drm_connector_funcs lvds_connector_funcs = {
+	.dpms = drm_atomic_helper_connector_dpms,
+	.reset = drm_atomic_helper_connector_reset,
+	.detect = lvds_connector_detect,
+	.fill_modes = drm_helper_probe_single_connector_modes,
+	.destroy = drm_connector_cleanup,
+	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
+	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
+};
+
+static int lvds_encoder_attach(struct drm_bridge *bridge)
+{
+	struct lvds_encoder *lvds = drm_bridge_to_lvds_encoder(bridge);
+	struct drm_connector *connector = &lvds->connector;
+	int ret;
+
+	if (!bridge->encoder) {
+		DRM_ERROR("Missing encoder\n");
+		return -ENODEV;
+	}
+
+	drm_connector_helper_add(connector, &lvds_connector_helper_funcs);
+
+	ret = drm_connector_init(bridge->dev, connector, &lvds_connector_funcs,
+				 DRM_MODE_CONNECTOR_LVDS);
+	if (ret) {
+		DRM_ERROR("Failed to initialize connector\n");
+		return ret;
+	}
+
+	drm_mode_connector_attach_encoder(&lvds->connector, bridge->encoder);
+
+	ret = drm_panel_attach(lvds->panel, &lvds->connector);
+	if (ret < 0)
+		return ret;
+
+	return 0;
+}
+
+static void lvds_encoder_detach(struct drm_bridge *bridge)
+{
+	struct lvds_encoder *lvds = drm_bridge_to_lvds_encoder(bridge);
+
+	drm_panel_detach(lvds->panel);
+}
+
+static void lvds_encoder_pre_enable(struct drm_bridge *bridge)
+{
+	struct lvds_encoder *lvds = drm_bridge_to_lvds_encoder(bridge);
+
+	drm_panel_prepare(lvds->panel);
+}
+
+static void lvds_encoder_enable(struct drm_bridge *bridge)
+{
+	struct lvds_encoder *lvds = drm_bridge_to_lvds_encoder(bridge);
+
+	drm_panel_enable(lvds->panel);
+}
+
+static void lvds_encoder_disable(struct drm_bridge *bridge)
+{
+	struct lvds_encoder *lvds = drm_bridge_to_lvds_encoder(bridge);
+
+	drm_panel_disable(lvds->panel);
+}
+
+static void lvds_encoder_post_disable(struct drm_bridge *bridge)
+{
+	struct lvds_encoder *lvds = drm_bridge_to_lvds_encoder(bridge);
+
+	drm_panel_unprepare(lvds->panel);
+}
+
+static const struct drm_bridge_funcs lvds_encoder_bridge_funcs = {
+	.attach = lvds_encoder_attach,
+	.detach = lvds_encoder_detach,
+	.pre_enable = lvds_encoder_pre_enable,
+	.enable = lvds_encoder_enable,
+	.disable = lvds_encoder_disable,
+	.post_disable = lvds_encoder_post_disable,
+};
+
+static int lvds_encoder_probe(struct platform_device *pdev)
+{
+	struct lvds_encoder *lvds;
+	struct device_node *port;
+	struct device_node *endpoint;
+	struct device_node *panel;
+
+	lvds = devm_kzalloc(&pdev->dev, sizeof(*lvds), GFP_KERNEL);
+	if (!lvds)
+		return -ENOMEM;
+
+	lvds->dev = &pdev->dev;
+	platform_set_drvdata(pdev, lvds);
+
+	lvds->bridge.funcs = &lvds_encoder_bridge_funcs;
+	lvds->bridge.of_node = pdev->dev.of_node;
+	lvds->bridge.encoder_type = DRM_MODE_ENCODER_LVDS;
+
+	/* Locate the panel DT node. */
+	port = of_graph_get_port_by_id(pdev->dev.of_node, 1);
+	if (!port) {
+		dev_dbg(&pdev->dev, "port 1 not found\n");
+		return -ENXIO;
+	}
+
+	endpoint = of_get_child_by_name(port, "endpoint");
+	of_node_put(port);
+	if (!endpoint) {
+		dev_dbg(&pdev->dev, "no endpoint for port 1\n");
+		return -ENXIO;
+	}
+
+	panel = of_graph_get_remote_port_parent(endpoint);
+	of_node_put(endpoint);
+	if (!panel) {
+		dev_dbg(&pdev->dev, "no remote endpoint for port 1\n");
+		return -ENXIO;
+	}
+
+	lvds->panel = of_drm_find_panel(panel);
+	of_node_put(panel);
+	if (!lvds->panel) {
+		dev_dbg(&pdev->dev, "panel not found, deferring probe\n");
+		return -EPROBE_DEFER;
+	}
+
+	/* Register the bridge. */
+	return drm_bridge_add(&lvds->bridge);
+}
+
+static int lvds_encoder_remove(struct platform_device *pdev)
+{
+	struct lvds_encoder *encoder = platform_get_drvdata(pdev);
+
+	drm_bridge_remove(&encoder->bridge);
+
+	return 0;
+}
+
+static const struct of_device_id lvds_encoder_match[] = {
+	{ .compatible = "lvds-encoder" },
+	{},
+};
+MODULE_DEVICE_TABLE(of, lvds_encoder_match);
+
+struct platform_driver lvds_encoder_driver = {
+	.probe	= lvds_encoder_probe,
+	.remove	= lvds_encoder_remove,
+	.driver		= {
+		.name		= "lvds-encoder",
+		.of_match_table	= lvds_encoder_match,
+	},
+};
+module_platform_driver(lvds_encoder_driver);
+
+MODULE_AUTHOR("Laurent Pinchart <laurent.pinchart@ideasonboard.com>");
+MODULE_DESCRIPTION("Transparent parallel to LVDS encoder");
+MODULE_LICENSE("GPL");
-- 
Regards,

Laurent Pinchart

  parent reply	other threads:[~2016-11-29  9:04 UTC|newest]

Thread overview: 100+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-29  9:04 [PATCH v3 00/13] R-Car DU: Use drm bridge API Laurent Pinchart
2016-11-29  9:04 ` Laurent Pinchart
2016-11-29  9:04 ` [PATCH v3 01/13] drm: Don't include <drm/drm_encoder.h> in <drm/drm_crtc.h> Laurent Pinchart
2016-11-29  9:30   ` Daniel Vetter
2016-11-29  9:30     ` Daniel Vetter
2016-11-29  9:37     ` Laurent Pinchart
2016-11-29  9:37       ` Laurent Pinchart
2016-12-02 21:21   ` Sinclair Yeh
2016-12-02 21:21     ` Sinclair Yeh
2016-11-29  9:04 ` [PATCH v3 02/13] drm: Fix compilation warning caused by static inline forward declaration Laurent Pinchart
2016-11-29  9:04   ` Laurent Pinchart
2016-11-29  9:31   ` Daniel Vetter
2016-11-29  9:31     ` Daniel Vetter
2016-11-29  9:04 ` [PATCH v3 03/13] drm: bridge: Link encoder and bridge in core code Laurent Pinchart
2016-11-29  9:04   ` Laurent Pinchart
2016-11-29  9:35   ` Daniel Vetter
2016-11-29  9:35     ` Daniel Vetter
2016-11-29  9:43     ` Laurent Pinchart
2016-11-29 10:05       ` Daniel Vetter
2016-11-29 10:05         ` Daniel Vetter
2016-11-29 18:02         ` Laurent Pinchart
2016-11-29 18:02           ` Laurent Pinchart
2016-11-29 18:51           ` Laurent Pinchart
2016-11-29 10:27   ` Archit Taneja
2016-11-29 10:27     ` Archit Taneja
2016-11-29 17:57     ` Laurent Pinchart
2016-11-29 17:57       ` Laurent Pinchart
2016-11-30  5:05       ` Archit Taneja
2016-11-30  5:05         ` Archit Taneja
2016-11-30 10:23         ` Laurent Pinchart
2016-11-30 10:23           ` Laurent Pinchart
2016-11-30 11:00           ` Archit Taneja
2016-11-30 11:00             ` Archit Taneja
2016-11-30 11:05             ` Laurent Pinchart
2016-11-30 11:05               ` Laurent Pinchart
2016-11-30 13:27               ` Archit Taneja
2016-11-30 13:27                 ` Archit Taneja
2016-11-29 17:01   ` Stefan Agner
2016-11-29 17:01     ` Stefan Agner
2016-11-29 19:58   ` Boris Brezillon
2016-11-29 19:58     ` Boris Brezillon
2016-11-30 15:30   ` Vincent ABRIOU
2016-11-30 15:30     ` Vincent ABRIOU
2016-11-29  9:04 ` [PATCH v3 04/13] drm: bridge: Detach bridge from encoder at encoder cleanup time Laurent Pinchart
2016-11-29  9:04   ` Laurent Pinchart
2016-11-29  9:48   ` Daniel Vetter
2016-11-29  9:48     ` Daniel Vetter
2016-11-29 19:00     ` Laurent Pinchart
2016-11-29 10:34   ` Archit Taneja
2016-11-29 18:56     ` Laurent Pinchart
2016-11-29 18:56       ` Laurent Pinchart
2016-11-29 20:22       ` Daniel Vetter
2016-11-29 20:22         ` Daniel Vetter
2016-11-29 21:54         ` [PATCH] drm: bridge: Detach all bridges in a chain " Laurent Pinchart
     [not found] ` <1480410283-28698-1-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2016-11-29  9:04   ` [PATCH v3 05/13] drm: bridge: Add LVDS encoder DT bindings Laurent Pinchart
2016-11-29  9:04     ` Laurent Pinchart
2016-11-29  9:04 ` Laurent Pinchart [this message]
2016-11-29  9:54   ` [PATCH v3 06/13] drm: bridge: Add LVDS encoder driver Daniel Vetter
2016-11-29 20:57     ` Laurent Pinchart
2016-11-29 20:57       ` Laurent Pinchart
2017-01-04  1:33       ` Laurent Pinchart
2017-01-04  8:18       ` Daniel Vetter
2017-01-04  8:18         ` Daniel Vetter
2017-01-04 13:08         ` Laurent Pinchart
2017-01-04 13:08           ` Laurent Pinchart
2017-01-04 13:51           ` Daniel Vetter
2017-01-04 14:33             ` Laurent Pinchart
2017-01-04 14:33               ` Laurent Pinchart
2017-01-04 14:58               ` Daniel Vetter
2017-01-04 14:58                 ` Daniel Vetter
2017-01-04 15:13                 ` Laurent Pinchart
2017-01-04 15:13                   ` Laurent Pinchart
2017-03-02  0:30                   ` Laurent Pinchart
2017-03-02  0:30                     ` Laurent Pinchart
2017-03-02  7:05                     ` Daniel Vetter
2017-03-02  7:05                       ` Daniel Vetter
2016-11-29  9:04 ` [PATCH v3 07/13] drm: bridge: vga-dac: Add adi,adv7123 compatible string Laurent Pinchart
2016-11-29  9:04   ` [PATCH v3 07/13] drm: bridge: vga-dac: Add adi, adv7123 " Laurent Pinchart
2016-11-29  9:50   ` [PATCH v3 07/13] drm: bridge: vga-dac: Add adi,adv7123 " Maxime Ripard
2016-11-29  9:50     ` Maxime Ripard
2016-11-29  9:04 ` [PATCH v3 08/13] drm: bridge: lvds-encoder: Add thine,thc63lvdm83d " Laurent Pinchart
2016-11-29  9:04   ` [PATCH v3 08/13] drm: bridge: lvds-encoder: Add thine, thc63lvdm83d " Laurent Pinchart
2016-11-29  9:04 ` [PATCH v3 09/13] drm: Add encoder_type field to the drm_bridge structure Laurent Pinchart
2016-11-29  9:56   ` Daniel Vetter
2016-11-29  9:58     ` Laurent Pinchart
2016-11-29  9:58       ` Laurent Pinchart
2016-11-29 10:27       ` Daniel Vetter
2016-11-29 10:27         ` Daniel Vetter
2016-11-29 17:49         ` Laurent Pinchart
2016-11-29 20:25           ` Daniel Vetter
2016-11-29 22:42             ` Laurent Pinchart
2016-11-29  9:04 ` [PATCH v3 10/13] drm: bridge: Set bridges' encoder type Laurent Pinchart
2016-11-29  9:04 ` [PATCH v3 11/13] drm: Set on-chip " Laurent Pinchart
2016-11-29  9:04   ` Laurent Pinchart
2016-11-30 15:28   ` Vincent ABRIOU
2016-11-30 15:28     ` Vincent ABRIOU
2016-11-29  9:04 ` [PATCH v3 12/13] drm: rcar-du: Replace manual bridge implementation with DRM bridge Laurent Pinchart
2016-12-27 12:40   ` Geert Uytterhoeven
2016-12-27 12:40     ` Geert Uytterhoeven
2016-11-29  9:04 ` [PATCH v3 13/13] drm: rcar-du: Initialize encoder's type based on the bridge's type Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1480410283-28698-7-git-send-email-laurent.pinchart+renesas@ideasonboard.com \
    --to=laurent.pinchart+renesas@ideasonboard.com \
    --cc=architt@codeaurora.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.