From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v3 01/15] docs: L2 Cache Allocation
 Technology (CAT) feature document.
Date: Tue, 29 Nov 2016 13:22:41 +0100
Message-ID: <1480422161.3178.53.camel@citrix.com>
References: <1477366863-5246-1-git-send-email-yi.y.sun@linux.intel.com>
 <1477366863-5246-2-git-send-email-yi.y.sun@linux.intel.com>
 <1480095581.2712.192.camel@citrix.com> <20161129045217.GB7435@yi.y.sun>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2887789106694284729=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <prvs=134b22ba0=dario.faggioli@citrix.com>)
 id 1cBhQx-0002pX-FT
 for xen-devel@lists.xenproject.org; Tue, 29 Nov 2016 12:22:51 +0000
In-Reply-To: <20161129045217.GB7435@yi.y.sun>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Yi Sun <yi.y.sun@linux.intel.com>
Cc: wei.liu2@citrix.com, he.chen@linux.intel.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, jbeulich@suse.com, xen-devel@lists.xenproject.org, chao.p.peng@linux.intel.com
List-Id: xen-devel@lists.xenproject.org

--===============2887789106694284729==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="=-Gru+52eB4SVZLFQSKbxn"

--=-Gru+52eB4SVZLFQSKbxn
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2016-11-29 at 12:52 +0800, Yi Sun wrote:
> On 16-11-25 18:39:41, Dario Faggioli wrote:
> > On Tue, 2016-10-25 at 11:40 +0800, Yi Sun wrote:
> > > +* xl interfaces:
> > > +
> > > +=C2=A0=C2=A01. `psr-cat-show [OPTIONS] domain-id`:
> > > +
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Show domain L2 or L3 CAT CBM.
> > > +
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0New option `-l` is added.
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0`-l2`: Specify cbm for L2 cache.
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0`-l3`: Specify cbm for L3 cache.
> > > +
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0If neither `-l2` nor `-l3` is given, l=
evel 3 is the default
> > > option.
> > > +
> > Sorry for saying this only now, but wouldn't it be more natural, if
> > neither -l2 not -l3 is specified, to show both (or, in general, all
> > that is supported)?
> >=20
> This is for backward compatibility. The original command only
> supports
> L3 CAT and it does not have '-l' option.
>=20
> But for show command, your suggestion is good. We can show both or
> prompt user if any one is not supported.
>=20
I don't understand. I was actually talking about 'show' already, basing
on this that I see in the patch:

+=C2=A0=C2=A01. `psr-cat-show [OPTIONS] domain-id`:>=C2=A0>=C2=A0>=C2=A0
+
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Show domain L2 or L3 CAT CBM.

However, now that I look better, I notice that, when explaining the
options, you write "Specify cbm for L2 cache.", which is not what I
expect show to do. Shouldn't that say "Show" or "Display"?

Cut-&-paste error (from below), or there is really something I'm
missing?

> > > +=C2=A0=C2=A02. `psr-cat-cbm-set [OPTIONS] domain-id cbm`:
> > > +
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Set domain L2 or L3 CBM.
> > > +
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0New option `-l` is added.
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0`-l2`: Specify cbm for L2 cache.
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0`-l3`: Specify cbm for L3 cache.
> > > +
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0If neither `-l2` nor `-l3` is given, l=
evel 3 is the default
> > > option.
> > > +

Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
--=-Gru+52eB4SVZLFQSKbxn
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJYPXMSAAoJEBZCeImluHPuY9MQAMO/08AzQjxvQ+x0h3pN88qu
DEz1elL3HYrwFxkX7wphfM56zeljXK752bvHQXThTmZ5YhumbvSQDADLleXL8sns
JCW3lja/6t+3YUvwyJXqd72nZGscdczyMZ6JIuYuewQFB3tNFuu4bCgTdrgHdb2i
GdpOdKaXDbFj4CXblZgjTQ1U/iDPR/fuoaWyoEOpwpgD1ZzwreMw7rPzajmXhwHV
P3blYpGb/G6SM2lVSvWMDlRV+CJz/9MVIVTOwCaJLA0XHqk81gZaGQdZknl8kxiB
kxsWao5QdR5tlpfZIs9P+tjpKRuzHGZ6kw7LTJCHXhiF0lNsL9tFWIzsHfvbzLwm
R3MR1Ineju400Rniditc+xh0Gc7RcDo2p1eySLQ4hwd9tF2NeNXFOBcF//6EpbN3
vGTgIop6o9Y0blIfjyQtXX8xHxyTLe/yuB3KTPXmNMMa+w2K5nibFWEmcqOhUSPw
9v+toZU+zvt7dbWnmWhaBLZx5zXL1g/Ko95hWj2AN1bIu+wdzRZZ3lonpmxI5o+r
yp+nF8GPXXyKN9gZGPdAQDVDSWNT7UXLfmC8X1Ye684PFfy/ZZrv3e3cc1y82rdG
7ARzm7vewqMSMyp0NebyjYxf3G/5aHF8/hI3NfxZH1/8DP9I62e7ByXHTaJVook+
jjsRcA9D28dEuU3HmLiF
=QcqN
-----END PGP SIGNATURE-----

--=-Gru+52eB4SVZLFQSKbxn--


--===============2887789106694284729==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v
cmcveGVuLWRldmVsCg==

--===============2887789106694284729==--