From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Keller, Jacob E" Subject: Re: [PATCH RFC v2] ethtool: implement helper to get flow_type value Date: Tue, 29 Nov 2016 18:44:16 +0000 Message-ID: <1480445054.3154.4.camel@intel.com> References: <20161128230343.19110-1-jacob.e.keller@intel.com> <20161129152144.484bea62@jkicinski-Precision-T1700> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "netdev@vger.kernel.org" , "davem@davemloft.net" , "intel-wired-lan@lists.osuosl.org" To: "kubakici@wp.pl" Return-path: Received: from mga04.intel.com ([192.55.52.120]:49768 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933973AbcK2SoS (ORCPT ); Tue, 29 Nov 2016 13:44:18 -0500 In-Reply-To: <20161129152144.484bea62@jkicinski-Precision-T1700> Content-Language: en-US Content-ID: <5D5D4DF9D29E154F94228C1DE7DA0A7A@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: T24gVHVlLCAyMDE2LTExLTI5IGF0IDE1OjIxICswMDAwLCBKYWt1YiBLaWNpbnNraSB3cm90ZToN Cj4gT24gTW9uLCAyOCBOb3YgMjAxNiAxNTowMzo0MyAtMDgwMCwgSmFjb2IgS2VsbGVyIHdyb3Rl Og0KPiA+ICtzdGF0aWMgaW5saW5lIF9fdTMyIGV0aHRvb2xfZ2V0X2Zsb3dfc3BlY190eXBlKF9f dTMyIGZsb3dfdHlwZSkNCj4gPiArew0KPiA+ICsJcmV0dXJuIGZsb3dfdHlwZSAmIChGTE9XX0VY VCB8IEZMT1dfTUFDX0VYVCk7DQo+IA0KPiBJIGRvbid0IGhhdmUgYW55dGhpbmcgb2Ygc3Vic3Rh bmNlIHRvIHNheSBidXQgSSB0aGluayB5b3UgYXJlIG1pc3NpbmcNCj4gYQ0KPiBuZWdhdGlvbiAo fikgaGVyZSBjb21wYXJlZCB0byB0aGUgY29kZSB5b3UgYXJlIHJlcGxhY2luZyA7KQ0KDQpIQUgh IFllcyB5b3UgYXJlIHJpZ2h0LiBJIG1hZGUgYSBtaXN0YWtlIHdoZW4gY29weWluZyB0aGlzIG91 dCBvZiBteQ0KZHJpdmVyIGhlYWRlciBmaWxlLg0KDQpXaWxsIGZpeC4gU29ycnkgZm9yIHRoZSB0 aHJhc2gsIGFuZCB0aGFua3MgZm9yIGNhdGNoaW5nIG15IG1pc3Rha2UuDQoNClJlZ2FyZHMsDQpK YWtl From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keller, Jacob E Date: Tue, 29 Nov 2016 18:44:16 +0000 Subject: [Intel-wired-lan] [PATCH RFC v2] ethtool: implement helper to get flow_type value In-Reply-To: <20161129152144.484bea62@jkicinski-Precision-T1700> References: <20161128230343.19110-1-jacob.e.keller@intel.com> <20161129152144.484bea62@jkicinski-Precision-T1700> Message-ID: <1480445054.3154.4.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Tue, 2016-11-29 at 15:21 +0000, Jakub Kicinski wrote: > On Mon, 28 Nov 2016 15:03:43 -0800, Jacob Keller wrote: > > +static inline __u32 ethtool_get_flow_spec_type(__u32 flow_type) > > +{ > > + return flow_type & (FLOW_EXT | FLOW_MAC_EXT); > > I don't have anything of substance to say but I think you are missing > a > negation (~) here compared to the code you are replacing ;) HAH! Yes you are right. I made a mistake when copying this out of my driver header file. Will fix. Sorry for the thrash, and thanks for catching my mistake. Regards, Jake