From: kys@exchange.microsoft.com
To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
vkuznets@redhat.com, jasowang@redhat.com,
leann.ogasawara@canonical.com
Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Subject: [PATCH 12/15] hv: don't reset hv_context.tsc_page on crash
Date: Thu, 1 Dec 2016 09:28:49 -0800 [thread overview]
Message-ID: <1480613332-7788-12-git-send-email-kys@exchange.microsoft.com> (raw)
In-Reply-To: <1480613332-7788-1-git-send-email-kys@exchange.microsoft.com>
From: Vitaly Kuznetsov <vkuznets@redhat.com>
It may happen that secondary CPUs are still alive and resetting
hv_context.tsc_page will cause a consequent crash in read_hv_clock_tsc()
as we don't check for it being not NULL there. It is safe as we're not
freeing this page anyways.
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
drivers/hv/hv.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
index 4ece040..04a0fd8 100644
--- a/drivers/hv/hv.c
+++ b/drivers/hv/hv.c
@@ -309,9 +309,10 @@ void hv_cleanup(bool crash)
hypercall_msr.as_uint64 = 0;
wrmsrl(HV_X64_MSR_REFERENCE_TSC, hypercall_msr.as_uint64);
- if (!crash)
+ if (!crash) {
vfree(hv_context.tsc_page);
- hv_context.tsc_page = NULL;
+ hv_context.tsc_page = NULL;
+ }
}
#endif
}
--
1.7.4.1
next prev parent reply other threads:[~2016-12-01 15:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 17:28 [PATCH 00/15] Drivers: hv: CPU management fixes and a new uio driver kys
2016-12-01 17:28 ` [PATCH 01/15] Drivers: hv: vmbus: Raise retry/wait limits in vmbus_post_msg() kys
2016-12-01 17:28 ` [PATCH 02/15] hyperv: Add a function to detect hv_device kys
2016-12-01 20:33 ` Greg KH
2016-12-02 5:46 ` KY Srinivasan
2016-12-01 20:35 ` Greg KH
2016-12-01 20:38 ` Greg KH
2016-12-02 6:02 ` KY Srinivasan
2016-12-02 6:48 ` Greg KH
2016-12-02 7:14 ` KY Srinivasan
2016-12-02 7:36 ` Greg KH
2016-12-02 15:38 ` KY Srinivasan
2016-12-02 16:02 ` Greg KH
2016-12-02 21:41 ` KY Srinivasan
2016-12-01 17:28 ` [PATCH 03/15] hyperv: Fix spelling of HV_UNKOWN kys
2016-12-01 17:28 ` [PATCH 04/15] Drivers: hv: vmbus: Prevent sending data on a rescinded channel kys
2016-12-01 20:36 ` Greg KH
2016-12-05 10:01 ` Dan Carpenter
2016-12-05 15:50 ` KY Srinivasan
2016-12-01 17:28 ` [PATCH 05/15] Drivers: hv: vmbus: Enhance the rescind callback functionality kys
2016-12-01 20:36 ` Greg KH
2016-12-01 17:28 ` [PATCH 06/15] hv: acquire vmbus_connection.channel_mutex in vmbus_free_channels() kys
2016-12-01 20:37 ` Greg KH
2016-12-02 6:11 ` KY Srinivasan
2016-12-01 17:28 ` [PATCH 07/15] hv: allocate synic pages for all present CPUs kys
2016-12-01 17:28 ` [PATCH 08/15] hv: init percpu_list in hv_synic_alloc() kys
2016-12-01 17:28 ` [PATCH 09/15] hv: change clockevents unbind tactics kys
2016-12-01 17:28 ` [PATCH 10/15] hv: switch to cpuhp state machine for synic init/cleanup kys
2016-12-01 17:28 ` [PATCH 11/15] hv: make CPU offlining prevention fine-grained kys
2016-12-01 17:28 ` kys [this message]
2016-12-01 17:28 ` [PATCH 13/15] vmbus: add support for dynamic device id's kys
2016-12-01 17:28 ` [PATCH 14/15] uio-hv-generic: new userspace i/o driver for VMBus kys
2016-12-01 17:28 ` [PATCH 15/15] Tools: hv: kvp: configurable external scripts path kys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480613332-7788-12-git-send-email-kys@exchange.microsoft.com \
--to=kys@exchange.microsoft.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=leann.ogasawara@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.