All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 3/4] tcp: tsq: add shortcut in tcp_tasklet_func()
Date: Fri, 02 Dec 2016 14:12:30 -0800	[thread overview]
Message-ID: <1480716750.18162.387.camel@edumazet-glaptop3.roam.corp.google.com> (raw)
In-Reply-To: <1480703159-2327-4-git-send-email-edumazet@google.com>

On Fri, 2016-12-02 at 10:25 -0800, Eric Dumazet wrote:
> Under high stress, I've seen tcp_tasklet_func() consuming
> ~700 usec, handling ~150 tcp sockets.
> 
> By setting TCP_TSQ_DEFERRED in tcp_wfree(), we give a chance
> for other cpus/threads entering tcp_write_xmit() to grab it,
> allowing tcp_tasklet_func() to skip sockets that already did
> an xmit cycle.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>

...

> @@ -884,7 +884,7 @@ void tcp_wfree(struct sk_buff *skb)
>  		if (!(oval & TSQF_THROTTLED) || (oval & TSQF_QUEUED))
>  			goto out;
>  
> -		nval = (oval & ~TSQF_THROTTLED) | TSQF_QUEUED;
> +		nval = (oval & ~TSQF_THROTTLED) | TSQF_QUEUED | TCP_TSQ_DEFERRED;

Typo here...

Should be :
		nval = (oval & ~TSQF_THROTTLED) | TSQF_QUEUED | TCPF_TSQ_DEFERRED;

>  		nval = cmpxchg(&tp->tsq_flags, oval, nval);
>  		if (nval != oval)
>  			continue;

  reply	other threads:[~2016-12-02 22:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-02 18:25 [PATCH net-next 0/4] tcp: tsq: performance series Eric Dumazet
2016-12-02 18:25 ` [PATCH net-next 1/4] tcp: tsq: add tsq_flags / tsq_enum Eric Dumazet
2016-12-02 18:25 ` [PATCH net-next 2/4] tcp: tsq: remove one locked operation in tcp_wfree() Eric Dumazet
2016-12-02 18:25 ` [PATCH net-next 3/4] tcp: tsq: add shortcut in tcp_tasklet_func() Eric Dumazet
2016-12-02 22:12   ` Eric Dumazet [this message]
2016-12-02 18:25 ` [PATCH net-next 4/4] tcp: tsq: avoid one atomic in tcp_wfree() Eric Dumazet
2016-12-02 20:57 ` [PATCH net-next 0/4] tcp: tsq: performance series Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1480716750.18162.387.camel@edumazet-glaptop3.roam.corp.google.com \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.