From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harish Patil Subject: [PATCH 1/7] net/qede: reduce noise in debug logs Date: Fri, 2 Dec 2016 18:43:53 -0800 Message-ID: <1480733039-13046-1-git-send-email-harish.patil@qlogic.com> Mime-Version: 1.0 Content-Type: text/plain Cc: , Rasesh Mody , Harish Patil To: Return-path: Received: from mx0b-0016ce01.pphosted.com (mx0b-0016ce01.pphosted.com [67.231.156.153]) by dpdk.org (Postfix) with ESMTP id 0827F68BD for ; Sat, 3 Dec 2016 03:44:07 +0100 (CET) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Rasesh Mody Replace CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER with CONFIG_RTE_LIBRTE_QEDE_DEBUG_VAL which is a 32-bit bitmapped value where each bit represent a particular submodule to debug. Also move notice messages under CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO. Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody --- config/common_base | 2 +- doc/guides/nics/qede.rst | 4 ++-- drivers/net/qede/qede_ethdev.c | 4 ++-- drivers/net/qede/qede_logs.h | 21 +++++---------------- 4 files changed, 10 insertions(+), 21 deletions(-) diff --git a/config/common_base b/config/common_base index 4bff83a..2ffd557 100644 --- a/config/common_base +++ b/config/common_base @@ -320,7 +320,7 @@ CONFIG_RTE_LIBRTE_BOND_DEBUG_ALB_L1=n CONFIG_RTE_LIBRTE_QEDE_PMD=y CONFIG_RTE_LIBRTE_QEDE_DEBUG_INIT=n CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO=n -CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER=n +CONFIG_RTE_LIBRTE_QEDE_DEBUG_VAL=0 CONFIG_RTE_LIBRTE_QEDE_DEBUG_TX=n CONFIG_RTE_LIBRTE_QEDE_DEBUG_RX=n #Provides abs path/name of the firmware file. diff --git a/doc/guides/nics/qede.rst b/doc/guides/nics/qede.rst index d22ecdd..ddf4248 100644 --- a/doc/guides/nics/qede.rst +++ b/doc/guides/nics/qede.rst @@ -103,9 +103,9 @@ enabling debugging options may affect system performance. Toggle display of generic debugging messages. -- ``CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER`` (default **n**) +- ``CONFIG_RTE_LIBRTE_QEDE_DEBUG_VAL`` (default **0**) - Toggle display of ecore related messages. + Control driver debug verbosity using 32-bit bitmap flags. - ``CONFIG_RTE_LIBRTE_QEDE_DEBUG_TX`` (default **n**) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 2c600c1..69cedd8 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -1393,8 +1393,8 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf) uint8_t is_mac_forced; bool is_mac_exist; /* Fix up ecore debug level */ - uint32_t dp_module = ~0 & ~ECORE_MSG_HW; - uint8_t dp_level = ECORE_LEVEL_VERBOSE; + uint32_t dp_module = RTE_LIBRTE_QEDE_DEBUG_VAL; + uint8_t dp_level = ECORE_LEVEL_NOTICE; uint32_t max_mac_addrs; int rc; diff --git a/drivers/net/qede/qede_logs.h b/drivers/net/qede/qede_logs.h index 45c4af0..08fdf04 100644 --- a/drivers/net/qede/qede_logs.h +++ b/drivers/net/qede/qede_logs.h @@ -16,15 +16,18 @@ (p_dev)->name ? (p_dev)->name : "", \ ##__VA_ARGS__) +#ifdef RTE_LIBRTE_QEDE_DEBUG_INFO #define DP_NOTICE(p_dev, is_assert, fmt, ...) \ rte_log(RTE_LOG_NOTICE, RTE_LOGTYPE_PMD,\ "[QEDE PMD: (%s)]%s:" fmt, \ (p_dev)->name ? (p_dev)->name : "", \ __func__, \ ##__VA_ARGS__) +#else +#define DP_NOTICE(p_dev, fmt, ...) do { } while (0) +#endif #ifdef RTE_LIBRTE_QEDE_DEBUG_INFO - #define DP_INFO(p_dev, fmt, ...) \ rte_log(RTE_LOG_INFO, RTE_LOGTYPE_PMD, \ "[%s:%d(%s)]" fmt, \ @@ -33,10 +36,8 @@ ##__VA_ARGS__) #else #define DP_INFO(p_dev, fmt, ...) do { } while (0) - #endif -#ifdef RTE_LIBRTE_QEDE_DEBUG_DRIVER #define DP_VERBOSE(p_dev, module, fmt, ...) \ do { \ if ((p_dev)->dp_module & module) \ @@ -46,9 +47,7 @@ (p_dev)->name ? (p_dev)->name : "", \ ##__VA_ARGS__); \ } while (0) -#else -#define DP_VERBOSE(p_dev, fmt, ...) do { } while (0) -#endif + #define PMD_INIT_LOG(level, edev, fmt, args...) \ rte_log(RTE_LOG_ ## level, RTE_LOGTYPE_PMD, \ @@ -77,14 +76,4 @@ #define PMD_RX_LOG(level, q, fmt, args...) do { } while (0) #endif -#ifdef RTE_LIBRTE_QEDE_DEBUG_DRIVER -#define PMD_DRV_LOG_RAW(level, fmt, args...) \ - RTE_LOG(level, PMD, "%s(): " fmt, __func__, ## args) -#else -#define PMD_DRV_LOG_RAW(level, fmt, args...) do { } while (0) -#endif - -#define PMD_DRV_LOG(level, fmt, args...) \ - PMD_DRV_LOG_RAW(level, fmt "\n", ## args) - #endif /* _QEDE_LOGS_H_ */ -- 1.8.3.1