From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753033AbcLGJxY (ORCPT ); Wed, 7 Dec 2016 04:53:24 -0500 Received: from mx2.suse.de ([195.135.220.15]:41331 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752618AbcLGJxW (ORCPT ); Wed, 7 Dec 2016 04:53:22 -0500 Message-ID: <1481104008.1960.3.camel@suse.com> Subject: Re: [PATCHv13 2/3] usb: USB Type-C connector class From: Oliver Neukum To: Guenter Roeck Cc: Heikki Krogerus , Greg KH , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Date: Wed, 07 Dec 2016 10:46:48 +0100 In-Reply-To: <20161202180439.GA25991@roeck-us.net> References: <20161124122144.26259-1-heikki.krogerus@linux.intel.com> <20161124122144.26259-3-heikki.krogerus@linux.intel.com> <20161129162744.GA2255@kroah.com> <20161130091910.GD32668@kuha.fi.intel.com> <20161202180439.GA25991@roeck-us.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-12-02 at 10:04 -0800, Guenter Roeck wrote: Hi, > At least for my part I very much concentrated on making sure that > the user space ABI as well as the port driver API are sane and usable. Rightly so, as this part cannot be changed once included in a kernel release. So, can we agree that that part at least is ready to go? > The driver interface is not my area of expertise. As such, my testing > and understanding of that part was limited to "it appears to work, > it must be ok". I very much relied on you to get this part right. > > That makes me feel really bad. It isn't fun to have my "Reviewed-by" > on a patch that gets (and apparently deserves) a WTF from a senior > kernel maintainer. This hurts both your and my reputation, and obviously > will make me quite hesitant to add a "Reviewed-by:" to the next version > of the series. The driver model is arcane. It is the reason we have people who really understand it review code. But I think it is a reason we need to question assumptions. Is it really true that the lifetimes of both ends of a plug are tightly locked? What happens if you unplug a cable whose ends have different power supplies? Regards Oliver