From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Paul Durrant <paul.durrant@citrix.com>, xen-devel@lists.xenproject.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Julien Grall <julien.grall@arm.com>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH] tools/libxenforeignmemory: add a call to restrict the handle
Date: Fri, 24 Mar 2017 20:10:27 +0000 [thread overview]
Message-ID: <1481302f-a9a5-a5fc-7935-296bae2ad130@citrix.com> (raw)
In-Reply-To: <1490181925-8026-1-git-send-email-paul.durrant@citrix.com>
On 22/03/17 11:25, Paul Durrant wrote:
> diff --git a/tools/libs/foreignmemory/libxenforeignmemory.map b/tools/libs/foreignmemory/libxenforeignmemory.map
> index df206b3..5c9806c 100644
> --- a/tools/libs/foreignmemory/libxenforeignmemory.map
> +++ b/tools/libs/foreignmemory/libxenforeignmemory.map
> @@ -4,5 +4,6 @@ VERS_1.0 {
> xenforeignmemory_close;
> xenforeignmemory_map;
> xenforeignmemory_unmap;
> + xenforeignmemory_restrict;
> local: *; /* Do not expose anything by default */
> };
This isn't correct.
New functions like this need to bump at least the SO minor version, like
c/s f1446de4ba
Fixing this is a blocker to releasing 4.9
Also, we should really get automatic ABI checking built into the release
process, to prevent mistakes like this from happening accidentally.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-03-24 20:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 11:25 [PATCH] tools/libxenforeignmemory: add a call to restrict the handle Paul Durrant
2017-03-24 11:40 ` Wei Liu
2017-03-24 20:10 ` Andrew Cooper [this message]
2017-03-24 20:24 ` Paul Durrant
2017-03-27 8:06 ` Paul Durrant
2017-03-27 8:16 ` Andrew Cooper
2017-03-27 8:20 ` Paul Durrant
2017-03-27 18:03 ` Julien Grall
2017-03-27 22:54 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481302f-a9a5-a5fc-7935-296bae2ad130@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=paul.durrant@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.