From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754619AbcLNDcx (ORCPT ); Tue, 13 Dec 2016 22:32:53 -0500 Received: from mail-ve1eur01on0130.outbound.protection.outlook.com ([104.47.1.130]:39280 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751256AbcLNDcu (ORCPT ); Tue, 13 Dec 2016 22:32:50 -0500 X-Greylist: delayed 11980 seconds by postgrey-1.27 at vger.kernel.org; Tue, 13 Dec 2016 22:32:49 EST Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=peda@axentia.se; From: Peter Rosin To: linux-kernel@vger.kernel.org Cc: Peter Rosin , Sebastian Reichel , Rob Herring , Mark Rutland , linux-pm@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v2 1/3] power: supply: bq24735-charger: simplify register update to stop charging Date: Wed, 14 Dec 2016 00:56:43 +0100 Message-Id: <1481673405-4547-2-git-send-email-peda@axentia.se> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1481673405-4547-1-git-send-email-peda@axentia.se> References: <1481673405-4547-1-git-send-email-peda@axentia.se> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [217.210.101.82] X-ClientProxiedBy: DB6P195CA0006.EURP195.PROD.OUTLOOK.COM (10.171.120.144) To AM5PR0201MB2305.eurprd02.prod.outlook.com (10.169.242.149) X-MS-Office365-Filtering-Correlation-Id: 931f3599-327d-4984-50e6-08d423b3bd62 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:AM5PR0201MB2305; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0201MB2305;3:BcrV9XBTT79wkigSLIyBvXXVPOr/Mt2CGNWL0Vy9LK088Izf6qZwOi/NzbdGYYkb2B5PF5PjgxuD/iCtOJAskbx7Feni2TBPEFnD2MYdxCn5LIL/GevUIcCJ7yMEhJmjRbWaLH3ZLAFdcxyzvKlWoTUbniGsFWJP3+D5PVS93zIQJJmkHHnErGaXcNgQRelKBabem+gRpm+ZwOmqNNOsZoP+XpbHgy/v5ANPyAJ3H1ASIg6vB/kE1B5KPgJf4Eeu9Cw6UE94SwW1u/9v92hXlw==;25:nn1rYvstwx7LgAZGCKBilIz3M37AirkayhXzZrab+uwCBdNkaKzqav2FZFYExj3v6cujz3OVV5+MVI/hEH2EEZ+GzS1vzFjcDmcYz3prfdd/t8oyN2SULLF96H7ay38m6w6xq2xc4R49c+Y7KvTw82wlJHhDuhlfTSzFH85DBB44dMI9nL6nhj2c00dQgQfswQ71CxYRMo8V3ci4Mu78eZlgUYBqsR+tPW4MQob1HZTPFRPezshyUS/Utcz72CyXNPajwBv2naCI5ueOC3if1kvkhSRvROxmZ1MqUAZzJpLs8EBXwBxUiacQVsKnV35xZWarwTZaynU7pl4BfEapmxd8BFP/laBKsQWMyNqnJFTy8PYfPrDZm7gVv0tsho5hAAnOd9A8hSwxJXNw5+bDF00B2qChRyEEsbVL9HYpwN2QoDtN+LU0I6VH6XmKENXb1tb8G417VAs6V+RwHGeeKA== X-Microsoft-Exchange-Diagnostics: 1;AM5PR0201MB2305;31:+No3f5fLibH/oMQ3KBg2sVNoopYWmHcU5Dr2YlQfrCoorCzcI/kcuF+kkRSL2F7UjtzSr+9fzt1/hq3LRYNd8jYRWhJ2pBq4Q7+K/aECj2+IgbIhqko39LLMAkj/HG24bF/giHNAhNRHZZGYIovxYErmHhI9w6EKspioc2rOOzk4rgAtBOmwU8/R7jrA6kM4sFtW0xXuiulnwhi0G3OHuHkXHjwD3vcQ8jHLsfqsSQDyQfXuIqSbu2ObTo/nVUXisZmEwk598eVk+UpXF80GJw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123562025)(20161123564025)(20161123560025)(20161123555025)(20161123558021)(2016111802025)(6072148)(6043046);SRVR:AM5PR0201MB2305;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0201MB2305; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0201MB2305;4:i7/IAoqTdW8R1Xphcqa9BEhJZVSDClh0H83AzpFPk6Free8TdzPJnlZ/0IZhMYVo6CYyQvZ+9HBEIcj46M1dpaeN8dyAvb9AGfQAEJvTYsuLxcY8zSuvauIPNSJ+BfpmIEejBKZfAmWZEdVSCR9ACABoEcD1xvf/OkPMiUJPuPHwZjzvomCoGvc5R9MtDLexwuggMwzo1pSTetb5Mw/PNY1llmfQVJRfvgGh2kNHHmkdogXcXrKwmr63bDlNKAAZFa8EJIF0GSrH8/EW/wxEyv8hhXLh73U5XBaLafscXpyAPLwDssUuaFpB6u3KyCfys9tPGBLTfKV+Q1nLqwsIwcatws4wEBMgISzSOmmlIMJ/2Y5cSMR/mGciP+e32gXo7cQt2RyJwcTZb9DKxbmuY5zi6+mbegHN9ApCnVuzxaPulXXHDGkZrZGTNtV/ZeTftL60+/9j6zX9BQoshWlnktbGni7+4PCZrxwTWE7jGRPsnCcnJ8ZrePxadDqw1WtCDovaYcJwSTGOIwru6NaYUemWBz3svH5JKVsNHUHIv6kJkqkb2xKSJh0rUk221ItOsxH5Ag0pmjfW0wZdFOJSAvaRVHB7ngls+EOaMeWWIzRFgmurYkqQCWr5jtAw/MO5fWlrYwruIJS5Wm7bW2FjE0PuHUt/jR+CPOP5Xfndk6Q= X-Forefront-PRVS: 01559F388D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6069001)(7916002)(39450400003)(39830400002)(39410400002)(199003)(189002)(92566002)(86362001)(6666003)(47776003)(2950100002)(38730400001)(6916009)(305945005)(7736002)(36756003)(66066001)(575784001)(50986999)(33646002)(2906002)(42186005)(48376002)(50466002)(105586002)(106356001)(2351001)(68736007)(74482002)(6506006)(97736004)(101416001)(3846002)(76176999)(2361001)(6116002)(189998001)(6486002)(81156014)(5003940100001)(4326007)(8676002)(50226002)(110136003)(5660300001)(81166006)(6512006)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:AM5PR0201MB2305;H:localhost.localdomain;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;AM5PR0201MB2305;23:FBVv5MCVCVnPcl61dTeACyluYQrXnJy3SShrSNs?= =?us-ascii?Q?agTTCF4cmhqFgwoGXcoTxwMLciHSJeSURwtj5VfRtHJg5Uit0ODVmMIKkCpA?= =?us-ascii?Q?ma/HV1wUafeArMS5ZHcrkuXAslmRqckp3ibPjG84A4qZZU60qTx7w4Xu8KuD?= =?us-ascii?Q?v1Yo8SgkXvjD3D08GKcjnNQ5vV7/pUHTQ3b85c+Z3RMV2eu1fiCBdeVOQplX?= =?us-ascii?Q?DUwL/0KV3kDJIJmXgf/3/gbp+hQ19pIm3YiR4CDyNvY4SRXLFqdu5ICHS/5v?= =?us-ascii?Q?ErfWGY3x4RUCevWOxAa/GVgbaX1qZrTBwbbnt40aH3HxnV7NVHFkJ6AVZQvh?= =?us-ascii?Q?P1k5EowOulTZsoMdz1WFeBf7HWEqzan3ntlSFt+MgCXTacmSxvYI0O/jYS/n?= =?us-ascii?Q?EchTfpqevALfUt4azKZ7TZKsJlBL795/bZuJQYL4+DkZzBpcsK3v2q79u7v7?= =?us-ascii?Q?bLPu5H4527qq/ZXlPvVAQ0jbd+USKq+9rUeuwzM9kmCi0H7tyhlBg6YXFBlM?= =?us-ascii?Q?1ZwOw1XZazs9qwDc+c5riOqZ3J0bMs4yu3oWBkYRddE2si+VhRda5XZDIYJW?= =?us-ascii?Q?qsBC8PLv9YAgo/+VP73S493fPNistSDCPiT+ddnFPLg9V+s0hVXVC6+rKVMH?= =?us-ascii?Q?aXdXpURC+aRyelTKExVW19cOQV9NOa12qhIO1Q1WV6bkzeex2gU6qHJ1+huB?= =?us-ascii?Q?VB1z3HKKmfd9JAQMuuOIvhdgLRgH411Ig1AkorKMen8AWc/8gYvjTyS+bsC4?= =?us-ascii?Q?GIy4p8bilZMO8ecLQ1y03HvN3v+aR7//G+TqSS1dH5MZX+Hd46plPsr+pKWd?= =?us-ascii?Q?s9hkhMyOnjjxtg25HehD30owEnoJsMCEJYEJkclE/W4cL/HCmrJRSGww5xHQ?= =?us-ascii?Q?Qy/vIBm1MnWN7Dr74GMIfMbtqC03JQ+XlD5KQUGeeuFbVgJh7b5GG2McbmGU?= =?us-ascii?Q?iuxktnTsxGW3tP5lX16KiP5M9CceSr/WUAegkpJK6XAxR/SH3toHC2cOlZ8H?= =?us-ascii?Q?wbe9zv0Xs2BBFcyjuG+Zz5m8v8rZpzqCDBA3iCWkozCPMbXsKKXQXa/csBAs?= =?us-ascii?Q?tbkGjGx/OVXOXP3gfkGyqp5UCBu38qhiwxOs1jpP6UbNAVY/jo4HYUC4VCzR?= =?us-ascii?Q?NGfwfel36LmPGrbw8sQ2DSIRgrDdzLbNGlBi0nxgTgQ5SqgJnOMR3s0XT1dK?= =?us-ascii?Q?yk7Zl+E9C6HFegnNWqDWndjqRkOBEbeBDKe+QqYqyAUGhw3VMzUnlAUQDqA?= =?us-ascii?Q?=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM5PR0201MB2305;6:xNiSD7Ym8wgp17fl++AjQluPIMntCQrBh6WyoPkERXJ7v6HeRZxFo6OXT7Bb3Oai5Z7zJpbmgHQRuEDodTp4yYtrwDkIiAIidgNe+W9ABXGLLtSWaK6TwGxZq4wqb6EFPq1yKxVe8bznszbOlE0vBrOtTQJn66qDQW+3slINtcvDDtZ6jdrymejx21+9kBrqHyxEvw5bjCMtgW/vrum4Bt6NBycxxkBRfeRsl+me0F8z75GvHfRNAlmi3s/UHGaE953trsAARuMG/juv1zXKQEbU10q+Wulh5KhvTkvZ2linYAxXp15V0Gez809XwIUSlcWYsZ5wHbGIZjpBCenQ0Sad/p/JO/wl74zazMp8LgRuvTULwGAY/me5XrclYy0eGReKnLt1mRIJGNuSU+wTkMbKF10DfT0sYvlOR8dSKBcUqYRrGvSac3dpYB4lmhVw;5:OOWG13cQVZcgHhbSJoNNAvipSZfZ4l+FaQvZekwotRgkrtj09OJebbCGyu9weRu2MHVRfs3z+mt8MzwJgwLWXZtBpoqrlry8tWzX6X+O+/eS+kyhuMCp7zTVuTz0cOWYfwCtJ7qC8rcfqf+G673aP/UprEnLTU+RID3S/VHBNAk=;24:k90laYoHZh5ZMs/pZb5YoS9gSJCbwpwtsfh10fpFWGwxHi+CiCUv+YpX7kJdoW7tTvcirVfr3OGLS5CXgxoPYUSlX20YZmeOpUwLWGEagA4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AM5PR0201MB2305;7:tVaFuWaI0WkUUaLEmB47uKHymGd2McFQI5sFwe5tdNlqNlfeIur0oozexo+eKc7vEN/7tH7olDmxmR+v2NSh/3KhrF2R2q0MG8uD3/I8hewcLgFxF9/gvSicXdZNiPkWhQ0se9AY+EaPoeHzdRt4PTIg68w6q2PFpXEM9/GH925CeoOCzOkDWXWHGkP2yOQgEdEAMethVkrsXVmRKvaVjtKQxERz5shrAKk5FejakIm5TN+mS/Mz+xrr5kZXKj5jVCr+zZ7ubbILS4t2SmuXWCq8hW6h+OWjiqkz1j4XoGwW3QPLr+CyBp9I3ucIe9vGDbNMSVSK9ymPEhZuw/gxA3e4+Ez4O4OfO3kYyUkkugAp15Oy+4SKqhGeDKikxuW9motQgJrqrPcTLjPqEB3s2Xrhn9XwcWeNZnO+x/QbFIbxu15JZFOiz4xbEUEo5YacW8fNQ3IjDkTo93Onq4wGCw== X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2016 23:57:03.8648 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0201MB2305 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Providing value bits outside of the mask is pointless. Signed-off-by: Peter Rosin --- drivers/power/supply/bq24735-charger.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/power/supply/bq24735-charger.c b/drivers/power/supply/bq24735-charger.c index eb7783b42e0a..1d5c9206e0ed 100644 --- a/drivers/power/supply/bq24735-charger.c +++ b/drivers/power/supply/bq24735-charger.c @@ -111,8 +111,7 @@ static inline int bq24735_enable_charging(struct bq24735 *charger) return 0; return bq24735_update_word(charger->client, BQ24735_CHG_OPT, - BQ24735_CHG_OPT_CHARGE_DISABLE, - ~BQ24735_CHG_OPT_CHARGE_DISABLE); + BQ24735_CHG_OPT_CHARGE_DISABLE, 0); } static inline int bq24735_disable_charging(struct bq24735 *charger) -- 2.1.4