All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Neukum <oneukum@suse.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCHv13 2/3] usb: USB Type-C connector class
Date: Thu, 15 Dec 2016 13:06:07 +0100	[thread overview]
Message-ID: <1481803567.4648.8.camel@suse.com> (raw)
In-Reply-To: <20161215115055.GB8312@kuha.fi.intel.com>

On Thu, 2016-12-15 at 13:50 +0200, Heikki Krogerus wrote:

> 1) Should we use "source" and "sink" instead of "device" and "host"
> with the prefer_role attribute after all? I was uncomfortable with
> that when we talked about it last time because the terms kept changing
> with every new Type-C specification version. But I guess "source" and
> "sink" would make sense in the end. This has been requested by several
> guys now.
> 
> 2) Can we change the way we list the supported roles? They are now
> comma separated, but can we use new line instead:
> 
>         % cat supported_data_roles
>         host
>         device
>         %
> 
> 3) Instead of the "supports_usb_power_delivery" attribute file which
> we have for the ports and partners, it seem it would be more
> interesting to know the supported USB Power Delivery Specification
> version for some, and also USB Type-C Specification version in
> separate attribute file. So basically we would have
> "usb_power_delivery_version" and "usb_typec_version" attributes
> instead or "supports_usb_power_delivery".
> 
> 
> So would these changes be OK still at this point to everybody?

Hi,

they are all right with me.

	Regards
		Oliver

  reply	other threads:[~2016-12-15 12:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-24 12:21 [PATCHv13 0/3] USB Type-C Connector class Heikki Krogerus
2016-11-24 12:21 ` [PATCHv13 1/3] lib/string: add sysfs_match_string helper Heikki Krogerus
2016-12-07 23:54   ` [PATCHv13,1/3] " Guenter Roeck
2016-12-08  7:29     ` Heikki Krogerus
2016-11-24 12:21 ` [PATCHv13 2/3] usb: USB Type-C connector class Heikki Krogerus
2016-11-29 16:27   ` Greg KH
2016-11-30  9:19     ` Heikki Krogerus
2016-12-02 18:04       ` Guenter Roeck
2016-12-02 18:22         ` Greg KH
2016-12-07  9:11         ` Heikki Krogerus
2016-12-07  9:46         ` Oliver Neukum
2016-12-07 12:52           ` Heikki Krogerus
2016-12-15 11:50             ` Heikki Krogerus
2016-12-15 12:06               ` Oliver Neukum [this message]
2016-12-15 15:01               ` Guenter Roeck
2016-12-19 14:45                 ` [RFC PATCH] " Heikki Krogerus
2016-12-19 17:22                   ` Guenter Roeck
2016-12-20 14:23                     ` Heikki Krogerus
2016-11-24 12:21 ` [PATCHv13 3/3] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1481803567.4648.8.camel@suse.com \
    --to=oneukum@suse.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.