All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Petr Mladek <pmladek@suse.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk: Remove no longer used second struct cont
Date: Thu, 15 Dec 2016 17:39:52 -0800	[thread overview]
Message-ID: <1481852392.29291.75.camel@perches.com> (raw)
In-Reply-To: <20161216013706.GA20445@jagdpanzerIV.localdomain>

On Fri, 2016-12-16 at 10:37 +0900, Sergey Senozhatsky wrote:
> On (12/15/16 17:23), Petr Mladek wrote:
> > On Thu 2016-12-15 13:53:58, Geert Uytterhoeven wrote:
> > > If CONFIG_PRINTK=n:
> > > 
> > >     kernel/printk/printk.c:1893: warning: ‘cont’ defined but not used
> > > 
> > > Note that there are actually two different struct cont definitions and
> > > objects: the first one is used if CONFIG_PRINTK=y, the second one became
> > > unused by removing console_cont_flush().
> > > 
> > > Fixes: 5c2992ee7fd8a29d ("printk: remove console flushing special cases for partial buffered lines")
> > 
> > Great catch. It seems that nobody tried the build without CONFIG_PRINTK
> > at that time.
> 
> ok... since the patch is a cosmetic tweak... can we add several more
> cosmetic changes to it? yes, I know, N things in one patch is "a bad thing",
> but those extra changes don't deserve to be in a separate patch.
> 
> basically I'm talking about a bunch of 80-cols fixups.
> if it's irrelevant then feel free to ignore it.

While it might be nice to do some 80 column wrapping,
the most common wrap style is to the open parenthesis.

I'd also like to split up printk.c into a bunch of
smaller, more logically self-contained files eventually.

  reply	other threads:[~2016-12-16  1:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-15 12:53 [PATCH] printk: Remove no longer used second struct cont Geert Uytterhoeven
2016-12-15 16:23 ` Petr Mladek
2016-12-16  1:37   ` Sergey Senozhatsky
2016-12-16  1:39     ` Joe Perches [this message]
2016-12-16  1:50       ` Sergey Senozhatsky
2016-12-16  1:50     ` Linus Torvalds
2016-12-16  1:57       ` Joe Perches
2016-12-16  2:10         ` Linus Torvalds
2016-12-16  2:30           ` Joe Perches
2016-12-16  5:00             ` Junio C Hamano
2016-12-16  6:04               ` Joe Perches
2016-12-16  6:04                 ` Joe Perches
2016-12-16  2:00       ` Sergey Senozhatsky
2016-12-18 19:29       ` Scott Matheina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1481852392.29291.75.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.