From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Stephen Bates To: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, axboe@fb.com Subject: [PATCH 2/2] nvme: improve cmb sysfs reporting Date: Fri, 16 Dec 2016 11:54:51 -0700 Message-Id: <1481914491-21456-3-git-send-email-sbates@raithlin.com> In-Reply-To: <1481914491-21456-1-git-send-email-sbates@raithlin.com> References: <1481914491-21456-1-git-send-email-sbates@raithlin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: james_p_freyensee@linux.intel.com, sagi@grimberg.me, jonathan.derrick@intel.com, Stephen Bates MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+axboe=kernel.dk@lists.infradead.org List-ID: Add more information to the NVMe CMB sysfs entry. This includes information about the CMB size, location and capabilities. Signed-off-by: Stephen Bates --- drivers/nvme/host/pci.c | 31 +++++++++++++++++++++++++++++-- include/linux/nvme.h | 8 ++++++++ 2 files changed, 37 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index be10860..1f70630 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -98,6 +98,7 @@ struct nvme_dev { void __iomem *cmb; dma_addr_t cmb_dma_addr; u64 cmb_size; + u64 cmb_offset; u32 cmbsz; u32 cmbloc; struct nvme_ctrl ctrl; @@ -1326,14 +1327,39 @@ static int nvme_create_io_queues(struct nvme_dev *dev) return ret >= 0 ? 0 : ret; } +static const char * const cmb_caps[] = { + [NVME_CMB_CAP_SQS] = "SQS", + [NVME_CMB_CAP_CQS] = "CQS", + [NVME_CMB_CAP_LISTS] = "LISTS", + [NVME_CMB_CAP_RDS] = "RDS", + [NVME_CMB_CAP_WDS] = "WDS", +}; + static ssize_t nvme_cmb_show(struct device *dev, struct device_attribute *attr, char *buf) { struct nvme_dev *ndev = to_nvme_dev(dev_get_drvdata(dev)); + unsigned int i, len = 0; + + len += scnprintf(buf+len, PAGE_SIZE-len, + "cmbloc : 0x%08x\ncmbsz : 0x%08x\n\n", + ndev->cmbloc, ndev->cmbsz); + + len += scnprintf(buf+len, PAGE_SIZE-len, + "OFFSET : 0x%016llx\nSIZE : %llu Bytes\n" \ + "DMA ADDR : %pad\n\n", + ndev->cmb_offset, ndev->cmb_size, + &ndev->cmb_dma_addr); + + for (i = NVME_CMB_CAP_SQS; i <= NVME_CMB_CAP_WDS; i++) + len += scnprintf(buf+len, PAGE_SIZE-len, "%-7s: %s\n", + cmb_caps[i], + ((ndev->cmbsz) & (1<cmbloc, ndev->cmbsz); } static DEVICE_ATTR(cmb, S_IRUGO, nvme_cmb_show, NULL); @@ -1376,6 +1402,7 @@ static void __iomem *nvme_map_cmb(struct nvme_dev *dev) dev->cmb_dma_addr = dma_addr; dev->cmb_size = size; + dev->cmb_offset = offset; return cmb; } diff --git a/include/linux/nvme.h b/include/linux/nvme.h index fc3c242..cd0d324 100644 --- a/include/linux/nvme.h +++ b/include/linux/nvme.h @@ -121,6 +121,14 @@ enum { #define NVME_CMB_CQS(cmbsz) ((cmbsz) & 0x2) #define NVME_CMB_SQS(cmbsz) ((cmbsz) & 0x1) +enum { + NVME_CMB_CAP_SQS = 0, + NVME_CMB_CAP_CQS, + NVME_CMB_CAP_LISTS, + NVME_CMB_CAP_RDS, + NVME_CMB_CAP_WDS, +}; + /* * Submission and Completion Queue Entry Sizes for the NVM command set. * (In bytes and specified as a power of two (2^n)). -- 2.1.4 _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758847AbcLPTTw (ORCPT ); Fri, 16 Dec 2016 14:19:52 -0500 Received: from gateway24.websitewelcome.com ([192.185.51.228]:34485 "EHLO gateway24.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758819AbcLPTTl (ORCPT ); Fri, 16 Dec 2016 14:19:41 -0500 X-Greylist: delayed 1470 seconds by postgrey-1.27 at vger.kernel.org; Fri, 16 Dec 2016 14:19:41 EST From: Stephen Bates To: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, axboe@fb.com Cc: sagi@grimberg.me, james_p_freyensee@linux.intel.com, jonathan.derrick@intel.com, Stephen Bates Subject: [PATCH 2/2] nvme: improve cmb sysfs reporting Date: Fri, 16 Dec 2016 11:54:51 -0700 Message-Id: <1481914491-21456-3-git-send-email-sbates@raithlin.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1481914491-21456-1-git-send-email-sbates@raithlin.com> References: <1481914491-21456-1-git-send-email-sbates@raithlin.com> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - estate.websitewelcome.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - raithlin.com X-BWhitelist: no X-Source-IP: 207.54.116.65 X-Exim-ID: 1cHxej-000MJb-H1 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: lambic.deltatee.com (cgy1-donard.priv.deltatee.com) [207.54.116.65]:53010 X-Source-Auth: sbates@raithlin.com X-Email-Count: 21 X-Source-Cap: cmFpdGhsaW47c2NvdHQ7ZXN0YXRlLndlYnNpdGV3ZWxjb21lLmNvbQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add more information to the NVMe CMB sysfs entry. This includes information about the CMB size, location and capabilities. Signed-off-by: Stephen Bates --- drivers/nvme/host/pci.c | 31 +++++++++++++++++++++++++++++-- include/linux/nvme.h | 8 ++++++++ 2 files changed, 37 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index be10860..1f70630 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -98,6 +98,7 @@ struct nvme_dev { void __iomem *cmb; dma_addr_t cmb_dma_addr; u64 cmb_size; + u64 cmb_offset; u32 cmbsz; u32 cmbloc; struct nvme_ctrl ctrl; @@ -1326,14 +1327,39 @@ static int nvme_create_io_queues(struct nvme_dev *dev) return ret >= 0 ? 0 : ret; } +static const char * const cmb_caps[] = { + [NVME_CMB_CAP_SQS] = "SQS", + [NVME_CMB_CAP_CQS] = "CQS", + [NVME_CMB_CAP_LISTS] = "LISTS", + [NVME_CMB_CAP_RDS] = "RDS", + [NVME_CMB_CAP_WDS] = "WDS", +}; + static ssize_t nvme_cmb_show(struct device *dev, struct device_attribute *attr, char *buf) { struct nvme_dev *ndev = to_nvme_dev(dev_get_drvdata(dev)); + unsigned int i, len = 0; + + len += scnprintf(buf+len, PAGE_SIZE-len, + "cmbloc : 0x%08x\ncmbsz : 0x%08x\n\n", + ndev->cmbloc, ndev->cmbsz); + + len += scnprintf(buf+len, PAGE_SIZE-len, + "OFFSET : 0x%016llx\nSIZE : %llu Bytes\n" \ + "DMA ADDR : %pad\n\n", + ndev->cmb_offset, ndev->cmb_size, + &ndev->cmb_dma_addr); + + for (i = NVME_CMB_CAP_SQS; i <= NVME_CMB_CAP_WDS; i++) + len += scnprintf(buf+len, PAGE_SIZE-len, "%-7s: %s\n", + cmb_caps[i], + ((ndev->cmbsz) & (1<cmbloc, ndev->cmbsz); } static DEVICE_ATTR(cmb, S_IRUGO, nvme_cmb_show, NULL); @@ -1376,6 +1402,7 @@ static void __iomem *nvme_map_cmb(struct nvme_dev *dev) dev->cmb_dma_addr = dma_addr; dev->cmb_size = size; + dev->cmb_offset = offset; return cmb; } diff --git a/include/linux/nvme.h b/include/linux/nvme.h index fc3c242..cd0d324 100644 --- a/include/linux/nvme.h +++ b/include/linux/nvme.h @@ -121,6 +121,14 @@ enum { #define NVME_CMB_CQS(cmbsz) ((cmbsz) & 0x2) #define NVME_CMB_SQS(cmbsz) ((cmbsz) & 0x1) +enum { + NVME_CMB_CAP_SQS = 0, + NVME_CMB_CAP_CQS, + NVME_CMB_CAP_LISTS, + NVME_CMB_CAP_RDS, + NVME_CMB_CAP_WDS, +}; + /* * Submission and Completion Queue Entry Sizes for the NVM command set. * (In bytes and specified as a power of two (2^n)). -- 2.1.4 From mboxrd@z Thu Jan 1 00:00:00 1970 From: sbates@raithlin.com (Stephen Bates) Date: Fri, 16 Dec 2016 11:54:51 -0700 Subject: [PATCH 2/2] nvme: improve cmb sysfs reporting In-Reply-To: <1481914491-21456-1-git-send-email-sbates@raithlin.com> References: <1481914491-21456-1-git-send-email-sbates@raithlin.com> Message-ID: <1481914491-21456-3-git-send-email-sbates@raithlin.com> Add more information to the NVMe CMB sysfs entry. This includes information about the CMB size, location and capabilities. Signed-off-by: Stephen Bates --- drivers/nvme/host/pci.c | 31 +++++++++++++++++++++++++++++-- include/linux/nvme.h | 8 ++++++++ 2 files changed, 37 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index be10860..1f70630 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -98,6 +98,7 @@ struct nvme_dev { void __iomem *cmb; dma_addr_t cmb_dma_addr; u64 cmb_size; + u64 cmb_offset; u32 cmbsz; u32 cmbloc; struct nvme_ctrl ctrl; @@ -1326,14 +1327,39 @@ static int nvme_create_io_queues(struct nvme_dev *dev) return ret >= 0 ? 0 : ret; } +static const char * const cmb_caps[] = { + [NVME_CMB_CAP_SQS] = "SQS", + [NVME_CMB_CAP_CQS] = "CQS", + [NVME_CMB_CAP_LISTS] = "LISTS", + [NVME_CMB_CAP_RDS] = "RDS", + [NVME_CMB_CAP_WDS] = "WDS", +}; + static ssize_t nvme_cmb_show(struct device *dev, struct device_attribute *attr, char *buf) { struct nvme_dev *ndev = to_nvme_dev(dev_get_drvdata(dev)); + unsigned int i, len = 0; + + len += scnprintf(buf+len, PAGE_SIZE-len, + "cmbloc : 0x%08x\ncmbsz : 0x%08x\n\n", + ndev->cmbloc, ndev->cmbsz); + + len += scnprintf(buf+len, PAGE_SIZE-len, + "OFFSET : 0x%016llx\nSIZE : %llu Bytes\n" \ + "DMA ADDR : %pad\n\n", + ndev->cmb_offset, ndev->cmb_size, + &ndev->cmb_dma_addr); + + for (i = NVME_CMB_CAP_SQS; i <= NVME_CMB_CAP_WDS; i++) + len += scnprintf(buf+len, PAGE_SIZE-len, "%-7s: %s\n", + cmb_caps[i], + ((ndev->cmbsz) & (1<cmbloc, ndev->cmbsz); } static DEVICE_ATTR(cmb, S_IRUGO, nvme_cmb_show, NULL); @@ -1376,6 +1402,7 @@ static void __iomem *nvme_map_cmb(struct nvme_dev *dev) dev->cmb_dma_addr = dma_addr; dev->cmb_size = size; + dev->cmb_offset = offset; return cmb; } diff --git a/include/linux/nvme.h b/include/linux/nvme.h index fc3c242..cd0d324 100644 --- a/include/linux/nvme.h +++ b/include/linux/nvme.h @@ -121,6 +121,14 @@ enum { #define NVME_CMB_CQS(cmbsz) ((cmbsz) & 0x2) #define NVME_CMB_SQS(cmbsz) ((cmbsz) & 0x1) +enum { + NVME_CMB_CAP_SQS = 0, + NVME_CMB_CAP_CQS, + NVME_CMB_CAP_LISTS, + NVME_CMB_CAP_RDS, + NVME_CMB_CAP_WDS, +}; + /* * Submission and Completion Queue Entry Sizes for the NVM command set. * (In bytes and specified as a power of two (2^n)). -- 2.1.4