All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "hch@infradead.org" <hch@infradead.org>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"himanshu.madhani@cavium.com" <himanshu.madhani@cavium.com>,
	"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
	"nab@linux-iscsi.org" <nab@linux-iscsi.org>,
	"giridhar.malavali@cavium.com" <giridhar.malavali@cavium.com>
Subject: Re: [PATCH 1/9] qla2xxx: Move cmd search out of qla during ABTS
Date: Mon, 19 Dec 2016 16:29:57 +0000	[thread overview]
Message-ID: <1482164975.25336.8.camel@sandisk.com> (raw)
In-Reply-To: <20161219155939.GA3002@infradead.org>

On Mon, 2016-12-19 at 07:59 -0800, hch@infradead.org wrote:
> On Mon, Dec 19, 2016 at 03:33:27PM +0000, Bart Van Assche wrote:
> > Please consider removing the sess_cmd_list loop. Any lookups in
> > sess_cmd_list should be performed by the target core and not by a
> > target driver. Are you aware that core_tmr_abort_task() performs a very
> > similar lookup to the one above?
> 
> This was my first reaction as well, but it seems like qla2xxx hardware
> doesn't pass up the LUN for an abort request.  If that's really the
> case (which seems really odd to me) we'll need this loop.  If there is a
> way to get the lun out of the hardware it would be preferable to make
> use of that passed up lun.

Hello Christoph,

The SCSI Architecture Manual (SAM-6) specifies that the SCSI transport
protocol defines whether the scope of the ABORT TASK task management
function is I_T_L or I_T. In the Fibre Channel Protocol for SCSI (FCP)
document I read that for FC ABORT TASK corresponds to the ABTS-LS
frame. As far as I know no LUN information is present in the FC ABTS
frame. I think this means that target_submit_tmr() should be modified
such that it supports "LUN not specified".

Bart.

  reply	other threads:[~2016-12-19 16:29 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-18  9:02 [PATCH 0/9] qla2xxx: Cleanup for target code Himanshu Madhani
2016-12-18  9:02 ` [PATCH 1/9] qla2xxx: Move cmd search out of qla during ABTS Himanshu Madhani
2016-12-19 15:33   ` Bart Van Assche
2016-12-19 15:59     ` hch
2016-12-19 16:29       ` Bart Van Assche [this message]
2016-12-20 14:16         ` hch
2016-12-18  9:02 ` [PATCH 2/9] qla2xxx: Cleanup TMF code translation from qla_target Himanshu Madhani
2016-12-18  9:54   ` Christoph Hellwig
2016-12-18  9:02 ` [PATCH 3/9] qla2xxx: Move percpu_ida_{alloc|free} to tcm_qla2xxx Himanshu Madhani
2016-12-18  9:49   ` Christoph Hellwig
2016-12-18  9:02 ` [PATCH 4/9] qla2xxx: Cleanup for sess_kref handling Himanshu Madhani
2016-12-18  9:49   ` Christoph Hellwig
2016-12-18  9:02 ` [PATCH 5/9] qla2xxx: Move Command residual check from qla2xxx to tcm_qla2xxx Himanshu Madhani
2016-12-18  9:51   ` Christoph Hellwig
2016-12-18  9:02 ` [PATCH 6/9] qla2xxx: Remove direct access of scsi_status field in se_cmd Himanshu Madhani
2016-12-18  9:55   ` Christoph Hellwig
2016-12-18  9:02 ` [PATCH 7/9] qla2xxx: Remove direct access to t_task_cdb/t_task_lba field Himanshu Madhani
2016-12-18  9:51   ` Christoph Hellwig
2016-12-18  9:02 ` [PATCH 8/9] qla2xxx: Add T10-DIF opcode/type in qla_tgt_cmd Himanshu Madhani
2016-12-18  9:52   ` Christoph Hellwig
2016-12-18  9:02 ` [PATCH 9/9] qla2xxx: Remove se_cmd struct out of qla_tgt_cmd/qla_tgt_mgmt_cmd Himanshu Madhani
2016-12-18  9:53   ` Christoph Hellwig
2016-12-18  9:48 ` [PATCH 0/9] qla2xxx: Cleanup for target code Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1482164975.25336.8.camel@sandisk.com \
    --to=bart.vanassche@sandisk.com \
    --cc=giridhar.malavali@cavium.com \
    --cc=hch@infradead.org \
    --cc=himanshu.madhani@cavium.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.