[PATCH 0/2] mtd: spi-nor: add some new chip ids

[PATCH 0/2] mtd: spi-nor: add some new chip ids

[John Crispin]

These have been lingering inside the owrt/lede tree for a while.

André Valentin (1):
  mtd: spi-nor: add support for mx25u3235f

Ash Benz (1):
  mtd: spi-nor: add support for macronix mx25u25635f

 drivers/mtd/spi-nor/spi-nor.c |    2 ++
 1 file changed, 2 insertions(+)

-- 
1.7.10.4

[PATCH 1/2] mtd: spi-nor: add support for macronix mx25u25635f

[John Crispin]

From: Ash Benz <ash.benz@bk.ru>

Signed-off-by: John Crispin <john@phrozen.org>
Signed-off-by: Ash Benz <ash.benz@bk.ru>
---
 drivers/mtd/spi-nor/spi-nor.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index d0fc165..171adb3 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -872,6 +872,7 @@ static int spi_nor_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len)
 	{ "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
 	{ "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },
 	{ "mx25l25635e", INFO(0xc22019, 0, 64 * 1024, 512, 0) },
+	{ "mx25u25635f", INFO(0xc22539, 0, 64 * 1024, 512, 0) },
 	{ "mx25l25655e", INFO(0xc22619, 0, 64 * 1024, 512, 0) },
 	{ "mx66l51235l", INFO(0xc2201a, 0, 64 * 1024, 1024, SPI_NOR_QUAD_READ) },
 	{ "mx66l1g55g",  INFO(0xc2261b, 0, 64 * 1024, 2048, SPI_NOR_QUAD_READ) },
-- 
1.7.10.4

[PATCH 2/2] mtd: spi-nor: add support for mx25u3235f

[John Crispin]

From: André Valentin <avalentin@marcant.net>

Signed-off-by: John Crispin <john@phrozen.org>
Signed-off-by: André Valentin <avalentin@marcant.net>
---
 drivers/mtd/spi-nor/spi-nor.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index 171adb3..f9a41dc 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -868,6 +868,7 @@ static int spi_nor_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len)
 	{ "mx25l3205d",  INFO(0xc22016, 0, 64 * 1024,  64, SECT_4K) },
 	{ "mx25l3255e",  INFO(0xc29e16, 0, 64 * 1024,  64, SECT_4K) },
 	{ "mx25l6405d",  INFO(0xc22017, 0, 64 * 1024, 128, SECT_4K) },
+	{ "mx25u3235f",	 INFO(0xc22536, 0, 64 * 1024, 64, 0) },
 	{ "mx25u6435f",  INFO(0xc22537, 0, 64 * 1024, 128, SECT_4K) },
 	{ "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
 	{ "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },
-- 
1.7.10.4

Re: [PATCH 1/2] mtd: spi-nor: add support for macronix mx25u25635f

[Marek Vasut]

On 12/20/2016 08:25 PM, John Crispin wrote:
> From: Ash Benz <ash.benz@bk.ru>

Looks fine, but please do add a meaningful commit message.

> Signed-off-by: John Crispin <john@phrozen.org>
> Signed-off-by: Ash Benz <ash.benz@bk.ru>
> ---
>  drivers/mtd/spi-nor/spi-nor.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index d0fc165..171adb3 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -872,6 +872,7 @@ static int spi_nor_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len)
>  	{ "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
>  	{ "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },
>  	{ "mx25l25635e", INFO(0xc22019, 0, 64 * 1024, 512, 0) },
> +	{ "mx25u25635f", INFO(0xc22539, 0, 64 * 1024, 512, 0) },
>  	{ "mx25l25655e", INFO(0xc22619, 0, 64 * 1024, 512, 0) },
>  	{ "mx66l51235l", INFO(0xc2201a, 0, 64 * 1024, 1024, SPI_NOR_QUAD_READ) },
>  	{ "mx66l1g55g",  INFO(0xc2261b, 0, 64 * 1024, 2048, SPI_NOR_QUAD_READ) },
> 


-- 
Best regards,
Marek Vasut

Re: [PATCH 2/2] mtd: spi-nor: add support for mx25u3235f

[Marek Vasut]

On 12/20/2016 08:25 PM, John Crispin wrote:
> From: André Valentin <avalentin@marcant.net>
> 
> Signed-off-by: John Crispin <john@phrozen.org>
> Signed-off-by: André Valentin <avalentin@marcant.net>
> ---
>  drivers/mtd/spi-nor/spi-nor.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 171adb3..f9a41dc 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -868,6 +868,7 @@ static int spi_nor_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len)
>  	{ "mx25l3205d",  INFO(0xc22016, 0, 64 * 1024,  64, SECT_4K) },
>  	{ "mx25l3255e",  INFO(0xc29e16, 0, 64 * 1024,  64, SECT_4K) },
>  	{ "mx25l6405d",  INFO(0xc22017, 0, 64 * 1024, 128, SECT_4K) },
> +	{ "mx25u3235f",	 INFO(0xc22536, 0, 64 * 1024, 64, 0) },

No SECT_4K support here ?

>  	{ "mx25u6435f",  INFO(0xc22537, 0, 64 * 1024, 128, SECT_4K) },
>  	{ "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
>  	{ "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },
> 


-- 
Best regards,
Marek Vasut

[PATCH 2/2] mtd: spi-nor: Add support for mx25u3235f

[Tudor.Ambarus at microchip.com]

Hi, Hauke,

On 01/17/2019 12:38 AM, Hauke Mehrtens wrote:
> On 1/11/19 9:54 AM, Tudor.Ambarus at microchip.com wrote:
>> Hi, Hauke,
>>
>> On 12/09/2018 07:03 PM, Hauke Mehrtens wrote:
>>> From: Andr? Valentin <avalentin@marcant.net>
>>>
>>> This flash chip was found on the ZyXEL NBG6817
>>>
>>> The datasheet can be found here:
>>> http://www.macronix.com/Lists/Datasheet/Attachments/7438/MX25U3235F,%201.8V,%2032Mb,%20v1.6.pdf
>>
>> Did you test the flash to see if it works correctly? You should specify this in
>> the commit message.
> 
> Sorry I do not have a device with this flash chip, this patch was
> shipped in OpenWrt for a long time and I wanted to reduce the number of
> patches we carry in OpenWrt.
> 
> Andr? can you please confirm that this works for you on your device.
> 
>>>
>>> Signed-off-by: Andr? Valentin <avalentin@marcant.net>
>>
>> You should add your Signed-off-by tag as you are sending a patch that is not
>> from you.
> 
> No Problem I can add this.
> 
>>> ---
>>>  drivers/mtd/spi-nor/spi-nor.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
>>> index a21b1a26130d..9925760339ba 100644
>>> --- a/drivers/mtd/spi-nor/spi-nor.c
>>> +++ b/drivers/mtd/spi-nor/spi-nor.c
>>> @@ -1375,6 +1375,7 @@ static const struct flash_info spi_nor_ids[] = {
>>>  	{ "mx25l3205d",  INFO(0xc22016, 0, 64 * 1024,  64, SECT_4K) },
>>>  	{ "mx25l3255e",  INFO(0xc29e16, 0, 64 * 1024,  64, SECT_4K) },
>>>  	{ "mx25l6405d",  INFO(0xc22017, 0, 64 * 1024, 128, SECT_4K) },
>>> +	{ "mx25u3235f",	 INFO(0xc22536, 0, 64 * 1024,  64, SECT_4K) },
>>>  	{ "mx25u2033e",  INFO(0xc22532, 0, 64 * 1024,   4, SECT_4K) },
>>
>> It's nicer to order this alphabetically, the entry should be added here.
> 
> Ok will change this.
> 
>>
>> The flash supports Fast Read 1-1-2 (3Bh) and Fast Read 1-1-4 (6Bh) hence both
>> SPI_NOR_DUAL_READ and SPI_NOR_QUAD_READ flags should be set too. Can you please
>> test with these flags and if all ok, submit a new patch?
> 
> I do not know if the controller in the ZyXEL NBG6817 and the board is
> capable of dual and quad reads.

You can add SPI_NOR_DUAL_READ and SPI_NOR_QUAD_READ flags and we'll wait for
Andre's or Ding's Tested-by tag.

Thanks,
ta

[PATCH 2/2] mtd: spi-nor: Add support for mx25u3235f

[Hauke Mehrtens]

On 1/11/19 9:54 AM, Tudor.Ambarus at microchip.com wrote:
> Hi, Hauke,
> 
> On 12/09/2018 07:03 PM, Hauke Mehrtens wrote:
>> From: Andr? Valentin <avalentin@marcant.net>
>>
>> This flash chip was found on the ZyXEL NBG6817
>>
>> The datasheet can be found here:
>> http://www.macronix.com/Lists/Datasheet/Attachments/7438/MX25U3235F,%201.8V,%2032Mb,%20v1.6.pdf
> 
> Did you test the flash to see if it works correctly? You should specify this in
> the commit message.

Sorry I do not have a device with this flash chip, this patch was
shipped in OpenWrt for a long time and I wanted to reduce the number of
patches we carry in OpenWrt.

Andr? can you please confirm that this works for you on your device.

>>
>> Signed-off-by: Andr? Valentin <avalentin@marcant.net>
> 
> You should add your Signed-off-by tag as you are sending a patch that is not
> from you.

No Problem I can add this.

>> ---
>>  drivers/mtd/spi-nor/spi-nor.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
>> index a21b1a26130d..9925760339ba 100644
>> --- a/drivers/mtd/spi-nor/spi-nor.c
>> +++ b/drivers/mtd/spi-nor/spi-nor.c
>> @@ -1375,6 +1375,7 @@ static const struct flash_info spi_nor_ids[] = {
>>  	{ "mx25l3205d",  INFO(0xc22016, 0, 64 * 1024,  64, SECT_4K) },
>>  	{ "mx25l3255e",  INFO(0xc29e16, 0, 64 * 1024,  64, SECT_4K) },
>>  	{ "mx25l6405d",  INFO(0xc22017, 0, 64 * 1024, 128, SECT_4K) },
>> +	{ "mx25u3235f",	 INFO(0xc22536, 0, 64 * 1024,  64, SECT_4K) },
>>  	{ "mx25u2033e",  INFO(0xc22532, 0, 64 * 1024,   4, SECT_4K) },
> 
> It's nicer to order this alphabetically, the entry should be added here.

Ok will change this.

> 
> The flash supports Fast Read 1-1-2 (3Bh) and Fast Read 1-1-4 (6Bh) hence both
> SPI_NOR_DUAL_READ and SPI_NOR_QUAD_READ flags should be set too. Can you please
> test with these flags and if all ok, submit a new patch?

I do not know if the controller in the ZyXEL NBG6817 and the board is
capable of dual and quad reads.

Hauke

Re: [PATCH 2/2] mtd: spi-nor: Add support for mx25u3235f

[Tudor.Ambarus]

Hi, Hauke,

On 12/09/2018 07:03 PM, Hauke Mehrtens wrote:
> From: André Valentin <avalentin@marcant.net>
> 
> This flash chip was found on the ZyXEL NBG6817
> 
> The datasheet can be found here:
> http://www.macronix.com/Lists/Datasheet/Attachments/7438/MX25U3235F,%201.8V,%2032Mb,%20v1.6.pdf

Did you test the flash to see if it works correctly? You should specify this in
the commit message.
> 
> Signed-off-by: André Valentin <avalentin@marcant.net>

You should add your Signed-off-by tag as you are sending a patch that is not
from you.

> ---
>  drivers/mtd/spi-nor/spi-nor.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index a21b1a26130d..9925760339ba 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1375,6 +1375,7 @@ static const struct flash_info spi_nor_ids[] = {
>  	{ "mx25l3205d",  INFO(0xc22016, 0, 64 * 1024,  64, SECT_4K) },
>  	{ "mx25l3255e",  INFO(0xc29e16, 0, 64 * 1024,  64, SECT_4K) },
>  	{ "mx25l6405d",  INFO(0xc22017, 0, 64 * 1024, 128, SECT_4K) },
> +	{ "mx25u3235f",	 INFO(0xc22536, 0, 64 * 1024,  64, SECT_4K) },
>  	{ "mx25u2033e",  INFO(0xc22532, 0, 64 * 1024,   4, SECT_4K) },

It's nicer to order this alphabetically, the entry should be added here.

The flash supports Fast Read 1-1-2 (3Bh) and Fast Read 1-1-4 (6Bh) hence both
SPI_NOR_DUAL_READ and SPI_NOR_QUAD_READ flags should be set too. Can you please
test with these flags and if all ok, submit a new patch?

Cheers,
ta

>  	{ "mx25u4035",   INFO(0xc22533, 0, 64 * 1024,   8, SECT_4K) },
>  	{ "mx25u8035",   INFO(0xc22534, 0, 64 * 1024,  16, SECT_4K) },
> 

[PATCH 2/2] mtd: spi-nor: Add support for mx25u3235f

[Hauke Mehrtens]

From: André Valentin <avalentin@marcant.net>

This flash chip was found on the ZyXEL NBG6817

The datasheet can be found here:
http://www.macronix.com/Lists/Datasheet/Attachments/7438/MX25U3235F,%201.8V,%2032Mb,%20v1.6.pdf

Signed-off-by: André Valentin <avalentin@marcant.net>
---
 drivers/mtd/spi-nor/spi-nor.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index a21b1a26130d..9925760339ba 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -1375,6 +1375,7 @@ static const struct flash_info spi_nor_ids[] = {
 	{ "mx25l3205d",  INFO(0xc22016, 0, 64 * 1024,  64, SECT_4K) },
 	{ "mx25l3255e",  INFO(0xc29e16, 0, 64 * 1024,  64, SECT_4K) },
 	{ "mx25l6405d",  INFO(0xc22017, 0, 64 * 1024, 128, SECT_4K) },
+	{ "mx25u3235f",	 INFO(0xc22536, 0, 64 * 1024,  64, SECT_4K) },
 	{ "mx25u2033e",  INFO(0xc22532, 0, 64 * 1024,   4, SECT_4K) },
 	{ "mx25u4035",   INFO(0xc22533, 0, 64 * 1024,   8, SECT_4K) },
 	{ "mx25u8035",   INFO(0xc22534, 0, 64 * 1024,  16, SECT_4K) },
-- 
2.11.0