All of lore.kernel.org
 help / color / mirror / Atom feed
From: Himanshu Madhani <himanshu.madhani@cavium.com>
To: target-devel@vger.kernel.org, bart.vanassche@gmail.com,
	hch@infradead.org, nab@linux-iscsi.org
Cc: giridhar.malavali@cavium.com, linux-scsi@vger.kernel.org,
	himanshu.madhani@cavium.com
Subject: [PATCH v2 09/10] qla2xxx: Fix invalid handle erroneous message.
Date: Wed, 21 Dec 2016 13:57:38 -0800	[thread overview]
Message-ID: <1482357459-31079-10-git-send-email-himanshu.madhani@cavium.com> (raw)
In-Reply-To: <1482357459-31079-1-git-send-email-himanshu.madhani@cavium.com>

From: Quinn Tran <quinn.tran@cavium.com>

Termination of Immediate Notify IOCB was using wrong
IOCB handle. IOCB completion code was unable to find
appropriate code path due to wrong handle.

Following message is seen in the logs.

"Error entry - invalid handle/queue (ffff)."

Signed-off-by: Quinn Tran <quinn.tran@cavium.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
---
 drivers/scsi/qla2xxx/qla_isr.c    | 4 ++++
 drivers/scsi/qla2xxx/qla_target.c | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index af840bf..eefcf2f 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -2495,6 +2495,10 @@ struct scsi_dif_tuple {
 	if (pkt->entry_status & RF_BUSY)
 		res = DID_BUS_BUSY << 16;
 
+	if (pkt->entry_type == NOTIFY_ACK_TYPE &&
+	    pkt->handle == QLA_TGT_SKIP_HANDLE)
+		return;
+
 	sp = qla2x00_get_sp_from_handle(vha, func, req, pkt);
 	if (sp) {
 		sp->done(ha, sp, res);
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index 9252694..c02f31a 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -3061,7 +3061,7 @@ static int __qlt_send_term_imm_notif(struct scsi_qla_host *vha,
 
 	pkt->entry_type = NOTIFY_ACK_TYPE;
 	pkt->entry_count = 1;
-	pkt->handle = QLA_TGT_SKIP_HANDLE | CTIO_COMPLETION_HANDLE_MARK;
+	pkt->handle = QLA_TGT_SKIP_HANDLE;
 
 	nack = (struct nack_to_isp *)pkt;
 	nack->ox_id = ntfy->ox_id;
-- 
1.8.3.1

  parent reply	other threads:[~2016-12-21 21:57 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-21 21:57 [PATCH v2 00/10] qla2xxx: Bug fixes for driver Himanshu Madhani
2016-12-21 21:57 ` [PATCH v2 01/10] qla2xxx: Fix wrong IOCB type assumption Himanshu Madhani
2016-12-21 21:57 ` [PATCH v2 02/10] qla2xxx: Include ATIO queue in firmware dump when in target mode Himanshu Madhani
2016-12-23  8:32   ` Bart Van Assche
2016-12-24  0:37     ` Madhani, Himanshu
2016-12-21 21:57 ` [PATCH v2 03/10] qla2xxx: Set tcm_qla2xxx version to automatically track qla2xxx version Himanshu Madhani
2016-12-21 21:57 ` [PATCH v2 04/10] qla2xxx: Reset reserved field in firmware options to 0 Himanshu Madhani
2016-12-23  8:37   ` Bart Van Assche
2016-12-24  0:07     ` Madhani, Himanshu
2016-12-21 21:57 ` [PATCH v2 05/10] qla2xxx: Collect additional information to debug fw dump Himanshu Madhani
2016-12-21 21:57 ` [PATCH v2 06/10] qla2xxx: Fix crash due to null pointer access Himanshu Madhani
2016-12-23  8:47   ` Bart Van Assche
2016-12-24  0:06     ` Madhani, Himanshu
2016-12-21 21:57 ` [PATCH v2 07/10] qla2xxx: Terminate exchange if corrputed Himanshu Madhani
2016-12-23  9:01   ` Bart Van Assche
2016-12-23 23:55     ` Madhani, Himanshu
2016-12-21 21:57 ` [PATCH v2 08/10] qla2xxx: Reduce exess wait during chip reset Himanshu Madhani
2016-12-21 21:57 ` Himanshu Madhani [this message]
2016-12-21 21:57 ` [PATCH v2 10/10] qla2xxx: Disable Out-of-order processing by default in Firmware Himanshu Madhani
2016-12-22  9:25 ` [PATCH v2 00/10] qla2xxx: Bug fixes for driver Christoph Hellwig
2016-12-22 16:44   ` Madhani, Himanshu
2016-12-22 17:02     ` Bart Van Assche
2016-12-22 17:27       ` Madhani, Himanshu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1482357459-31079-10-git-send-email-himanshu.madhani@cavium.com \
    --to=himanshu.madhani@cavium.com \
    --cc=bart.vanassche@gmail.com \
    --cc=giridhar.malavali@cavium.com \
    --cc=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.