From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030205AbcLWOLm (ORCPT ); Fri, 23 Dec 2016 09:11:42 -0500 Received: from mail-by2nam01on0075.outbound.protection.outlook.com ([104.47.34.75]:9087 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753523AbcLWOLk (ORCPT ); Fri, 23 Dec 2016 09:11:40 -0500 X-Greylist: delayed 1044 seconds by postgrey-1.27 at vger.kernel.org; Fri, 23 Dec 2016 09:11:40 EST Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; From: Suravee Suthikulpanit To: , CC: , , , , Suravee Suthikulpanit , Suravee Suthikulpanit Subject: [PATCH V6 4/7] perf/amd/iommu: Declare pr_fmt and remove unnecessary pr_debug Date: Fri, 23 Dec 2016 20:38:47 +0700 Message-ID: <1482500330-5606-5-git-send-email-Suravee.Suthikulpanit@amd.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1482500330-5606-1-git-send-email-Suravee.Suthikulpanit@amd.com> References: <1482500330-5606-1-git-send-email-Suravee.Suthikulpanit@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BN6PR1301CA0025.namprd13.prod.outlook.com (10.174.84.166) To DM5PR12MB1449.namprd12.prod.outlook.com (10.172.38.138) X-MS-Office365-Filtering-Correlation-Id: da55daf9-b826-4d41-901a-08d42b3927d8 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DM5PR12MB1449; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1449;3:gRerSsz3BzHrqcKUscS6iXkIt8qJRQ2Jqup0dxFOjbxQRgPUsvDtFlEQlbPiLo3hRW6POVE3/aegTAXETcANorj1LyxX5v7eoO5G0N0OHPKWES5vJK5V10SsBBJzI1PCBW3LJMR2fonteMQPgVr6XRbOCzDxtbzO0DWuOwEfCbNsfTGISIh8/rISbUxqmB6OUwyZPdREguDqoknrZ0cVRANdFVSQahMGwHbnMoa+7xXQPKpl8zeCWp5jtYuYqehnK5O6eLfX1iqwFikLebHjAA==;25:XuP6MRdU4aptGolZmF6lqGYy3lBvYh185ZeQFeLVddZnfrEbENNd6zkDNjAjgaEniVzGc/1BBkB8B9aPOD9PD+GRAiVNK3GaBBfP8YzFyQRmrSq41fqLXywx1YX48v2c12ckY7XVqgVEa6DMH/EqEiju61q0hDKxE4UfDJeQVjINyylFiQU+4Lh1snm/nE5e1PPM/5me0fET9JH/ytFoIEw6j3l8T1ws6zoTviJfsMaKQCtLh9viJdpJi0okwQF57m9hUpH37VFsOrsKACzNq7Y5KeNf2FIh43NpXDTQd4yxjYjG+OwZ9nro71c/WTksvwEbCKRgvfsTFnlReBFlfBdoqLo+a7Ksh8daBAFaPRfJpRvvQRK6sq+WEgWMB0VW9KW0KA32nZxuklMsljVhCgeudrpjMwW2Z5E3FsmcNu0/kmkqb4br9+46A1qxYHiCe/aaFQOHpW3dag0g8uhOdw== X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1449;31:HzUrQRBEes4zmuJq4UI9VZXlWBXgCK5FFzUzUD+4Uwnzu1m2b+ZbkobIbhfuFY2r4JRNx4z4owIR927Nsv5Tj4rBt45ZKb/3rtLCxfogxlmpIRiHemLTmBasNxrRz230fKp/toqpc47CRcWTWa6sFAuRi6fZlg+PXJwH8EpbhBl9yV+W3R2sAGc6zwtT1OElmR+ZGQxkFV5tO/xxFnP2fGvoOvISv04uZT25J1gEO8gIHyVzuh85eDsPSPU4mC3S;20:4zCj+1Py/mWpYj/Cdo4gpdOwCp4JNf+hS3F485DI85yFhW2WhnqmrHdvdQVPfn3jx3UcDElNTDE86ChhSXEVHYodHeku9fw+nZ83h1x3KulL30IvBwBA5JCHVBkNOQqLjrKIOng+V2ksQcvMfBHstqf3qMP4mlzfEU42kqBKXsOm5hPuSVPtIlT4iftHLKHBaR1q+vobORQNA69lNuYJr5qy30kOZERCM82Hyqj7NLDVr+H/8hctUXX5E528bu6+bvOe7mSYv3mBGejZYLp5Zu3TctcecvJ2NC5z6vfWk9aytlRSAD6tCdW5Z2mSg1u+PNnNg9L5dvmU4of4QRDyM1XDEMqVyrX0Mqmv6Quo9OoeQMWE8xPZJZgxzyWzhqEuhwhkOO50DXDTfV8AkeF/5o1VEAVVMZyG+vnLgma38wR4eANvHIyWvLsDKu04sVwbTFK3+APwhc1C6URXjCqI091SkqplWJzqY5c2M8bydUQrhWutzFbVmId9trYWHlgA X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123564025)(20161123562025)(20161123555025)(20161123558021)(20161123560025)(6072148);SRVR:DM5PR12MB1449;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1449; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1449;4:7ptlxCdwDznB7DX3JIIS8haHwItuGzkQqc2Ye5o4oKywLYkIW4/8DCEQx6ZpgLvi0Iz11b6hzw4YdZtYzT0/MAT9XxEQubfvbMToD11KoKcVz7qvWHTSLN5XgwI2rOMO+rabDOcdH5IFVYkkuHIlqsdxkSRSYS4q8Q+/dndfp7BJZjQyhpKKURwJkDGNi1pzhy5rI2lOuNnzmVk9r8hF6KSPvPjsjekISeBNpJ+8D8kqE+FKW/W1c9TLHnttnDh0nwVboIoAw/aGC3opCBgBkexrhBB1Z1Ai9A0Zzfynz3cArWcGOxyzsrzVkHpE+jkczMFNlppuD5O9fioJFOP5sb0m37lyYfSb/1ogQMFxHbeUGhPc8kl022WRMpv/aTERtMQAk8BZ5E9LGXmLPu5Gupwu1szPt9Y8VpzQGR2XjNBaO0tx+pftP9uTmyOaw0k1AdgzuqtTQiXqfd1n8kr/PKcdAvU+R6dA+QfPt0IsjeBFbjOW43Krx/9o6tfzoBpJ0AWNXioSFrD7qS+NbLwmKrafq6PgEBzSO0Zx5fBglnG0vHlFfa+1O0ysN1GJAKeg+ZhH4QeQRFoUTLC55MCeu1v4iEzEo1D5boHUI9pRe6e/S1Fz+0anu1yDv1BTfRC/z9+TY3BEEX36cc3gL2x+YU6Hf6wQ91xfBPKHs/4P9Ww= X-Forefront-PRVS: 016572D96D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(39840400002)(39410400002)(39850400002)(39860400002)(189002)(199003)(305945005)(86362001)(47776003)(7736002)(50226002)(81166006)(81156014)(5003940100001)(68736007)(8676002)(48376002)(106356001)(50466002)(3846002)(6116002)(4326007)(2906002)(50986999)(53416004)(92566002)(66066001)(42186005)(97736004)(105586002)(36756003)(5001770100001)(38730400001)(6666003)(76176999)(101416001)(5660300001)(189998001)(25786008)(2950100002)(6486002)(2004002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1449;H:ssuthiku-ubuntu-lt.amd.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM5PR12MB1449;23:MpusxSVRqUoit7c7se04PNv5fgjkjHQeO4YgDNaSV?= =?us-ascii?Q?rQWEKzuLX57g1WJd1HORYwc9Q7AvGmoaHr4fjibhktBe6a6H8cAxGpNWGg6w?= =?us-ascii?Q?dgvUN2oeyduXI7oYPKZWejqfenSlnRbpU0wNBPlZlCtLt/RU7Vp+XjlkiAeN?= =?us-ascii?Q?D/dgxzoi5Zi72gdKi54n65bau1yisc6BBb/xX2e72EfTS5N4GYFiyq55O5Xv?= =?us-ascii?Q?TXeDsydYw2JQSC4/atppfoDr6twz8ozkAX4gmMk8w67UZR4LBEkiOx5gJRQZ?= =?us-ascii?Q?LYKRq5POXuywSBmZ8PrtyZTOhbWbDb+BDT+CCLOueL8EK1uY8i7bW4UlmYRW?= =?us-ascii?Q?jyTKj0/MmQEY2n2nh63ZoSXxP/BukEIwEzqzDjEdHg+0jkHTiwVBa5OOH7Pn?= =?us-ascii?Q?CXtdTVix+Cl4xzIzXLK63iEVVAX1FGKKhzx63PAs1UWEih5SqF3Dpl96GagV?= =?us-ascii?Q?BTy27EjjGtCqikX2kQR17M2VwBKLGhrFeO1FK18VE4hGBytizD2+sAaRWdgV?= =?us-ascii?Q?GQJBlcm5HYMC/miSLoMKRu1s19eMKw6yi3Efq5+bgim73JWUmb1DaFht6ALe?= =?us-ascii?Q?q5tbzc4XI3cJSU6guAEib5mGESW90zHRJJ+AyZpBuhMu3Sp4+irde3HeAvSy?= =?us-ascii?Q?POvtBF5flYLiD0B+ZB1pT73oOj69uAV/l+hMqxwYr1SuGUpaTCq6fSTfRJxz?= =?us-ascii?Q?x8oH95WcZbLfnm0DLAAfEZ3FDokyPwwcV6wrjckqcw3nA6WvUQ2dQdZZYvLM?= =?us-ascii?Q?l3WZz3EvFUHhFhc+Ng//kPsDrrT6Kf6GtfMGJBse7T0okBjzLHkMm+gAB4Ab?= =?us-ascii?Q?hyhc2qaF2RRbOzbQES6Xm9+JFeVndY8iW0AqBgsCHA64peXGYvo0eOjKAYDd?= =?us-ascii?Q?qbWLgUmJaPCnEvRS0oeZ+UIkt1JzSUD7WG2en1utOCMNM0Prh7k0XOuDuIcx?= =?us-ascii?Q?ctgHSy8o/DosNyZgER0/BLi8b+AwRFL20iU/q6mcOvRayCND35ldY3sctwkH?= =?us-ascii?Q?NbXII1HGFNL49EZYFtZ6upDtvTIorqeWH8309diXLNpbRpCADNfV0ZqyyxYl?= =?us-ascii?Q?4QXQ3PxMBhqPFYpBw57GkuUJMZM5ULR1X3b92AqklSozfZBYesaO9yk8z5al?= =?us-ascii?Q?x8oWrVGfQxNyk1GA3ws4e7IE5pvgyhf288z+dSGPDVb6CRDonUUVg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1449;6:LHCJ+5qWGVCehv6CRlweU5Mgy65B7oCX/6bGkED85QrQ+1yB3rse1yL3BJXBQqShoHVvM30P1NCbOEyeypfQrqQxNPtm8cxt69g6ZGbT2uq+pAH2BxBgeX4MBcL3FzNJ+mjpyFwMVuT2XywQeW5at+C6vYZPOOgcSaH//1r+Qm336qpqiTxvAClPXdG8tnCgd2sAgs4up1opedJ6Frpw5SCeqb2CfBQpsH+wglZhU0zq1hrjzc3z+ns1aPOz1GsVoycXVvNm+wQ/wyaYcXnAuH5Ru3urZ7O8VnqxIkoxrY1TKzDCaiLtfAPx5Smu1OVfya1Gn1tGwx5AGnqGrodjr6wf/23g8ZgvZIyW/gc3UaUdk/++/foNkC/eHpuPCAbhpU330tZ50I/2zyv8M0KU9J/Uawmbe7DwMzDmC5IXYw07BUlLr4tji5QwfbsxoqwiozgIEmrY0JNYDbToi1kj/w==;5:JNCrZaN6TODaLdK7Hv4iRattbNbkc7Ll+gs4MFW24VUzhgUJnG/hku45CVU+tZ8b0TdHwhBtvcVP1wm9rPl5mH9BVnf0uJOMRX2sWRdMU7Yzo1avw7oAPdKDsKEOElheHRKY6afy+mbXBmBXJD0C5A==;24:Lt6hGlbH7sI4lnuyupddjX0iUUGntygEuA5ThuL9Hyj02/qpON/eYXSAkeo7RxkmtOWTkPedvdXIneRegOnGn1S/nubHGPjjfh/q3ofasaU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1449;7:OAQTdZHHqRoztqibO7+fyC/rvtv4IovOzOAC5OET35z1/AXyxUhklF3GPGQp7bF2a7w8Svjf4HrXeEwyQn3W1eRbf/RVc5j96D64Q4eqizSnY02na7OHO/JjTpLYwHC138SaHGemJsO2s2YFiPGkv9vtihXI6Q2wNEc67pfx4yGcNuYdlv2X0tgcvi+ZLQGVpZPmvWBluhjp17kHTiQL8svDeTr+akxq/e9Nnk63aDDYZNohc1WRAAhlwmh759zRwUpDi6nFfJIKnv+Jukfuit4hqmmAdVSwDZ5CltGjf+sApORj0MrjDEJSpmqo4i/C0C9gCOzL1JhqIf7/BP7lczln1et5yEMfFhZ5yfwyDjuAUBPgsc6Fe5qxihGsiEI1FQFIXMFB8wy/hCSIEYiSG3OIePPABxiB334Lfo0bBpYi3dUCDSs5GZdOhjr9f7o20jsS825gCaFHbYftC6ak7w==;20:9tvZe9iWYY9xkjZef0tiEy5NK/yYVvQyRDU2Yva0VQQvdeoJ3B2RDQbl9jHyfGl0m6uzZEKQxyY0fH+C7t4lTBBkGb+qN9gnFB5aiPmf9wq2gb5rN7CZgF0wzrGsribZKcJ21eh6S+KsorMtfkWRjYEpHlYdxpd5abuT3mzFY4phRKE3VKzoq52VSE79n5noElwrJf204hcYtwtGa5i2mGR7yd20m2UDTgBxTUFX2yKd+SJF+kRppUqNb/y8SEG5 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2016 13:39:36.0241 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1449 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch declare pr_fmt for perf/amd_iommu and remove unnecessary pr_debug. Cc: Peter Zijlstra Cc: Borislav Petkov Signed-off-by: Suravee Suthikulpanit --- arch/x86/events/amd/iommu.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/arch/x86/events/amd/iommu.c b/arch/x86/events/amd/iommu.c index 9744dc8..9bff41d 100644 --- a/arch/x86/events/amd/iommu.c +++ b/arch/x86/events/amd/iommu.c @@ -11,6 +11,8 @@ * published by the Free Software Foundation. */ +#define pr_fmt(fmt) "perf/amd_iommu: " fmt + #include #include #include @@ -288,7 +290,6 @@ static void perf_iommu_start(struct perf_event *event, int flags) u64 val; struct hw_perf_event *hwc = &event->hw; - pr_debug("perf: amd_iommu:perf_iommu_start\n"); if (WARN_ON_ONCE(!(hwc->state & PERF_HES_STOPPED))) return; @@ -312,7 +313,6 @@ static void perf_iommu_read(struct perf_event *event) u64 cnt, prev; s64 delta; struct hw_perf_event *hwc = &event->hw; - pr_debug("perf: amd_iommu:perf_iommu_read\n"); if (amd_iommu_pc_get_counter(0, _GET_BANK(event), _GET_CNTR(event), &cnt)) return; @@ -339,8 +339,6 @@ static void perf_iommu_stop(struct perf_event *event, int flags) struct hw_perf_event *hwc = &event->hw; u64 config; - pr_debug("perf: amd_iommu:perf_iommu_stop\n"); - if (hwc->state & PERF_HES_UPTODATE) return; @@ -362,7 +360,6 @@ static int perf_iommu_add(struct perf_event *event, int flags) struct perf_amd_iommu *perf_iommu = container_of(event->pmu, struct perf_amd_iommu, pmu); - pr_debug("perf: amd_iommu:perf_iommu_add\n"); event->hw.state = PERF_HES_UPTODATE | PERF_HES_STOPPED; /* request an iommu bank/counter */ @@ -383,7 +380,6 @@ static void perf_iommu_del(struct perf_event *event, int flags) struct perf_amd_iommu *perf_iommu = container_of(event->pmu, struct perf_amd_iommu, pmu); - pr_debug("perf: amd_iommu:perf_iommu_del\n"); perf_iommu_stop(event, PERF_EF_UPDATE); /* clear the assigned iommu bank/counter */ @@ -443,7 +439,7 @@ static __init int _init_perf_amd_iommu( /* Init events attributes */ if (_init_events_attrs(perf_iommu) != 0) - pr_err("perf: amd_iommu: Only support raw events.\n"); + pr_err("Only support raw events.\n"); perf_iommu->max_banks = amd_iommu_pc_get_max_banks(0); perf_iommu->max_counters = amd_iommu_pc_get_max_counters(0); @@ -456,7 +452,7 @@ static __init int _init_perf_amd_iommu( ret = perf_pmu_register(&perf_iommu->pmu, name, -1); if (ret) { - pr_err("perf: amd_iommu: Failed to initialized.\n"); + pr_err("Error initializing AMD IOMMU perf counters.\n"); amd_iommu_pc_exit(); } else { pr_info("perf: amd_iommu: Detected. (%d banks, %d counters/bank)\n", -- 1.8.3.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suravee Suthikulpanit Subject: [PATCH V6 4/7] perf/amd/iommu: Declare pr_fmt and remove unnecessary pr_debug Date: Fri, 23 Dec 2016 20:38:47 +0700 Message-ID: <1482500330-5606-5-git-send-email-Suravee.Suthikulpanit@amd.com> References: <1482500330-5606-1-git-send-email-Suravee.Suthikulpanit@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1482500330-5606-1-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Cc: peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org List-Id: iommu@lists.linux-foundation.org This patch declare pr_fmt for perf/amd_iommu and remove unnecessary pr_debug. Cc: Peter Zijlstra Cc: Borislav Petkov Signed-off-by: Suravee Suthikulpanit --- arch/x86/events/amd/iommu.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/arch/x86/events/amd/iommu.c b/arch/x86/events/amd/iommu.c index 9744dc8..9bff41d 100644 --- a/arch/x86/events/amd/iommu.c +++ b/arch/x86/events/amd/iommu.c @@ -11,6 +11,8 @@ * published by the Free Software Foundation. */ +#define pr_fmt(fmt) "perf/amd_iommu: " fmt + #include #include #include @@ -288,7 +290,6 @@ static void perf_iommu_start(struct perf_event *event, int flags) u64 val; struct hw_perf_event *hwc = &event->hw; - pr_debug("perf: amd_iommu:perf_iommu_start\n"); if (WARN_ON_ONCE(!(hwc->state & PERF_HES_STOPPED))) return; @@ -312,7 +313,6 @@ static void perf_iommu_read(struct perf_event *event) u64 cnt, prev; s64 delta; struct hw_perf_event *hwc = &event->hw; - pr_debug("perf: amd_iommu:perf_iommu_read\n"); if (amd_iommu_pc_get_counter(0, _GET_BANK(event), _GET_CNTR(event), &cnt)) return; @@ -339,8 +339,6 @@ static void perf_iommu_stop(struct perf_event *event, int flags) struct hw_perf_event *hwc = &event->hw; u64 config; - pr_debug("perf: amd_iommu:perf_iommu_stop\n"); - if (hwc->state & PERF_HES_UPTODATE) return; @@ -362,7 +360,6 @@ static int perf_iommu_add(struct perf_event *event, int flags) struct perf_amd_iommu *perf_iommu = container_of(event->pmu, struct perf_amd_iommu, pmu); - pr_debug("perf: amd_iommu:perf_iommu_add\n"); event->hw.state = PERF_HES_UPTODATE | PERF_HES_STOPPED; /* request an iommu bank/counter */ @@ -383,7 +380,6 @@ static void perf_iommu_del(struct perf_event *event, int flags) struct perf_amd_iommu *perf_iommu = container_of(event->pmu, struct perf_amd_iommu, pmu); - pr_debug("perf: amd_iommu:perf_iommu_del\n"); perf_iommu_stop(event, PERF_EF_UPDATE); /* clear the assigned iommu bank/counter */ @@ -443,7 +439,7 @@ static __init int _init_perf_amd_iommu( /* Init events attributes */ if (_init_events_attrs(perf_iommu) != 0) - pr_err("perf: amd_iommu: Only support raw events.\n"); + pr_err("Only support raw events.\n"); perf_iommu->max_banks = amd_iommu_pc_get_max_banks(0); perf_iommu->max_counters = amd_iommu_pc_get_max_counters(0); @@ -456,7 +452,7 @@ static __init int _init_perf_amd_iommu( ret = perf_pmu_register(&perf_iommu->pmu, name, -1); if (ret) { - pr_err("perf: amd_iommu: Failed to initialized.\n"); + pr_err("Error initializing AMD IOMMU perf counters.\n"); amd_iommu_pc_exit(); } else { pr_info("perf: amd_iommu: Detected. (%d banks, %d counters/bank)\n", -- 1.8.3.1