Re: [Qemu-devel] [RFC PATCH] Fix pasting into serial console in GTK ui

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20161223151253.21338-1-msuchanek@suse.de
Subject: [Qemu-devel] [RFC PATCH] Fix pasting into serial console in GTK ui

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20161223151253.21338-1-msuchanek@suse.de -> patchew/20161223151253.21338-1-msuchanek@suse.de
Switched to a new branch 'test'
74e9646 Fix pasting into serial console in GTK ui

=== OUTPUT BEGIN ===
Checking PATCH 1/1: Fix pasting into serial console in GTK ui...
ERROR: space prohibited after that open parenthesis '('
#51: FILE: ui/gtk.c:1755:
+    if ( size > len) {

ERROR: braces {} are necessary for all arms of this statement
#57: FILE: ui/gtk.c:1761:
+    if (inbuf->sent < inbuf->size)
[...]
+    else {
[...]

ERROR: braces {} are necessary for all arms of this statement
#74: FILE: ui/gtk.c:1778:
+        if (!inbuf)
[...]

total: 3 errors, 0 warnings, 70 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org