From mboxrd@z Thu Jan 1 00:00:00 1970 From: Qiming Yang Subject: [PATCH v3 1/4] ethdev: add firmware information get Date: Tue, 27 Dec 2016 20:30:13 +0800 Message-ID: <1482841816-54143-2-git-send-email-qiming.yang@intel.com> References: <1481008582-69416-1-git-send-email-qiming.yang@intel.com> <1482841816-54143-1-git-send-email-qiming.yang@intel.com> Cc: remy.horton@intel.com, ferruh.yigit@intel.com, Qiming Yang To: dev@dpdk.org, thomas.monjalon@6wind.com Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 6D71336E for ; Tue, 27 Dec 2016 13:35:46 +0100 (CET) In-Reply-To: <1482841816-54143-1-git-send-email-qiming.yang@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch adds a new API 'rte_eth_dev_fw_info_get' for fetching firmware related information by a given device. Signed-off-by: Qiming Yang Acked-by: Remy Horton --- v2 changes: * modified some comment statements. v3 changes: * change API, use rte_eth_dev_fw_info_get(uint8_t port_id, uint32_t *fw_major, uint32_t *fw_minor, uint32_t *fw_patch, uint32_t *etrack_id) instead of rte_eth_dev_fwver_get(uint8_t port_id, char *fw_version, int fw_length). Add statusment in /doc/guides/nics/features/default.ini and release_17_02.rst. --- --- doc/guides/nics/features/default.ini | 1 + doc/guides/rel_notes/release_17_02.rst | 4 ++++ lib/librte_ether/rte_ethdev.c | 14 ++++++++++++++ lib/librte_ether/rte_ethdev.h | 23 +++++++++++++++++++++++ lib/librte_ether/rte_ether_version.map | 1 + 5 files changed, 43 insertions(+) diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini index f1bf9bf..8237ee4 100644 --- a/doc/guides/nics/features/default.ini +++ b/doc/guides/nics/features/default.ini @@ -66,3 +66,4 @@ x86-64 = Usage doc = Design doc = Perf doc = +FW version = diff --git a/doc/guides/rel_notes/release_17_02.rst b/doc/guides/rel_notes/release_17_02.rst index 180af82..f6dc6c0 100644 --- a/doc/guides/rel_notes/release_17_02.rst +++ b/doc/guides/rel_notes/release_17_02.rst @@ -52,6 +52,10 @@ New Features See the :ref:`Generic flow API ` documentation for more information. +* **Added firmware information get API.** + Added a new function ``rte_eth_dev_fw_info_get()`` to fetch firmware related + information by a given device. Information include major firmware version, + minor firmware version, patch number and etrack id. Resolved Issues --------------- diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 280f0db..f399f09 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -1586,6 +1586,20 @@ rte_eth_dev_set_rx_queue_stats_mapping(uint8_t port_id, uint16_t rx_queue_id, } void +rte_eth_dev_fw_info_get(uint8_t port_id, uint32_t *fw_major, uint32_t *fw_minor, + uint32_t *fw_patch, uint32_t *etrack_id) +{ + struct rte_eth_dev *dev; + + RTE_ETH_VALID_PORTID_OR_RET(port_id); + dev = &rte_eth_devices[port_id]; + + RTE_FUNC_PTR_OR_RET(*dev->dev_ops->fw_version_get); + (*dev->dev_ops->fw_version_get)(dev, fw_major, fw_minor, + fw_patch, etrack_id); +} + +void rte_eth_dev_info_get(uint8_t port_id, struct rte_eth_dev_info *dev_info) { struct rte_eth_dev *dev; diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index fb51754..829f652 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -1150,6 +1150,11 @@ typedef uint32_t (*eth_rx_queue_count_t)(struct rte_eth_dev *dev, typedef int (*eth_rx_descriptor_done_t)(void *rxq, uint16_t offset); /**< @internal Check DD bit of specific RX descriptor */ +typedef void (*eth_fw_version_get_t)(struct rte_eth_dev *dev, + uint32_t *fw_major, uint32_t *fw_minor, + uint32_t *fw_patch, uint32_t *etrack_id); +/**< @internal Get firmware information of an Ethernet device. */ + typedef void (*eth_rxq_info_get_t)(struct rte_eth_dev *dev, uint16_t rx_queue_id, struct rte_eth_rxq_info *qinfo); @@ -1457,6 +1462,7 @@ struct eth_dev_ops { eth_txq_info_get_t txq_info_get; /**< retrieve TX queue information. */ eth_dev_supported_ptypes_get_t dev_supported_ptypes_get; /**< Get packet types supported and identified by device. */ + eth_fw_version_get_t fw_version_get; /**< Get firmware version. */ vlan_filter_set_t vlan_filter_set; /**< Filter VLAN Setup. */ vlan_tpid_set_t vlan_tpid_set; /**< Outer/Inner VLAN TPID Setup. */ @@ -2395,6 +2401,23 @@ void rte_eth_macaddr_get(uint8_t port_id, struct ether_addr *mac_addr); void rte_eth_dev_info_get(uint8_t port_id, struct rte_eth_dev_info *dev_info); /** + * Retrieve the firmware version of a device. + * + * @param port_id + * The port identifier of the device. + * @param fw_major + * A array pointer to store the major firmware version of a device. + * @param fw_minor + * A array pointer to store the minor firmware version of a device. + * @param fw_patch + * A array pointer to store the firmware patch number of a device. + * @param etrack_id + * A array pointer to store the nvm version of a device. + */ +void rte_eth_dev_fw_info_get(uint8_t port_id, uint32_t *fw_major, + uint32_t *fw_minor, uint32_t *fw_patch, uint32_t *etrack_id); + +/** * Retrieve the supported packet types of an Ethernet device. * * When a packet type is announced as supported, it *must* be recognized by diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map index a021781..a89bfaa 100644 --- a/lib/librte_ether/rte_ether_version.map +++ b/lib/librte_ether/rte_ether_version.map @@ -156,5 +156,6 @@ DPDK_17.02 { rte_flow_flush; rte_flow_query; rte_flow_validate; + rte_eth_dev_fw_info_get; } DPDK_16.11; -- 2.7.4