All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aaron Conole <aconole@redhat.com>
To: dev@dpdk.org
Subject: [RFC 07/23] eal: Signal error when CPU isn't supported
Date: Fri, 30 Dec 2016 10:26:04 -0500	[thread overview]
Message-ID: <1483111580-5397-8-git-send-email-aconole@redhat.com> (raw)
In-Reply-To: <1483111580-5397-1-git-send-email-aconole@redhat.com>

It's now possible to gracefully exit the application, or for
applications which support non-dpdk datapaths working in concert with
DPDK datapaths, there no longer is the possibility of exiting for
unsupported CPUs.

Signed-off-by: Aaron Conole <aconole@redhat.com>
---
 lib/librte_eal/linuxapp/eal/eal.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
index 1c371f6..909f6b7 100644
--- a/lib/librte_eal/linuxapp/eal/eal.c
+++ b/lib/librte_eal/linuxapp/eal/eal.c
@@ -751,7 +751,10 @@ rte_eal_init(int argc, char **argv)
 	char thread_name[RTE_MAX_THREAD_NAME_LEN];
 
 	/* checks if the machine is adequate */
-	rte_cpu_check_supported();
+	if (!rte_cpu_is_supported()) {
+		errno = ENOTSUP;
+		return -1;
+	}
 
 	if (!rte_atomic32_test_and_set(&run_once))
 		return -1;
-- 
2.7.4

  parent reply	other threads:[~2016-12-30 15:26 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-30 15:25 [RFC 00/23] Refactor eal_init to remove panic() calls Aaron Conole
2016-12-30 15:25 ` [RFC 01/23] eal: CPU init will no longer panic Aaron Conole
2016-12-30 15:25 ` [RFC 02/23] eal: return error instead of panic for cpu init Aaron Conole
2016-12-30 15:26 ` [RFC 03/23] eal: No panic on hugepages info init Aaron Conole
2016-12-30 15:26 ` [RFC 04/23] eal: do not panic on failed hugepage query Aaron Conole
2016-12-30 15:26 ` [RFC 05/23] eal: failure to parse args returns error Aaron Conole
2016-12-30 15:26 ` [RFC 06/23] eal-common: introduce a way to query cpu support Aaron Conole
2016-12-30 15:26 ` Aaron Conole [this message]
2016-12-30 15:26 ` [RFC 08/23] eal: do not panic on memzone initialization fails Aaron Conole
2016-12-30 15:26 ` [RFC 09/23] eal: set errno when exiting for already called Aaron Conole
2016-12-30 15:26 ` [RFC 10/23] eal: Do not panic on log failures Aaron Conole
2016-12-30 15:26 ` [RFC 11/23] eal: Do not panic on pci-probe Aaron Conole
2016-12-30 15:26 ` [RFC 12/23] eal: do not panic on vfio failure Aaron Conole
2016-12-30 15:26 ` [RFC 13/23] eal: do not panic on memory init Aaron Conole
2016-12-30 15:26 ` [RFC 14/23] eal: do not panic on tailq init Aaron Conole
2016-12-30 15:26 ` [RFC 15/23] eal: do not panic on alarm init Aaron Conole
2016-12-30 15:26 ` [RFC 16/23] eal: convert timer_init not to call panic Aaron Conole
2016-12-30 15:26 ` [RFC 17/23] eal: change the private pipe call to reflect errno Aaron Conole
2016-12-30 15:26 ` [RFC 18/23] eal: Do not panic on interrupt thread init Aaron Conole
2016-12-30 15:26 ` [RFC 19/23] eal: do not error if plugins fail to init Aaron Conole
2016-12-30 15:26 ` [RFC 20/23] eal_pci: Continue probing even on failures Aaron Conole
2016-12-30 15:26 ` [RFC 21/23] eal: do not panic on failed PCI probe Aaron Conole
2016-12-30 15:26 ` [RFC 22/23] eal_common_dev: continue initializing vdevs Aaron Conole
2016-12-30 15:26 ` [RFC 23/23] eal: do not panic (or abort) if vdev init fails Aaron Conole
2017-01-02 14:22 ` [RFC 00/23] Refactor eal_init to remove panic() calls Thomas Monjalon
2017-01-03 16:06   ` Aaron Conole
2017-01-25 21:33   ` Aaron Conole

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1483111580-5397-8-git-send-email-aconole@redhat.com \
    --to=aconole@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.