All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] [PATCH] usb: storage: unusual_uas: Add JMicron JMS56x to unusual device
@ 2017-01-02 14:26 Oliver Neukum
  2017-01-02 15:51 ` Alan Stern
  0 siblings, 1 reply; 2+ messages in thread
From: Oliver Neukum @ 2017-01-02 14:26 UTC (permalink / raw)
  To: gregKH, linux-usb; +Cc: Oliver Neukum, George Cherian, Oliver Neukum, stable

This device gives the following error on detection.
xhci_hcd 0000:00:11.0: ERROR Transfer event for disabled endpoint or
incorrect stream ring

The same error is not seen when it is added to unusual_device
list with US_FL_NO_REPORT_OPCODES passed.

Signed-off-by: George Cherian <george.cherian@cavium.com>
Signed-off-by: Oliver Neukum <oneukun@suse.com>
CC: stable@vger.kernel.org
---
 drivers/usb/storage/unusual_devs.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index af3c7ee..16cc183 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -2109,6 +2109,13 @@ UNUSUAL_DEV(  0x152d, 0x2566, 0x0114, 0x0114,
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
 		US_FL_BROKEN_FUA ),
 
+/* Reported-by George Cherian <george.cherian@cavium.com> */
+UNUSUAL_DEV(0x152d, 0x9561, 0x0000, 0x9999,
+		"JMicron",
+		"JMS56x",
+		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
+		US_FL_NO_REPORT_OPCODES),
+
 /*
  * Entrega Technologies U1-SC25 (later Xircom PortGear PGSCSI)
  * and Mac USB Dock USB-SCSI */
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] [PATCH] usb: storage: unusual_uas: Add JMicron JMS56x to unusual device
  2017-01-02 14:26 [PATCH] [PATCH] usb: storage: unusual_uas: Add JMicron JMS56x to unusual device Oliver Neukum
@ 2017-01-02 15:51 ` Alan Stern
  0 siblings, 0 replies; 2+ messages in thread
From: Alan Stern @ 2017-01-02 15:51 UTC (permalink / raw)
  To: Oliver Neukum; +Cc: gregKH, linux-usb, George Cherian, Oliver Neukum, stable

On Mon, 2 Jan 2017, Oliver Neukum wrote:

> This device gives the following error on detection.
> xhci_hcd 0000:00:11.0: ERROR Transfer event for disabled endpoint or
> incorrect stream ring

Did you ever determine the reason for this ERROR message?  Exactly what 
is going wrong?  Is there a bug in xhci-hcd?  Or is it simply a race 
(in which case the message should not begin with "ERROR")?

Alan Stern

> The same error is not seen when it is added to unusual_device
> list with US_FL_NO_REPORT_OPCODES passed.
> 
> Signed-off-by: George Cherian <george.cherian@cavium.com>
> Signed-off-by: Oliver Neukum <oneukun@suse.com>
> CC: stable@vger.kernel.org
> ---
>  drivers/usb/storage/unusual_devs.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index af3c7ee..16cc183 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -2109,6 +2109,13 @@ UNUSUAL_DEV(  0x152d, 0x2566, 0x0114, 0x0114,
>  		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>  		US_FL_BROKEN_FUA ),
>  
> +/* Reported-by George Cherian <george.cherian@cavium.com> */
> +UNUSUAL_DEV(0x152d, 0x9561, 0x0000, 0x9999,
> +		"JMicron",
> +		"JMS56x",
> +		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> +		US_FL_NO_REPORT_OPCODES),
> +
>  /*
>   * Entrega Technologies U1-SC25 (later Xircom PortGear PGSCSI)
>   * and Mac USB Dock USB-SCSI */
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-01-02 15:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-02 14:26 [PATCH] [PATCH] usb: storage: unusual_uas: Add JMicron JMS56x to unusual device Oliver Neukum
2017-01-02 15:51 ` Alan Stern

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.