Re: [PATCH 1/2] iio: Add support for linear accel

Re: [PATCH 1/2] iio: Add support for linear accel

[Peter Meerwald-Stadler]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 3456 bytes --]


> Add new channel types support for linear accel sensor.
> 
> Linear acceleration differs from a standard accelerometor,
> its value depends on standard accel sensor and gravity sensor.
> Conceptually, this three sensors have following relationship:
> linear acceleration = acceleration - acceleration due to gravity
> 
> At rest, standard accelerometer displays 1g due to earth’s
> gravitational pull while a liner accelerometer will show 0g.

comment below
 
> More information can be found in:
> http://www.usb.org/developers/hidpage/HUTRR59_-_Usages_for_Wearables.pdf
> 
> Signed-off-by: Song Hongyan <hongyan.song@intel.com>
> ---
>  Documentation/ABI/testing/sysfs-bus-iio | 10 ++++++++++
>  drivers/iio/industrialio-core.c         |  1 +
>  include/uapi/linux/iio/types.h          |  1 +
>  tools/iio/iio_event_monitor.c           |  2 ++
>  4 files changed, 14 insertions(+)
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> index 60b7406..8091f3d 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio
> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> @@ -170,6 +170,16 @@ Description:
>  		Has all of the equivalent parameters as per voltageY. Units
>  		after application of scale and offset are m/s^2.
>  
> +What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_x_raw
> +What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_y_raw
> +What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_z_raw

I think this would be in_linearaccel_x_raw, etc.?

> +KernelVersion:	4.11
> +Contact:	linux-iio@vger.kernel.org
> +Description:
> +		Linear Acceleration in direction x, y or z (may be arbitrarily assigned
> +		but should match other such assignments on device).
> +		Has all of the equivalent parameters as per voltageY. Units
> +		after application of scale and offset are m/s^2.
>  
>  What:		/sys/bus/iio/devices/iio:deviceX/in_gravity_x_raw
>  What:		/sys/bus/iio/devices/iio:deviceX/in_gravity_y_raw
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index 72fc96a..da78c26 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -82,6 +82,7 @@ struct bus_type iio_bus_type = {
>  	[IIO_UVINDEX] = "uvindex",
>  	[IIO_ELECTRICALCONDUCTIVITY] = "electricalconductivity",
>  	[IIO_GRAVITY]  = "gravity",
> +	[IIO_LINEAR_ACCEL] = "linearaccel",
>  };
>  
>  static const char * const iio_modifier_names[] = {
> diff --git a/include/uapi/linux/iio/types.h b/include/uapi/linux/iio/types.h
> index d3f7ba7..d6df101 100644
> --- a/include/uapi/linux/iio/types.h
> +++ b/include/uapi/linux/iio/types.h
> @@ -41,6 +41,7 @@ enum iio_chan_type {
>  	IIO_UVINDEX,
>  	IIO_ELECTRICALCONDUCTIVITY,
>  	IIO_GRAVITY,
> +	IIO_LINEAR_ACCEL,
>  };
>  
>  enum iio_modifier {
> diff --git a/tools/iio/iio_event_monitor.c b/tools/iio/iio_event_monitor.c
> index b61245e..116644a 100644
> --- a/tools/iio/iio_event_monitor.c
> +++ b/tools/iio/iio_event_monitor.c
> @@ -58,6 +58,7 @@
>  	[IIO_PH] = "ph",
>  	[IIO_UVINDEX] = "uvindex",
>  	[IIO_GRAVITY] = "gravity",
> +	[IIO_LINEAR_ACCEL] = "linearaccel",
>  };
>  
>  static const char * const iio_ev_type_text[] = {
> @@ -151,6 +152,7 @@ static bool event_is_known(struct iio_event_data *event)
>  	case IIO_PH:
>  	case IIO_UVINDEX:
>  	case IIO_GRAVITY:
> +	case IIO_LINEAR_ACCEL:
>  		break;
>  	default:
>  		return false;
> 

-- 

Peter Meerwald-Stadler
+43-664-2444418 (mobile)

RE: [PATCH 1/2] iio: Add support for linear accel

[Song, Hongyan]

Hi peter,
	 I checked and find that iio device name is usually named to be with underline if it has more than one word, so I assigned to be " linear_accel_3d".
 I think the device property node named to be "in_linear_accel_x_raw" is better than " in_linearaccel_x_raw" Just follow the former coding style.

"linearaccel" is only a name which specify IIO type [IIO_LINEAR_ACCEL]
I name [IIO_LINEAR_ACCEL] to be "linearaccel" just follow the history code style in " iio_chan_type_name_spec[]" which do not have any underline.

What do you think?

BR
Song Hongyan

-----Original Message-----
From: Peter Meerwald-Stadler [mailto:pmeerw@pmeerw.net] 
Sent: Tuesday, January 3, 2017 3:23 PM
To: Song, Hongyan <hongyan.song@intel.com>
Cc: linux-input@vger.kernel.org; linux-iio@vger.kernel.org; jikos@kernel.org; jic23@kernel.org; Pandruvada, Srinivas <srinivas.pandruvada@intel.com>
Subject: Re: [PATCH 1/2] iio: Add support for linear accel


> Add new channel types support for linear accel sensor.
> 
> Linear acceleration differs from a standard accelerometor, its value 
> depends on standard accel sensor and gravity sensor.
> Conceptually, this three sensors have following relationship:
> linear acceleration = acceleration - acceleration due to gravity
> 
> At rest, standard accelerometer displays 1g due to earth’s 
> gravitational pull while a liner accelerometer will show 0g.

comment below
 
> More information can be found in:
> http://www.usb.org/developers/hidpage/HUTRR59_-_Usages_for_Wearables.p
> df
> 
> Signed-off-by: Song Hongyan <hongyan.song@intel.com>
> ---
>  Documentation/ABI/testing/sysfs-bus-iio | 10 ++++++++++
>  drivers/iio/industrialio-core.c         |  1 +
>  include/uapi/linux/iio/types.h          |  1 +
>  tools/iio/iio_event_monitor.c           |  2 ++
>  4 files changed, 14 insertions(+)
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio 
> b/Documentation/ABI/testing/sysfs-bus-iio
> index 60b7406..8091f3d 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio
> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> @@ -170,6 +170,16 @@ Description:
>  		Has all of the equivalent parameters as per voltageY. Units
>  		after application of scale and offset are m/s^2.
>  
> +What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_x_raw
> +What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_y_raw
> +What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_z_raw

I think this would be in_linearaccel_x_raw, etc.?

> +KernelVersion:	4.11
> +Contact:	linux-iio@vger.kernel.org
> +Description:
> +		Linear Acceleration in direction x, y or z (may be arbitrarily assigned
> +		but should match other such assignments on device).
> +		Has all of the equivalent parameters as per voltageY. Units
> +		after application of scale and offset are m/s^2.
>  
>  What:		/sys/bus/iio/devices/iio:deviceX/in_gravity_x_raw
>  What:		/sys/bus/iio/devices/iio:deviceX/in_gravity_y_raw
> diff --git a/drivers/iio/industrialio-core.c 
> b/drivers/iio/industrialio-core.c index 72fc96a..da78c26 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -82,6 +82,7 @@ struct bus_type iio_bus_type = {
>  	[IIO_UVINDEX] = "uvindex",
>  	[IIO_ELECTRICALCONDUCTIVITY] = "electricalconductivity",
>  	[IIO_GRAVITY]  = "gravity",
> +	[IIO_LINEAR_ACCEL] = "linearaccel",
>  };
>  
>  static const char * const iio_modifier_names[] = { diff --git 
> a/include/uapi/linux/iio/types.h b/include/uapi/linux/iio/types.h 
> index d3f7ba7..d6df101 100644
> --- a/include/uapi/linux/iio/types.h
> +++ b/include/uapi/linux/iio/types.h
> @@ -41,6 +41,7 @@ enum iio_chan_type {
>  	IIO_UVINDEX,
>  	IIO_ELECTRICALCONDUCTIVITY,
>  	IIO_GRAVITY,
> +	IIO_LINEAR_ACCEL,
>  };
>  
>  enum iio_modifier {
> diff --git a/tools/iio/iio_event_monitor.c 
> b/tools/iio/iio_event_monitor.c index b61245e..116644a 100644
> --- a/tools/iio/iio_event_monitor.c
> +++ b/tools/iio/iio_event_monitor.c
> @@ -58,6 +58,7 @@
>  	[IIO_PH] = "ph",
>  	[IIO_UVINDEX] = "uvindex",
>  	[IIO_GRAVITY] = "gravity",
> +	[IIO_LINEAR_ACCEL] = "linearaccel",
>  };
>  
>  static const char * const iio_ev_type_text[] = { @@ -151,6 +152,7 @@ 
> static bool event_is_known(struct iio_event_data *event)
>  	case IIO_PH:
>  	case IIO_UVINDEX:
>  	case IIO_GRAVITY:
> +	case IIO_LINEAR_ACCEL:
>  		break;
>  	default:
>  		return false;
> 

-- 

Peter Meerwald-Stadler
+43-664-2444418 (mobile)

RE: [PATCH 1/2] iio: Add support for linear accel

[Song, Hongyan]

SGkgcGV0ZXIsDQoJIEkgY2hlY2tlZCBhbmQgZmluZCB0aGF0IGlpbyBkZXZpY2UgbmFtZSBpcyB1
c3VhbGx5IG5hbWVkIHRvIGJlIHdpdGggdW5kZXJsaW5lIGlmIGl0IGhhcyBtb3JlIHRoYW4gb25l
IHdvcmQsIHNvIEkgYXNzaWduZWQgdG8gYmUgIiBsaW5lYXJfYWNjZWxfM2QiLg0KIEkgdGhpbmsg
dGhlIGRldmljZSBwcm9wZXJ0eSBub2RlIG5hbWVkIHRvIGJlICJpbl9saW5lYXJfYWNjZWxfeF9y
YXciIGlzIGJldHRlciB0aGFuICIgaW5fbGluZWFyYWNjZWxfeF9yYXciIEp1c3QgZm9sbG93IHRo
ZSBmb3JtZXIgY29kaW5nIHN0eWxlLg0KDQoibGluZWFyYWNjZWwiIGlzIG9ubHkgYSBuYW1lIHdo
aWNoIHNwZWNpZnkgSUlPIHR5cGUgW0lJT19MSU5FQVJfQUNDRUxdDQpJIG5hbWUgW0lJT19MSU5F
QVJfQUNDRUxdIHRvIGJlICJsaW5lYXJhY2NlbCIganVzdCBmb2xsb3cgdGhlIGhpc3RvcnkgY29k
ZSBzdHlsZSBpbiAiIGlpb19jaGFuX3R5cGVfbmFtZV9zcGVjW10iIHdoaWNoIGRvIG5vdCBoYXZl
IGFueSB1bmRlcmxpbmUuDQoNCldoYXQgZG8geW91IHRoaW5rPw0KDQpCUg0KU29uZyBIb25neWFu
DQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBQZXRlciBNZWVyd2FsZC1TdGFk
bGVyIFttYWlsdG86cG1lZXJ3QHBtZWVydy5uZXRdIA0KU2VudDogVHVlc2RheSwgSmFudWFyeSAz
LCAyMDE3IDM6MjMgUE0NClRvOiBTb25nLCBIb25neWFuIDxob25neWFuLnNvbmdAaW50ZWwuY29t
Pg0KQ2M6IGxpbnV4LWlucHV0QHZnZXIua2VybmVsLm9yZzsgbGludXgtaWlvQHZnZXIua2VybmVs
Lm9yZzsgamlrb3NAa2VybmVsLm9yZzsgamljMjNAa2VybmVsLm9yZzsgUGFuZHJ1dmFkYSwgU3Jp
bml2YXMgPHNyaW5pdmFzLnBhbmRydXZhZGFAaW50ZWwuY29tPg0KU3ViamVjdDogUmU6IFtQQVRD
SCAxLzJdIGlpbzogQWRkIHN1cHBvcnQgZm9yIGxpbmVhciBhY2NlbA0KDQoNCj4gQWRkIG5ldyBj
aGFubmVsIHR5cGVzIHN1cHBvcnQgZm9yIGxpbmVhciBhY2NlbCBzZW5zb3IuDQo+IA0KPiBMaW5l
YXIgYWNjZWxlcmF0aW9uIGRpZmZlcnMgZnJvbSBhIHN0YW5kYXJkIGFjY2VsZXJvbWV0b3IsIGl0
cyB2YWx1ZSANCj4gZGVwZW5kcyBvbiBzdGFuZGFyZCBhY2NlbCBzZW5zb3IgYW5kIGdyYXZpdHkg
c2Vuc29yLg0KPiBDb25jZXB0dWFsbHksIHRoaXMgdGhyZWUgc2Vuc29ycyBoYXZlIGZvbGxvd2lu
ZyByZWxhdGlvbnNoaXA6DQo+IGxpbmVhciBhY2NlbGVyYXRpb24gPSBhY2NlbGVyYXRpb24gLSBh
Y2NlbGVyYXRpb24gZHVlIHRvIGdyYXZpdHkNCj4gDQo+IEF0IHJlc3QsIHN0YW5kYXJkIGFjY2Vs
ZXJvbWV0ZXIgZGlzcGxheXMgMWcgZHVlIHRvIGVhcnRo4oCZcyANCj4gZ3Jhdml0YXRpb25hbCBw
dWxsIHdoaWxlIGEgbGluZXIgYWNjZWxlcm9tZXRlciB3aWxsIHNob3cgMGcuDQoNCmNvbW1lbnQg
YmVsb3cNCiANCj4gTW9yZSBpbmZvcm1hdGlvbiBjYW4gYmUgZm91bmQgaW46DQo+IGh0dHA6Ly93
d3cudXNiLm9yZy9kZXZlbG9wZXJzL2hpZHBhZ2UvSFVUUlI1OV8tX1VzYWdlc19mb3JfV2VhcmFi
bGVzLnANCj4gZGYNCj4gDQo+IFNpZ25lZC1vZmYtYnk6IFNvbmcgSG9uZ3lhbiA8aG9uZ3lhbi5z
b25nQGludGVsLmNvbT4NCj4gLS0tDQo+ICBEb2N1bWVudGF0aW9uL0FCSS90ZXN0aW5nL3N5c2Zz
LWJ1cy1paW8gfCAxMCArKysrKysrKysrDQo+ICBkcml2ZXJzL2lpby9pbmR1c3RyaWFsaW8tY29y
ZS5jICAgICAgICAgfCAgMSArDQo+ICBpbmNsdWRlL3VhcGkvbGludXgvaWlvL3R5cGVzLmggICAg
ICAgICAgfCAgMSArDQo+ICB0b29scy9paW8vaWlvX2V2ZW50X21vbml0b3IuYyAgICAgICAgICAg
fCAgMiArKw0KPiAgNCBmaWxlcyBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspDQo+IA0KPiBkaWZm
IC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9BQkkvdGVzdGluZy9zeXNmcy1idXMtaWlvIA0KPiBiL0Rv
Y3VtZW50YXRpb24vQUJJL3Rlc3Rpbmcvc3lzZnMtYnVzLWlpbw0KPiBpbmRleCA2MGI3NDA2Li44
MDkxZjNkIDEwMDY0NA0KPiAtLS0gYS9Eb2N1bWVudGF0aW9uL0FCSS90ZXN0aW5nL3N5c2ZzLWJ1
cy1paW8NCj4gKysrIGIvRG9jdW1lbnRhdGlvbi9BQkkvdGVzdGluZy9zeXNmcy1idXMtaWlvDQo+
IEBAIC0xNzAsNiArMTcwLDE2IEBAIERlc2NyaXB0aW9uOg0KPiAgCQlIYXMgYWxsIG9mIHRoZSBl
cXVpdmFsZW50IHBhcmFtZXRlcnMgYXMgcGVyIHZvbHRhZ2VZLiBVbml0cw0KPiAgCQlhZnRlciBh
cHBsaWNhdGlvbiBvZiBzY2FsZSBhbmQgb2Zmc2V0IGFyZSBtL3NeMi4NCj4gIA0KPiArV2hhdDoJ
CS9zeXMvYnVzL2lpby9kZXZpY2VzL2lpbzpkZXZpY2VYL2luX2xpbmVhcl9hY2NlbF94X3Jhdw0K
PiArV2hhdDoJCS9zeXMvYnVzL2lpby9kZXZpY2VzL2lpbzpkZXZpY2VYL2luX2xpbmVhcl9hY2Nl
bF95X3Jhdw0KPiArV2hhdDoJCS9zeXMvYnVzL2lpby9kZXZpY2VzL2lpbzpkZXZpY2VYL2luX2xp
bmVhcl9hY2NlbF96X3Jhdw0KDQpJIHRoaW5rIHRoaXMgd291bGQgYmUgaW5fbGluZWFyYWNjZWxf
eF9yYXcsIGV0Yy4/DQoNCj4gK0tlcm5lbFZlcnNpb246CTQuMTENCj4gK0NvbnRhY3Q6CWxpbnV4
LWlpb0B2Z2VyLmtlcm5lbC5vcmcNCj4gK0Rlc2NyaXB0aW9uOg0KPiArCQlMaW5lYXIgQWNjZWxl
cmF0aW9uIGluIGRpcmVjdGlvbiB4LCB5IG9yIHogKG1heSBiZSBhcmJpdHJhcmlseSBhc3NpZ25l
ZA0KPiArCQlidXQgc2hvdWxkIG1hdGNoIG90aGVyIHN1Y2ggYXNzaWdubWVudHMgb24gZGV2aWNl
KS4NCj4gKwkJSGFzIGFsbCBvZiB0aGUgZXF1aXZhbGVudCBwYXJhbWV0ZXJzIGFzIHBlciB2b2x0
YWdlWS4gVW5pdHMNCj4gKwkJYWZ0ZXIgYXBwbGljYXRpb24gb2Ygc2NhbGUgYW5kIG9mZnNldCBh
cmUgbS9zXjIuDQo+ICANCj4gIFdoYXQ6CQkvc3lzL2J1cy9paW8vZGV2aWNlcy9paW86ZGV2aWNl
WC9pbl9ncmF2aXR5X3hfcmF3DQo+ICBXaGF0OgkJL3N5cy9idXMvaWlvL2RldmljZXMvaWlvOmRl
dmljZVgvaW5fZ3Jhdml0eV95X3Jhdw0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9paW8vaW5kdXN0
cmlhbGlvLWNvcmUuYyANCj4gYi9kcml2ZXJzL2lpby9pbmR1c3RyaWFsaW8tY29yZS5jIGluZGV4
IDcyZmM5NmEuLmRhNzhjMjYgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvaWlvL2luZHVzdHJpYWxp
by1jb3JlLmMNCj4gKysrIGIvZHJpdmVycy9paW8vaW5kdXN0cmlhbGlvLWNvcmUuYw0KPiBAQCAt
ODIsNiArODIsNyBAQCBzdHJ1Y3QgYnVzX3R5cGUgaWlvX2J1c190eXBlID0gew0KPiAgCVtJSU9f
VVZJTkRFWF0gPSAidXZpbmRleCIsDQo+ICAJW0lJT19FTEVDVFJJQ0FMQ09ORFVDVElWSVRZXSA9
ICJlbGVjdHJpY2FsY29uZHVjdGl2aXR5IiwNCj4gIAlbSUlPX0dSQVZJVFldICA9ICJncmF2aXR5
IiwNCj4gKwlbSUlPX0xJTkVBUl9BQ0NFTF0gPSAibGluZWFyYWNjZWwiLA0KPiAgfTsNCj4gIA0K
PiAgc3RhdGljIGNvbnN0IGNoYXIgKiBjb25zdCBpaW9fbW9kaWZpZXJfbmFtZXNbXSA9IHsgZGlm
ZiAtLWdpdCANCj4gYS9pbmNsdWRlL3VhcGkvbGludXgvaWlvL3R5cGVzLmggYi9pbmNsdWRlL3Vh
cGkvbGludXgvaWlvL3R5cGVzLmggDQo+IGluZGV4IGQzZjdiYTcuLmQ2ZGYxMDEgMTAwNjQ0DQo+
IC0tLSBhL2luY2x1ZGUvdWFwaS9saW51eC9paW8vdHlwZXMuaA0KPiArKysgYi9pbmNsdWRlL3Vh
cGkvbGludXgvaWlvL3R5cGVzLmgNCj4gQEAgLTQxLDYgKzQxLDcgQEAgZW51bSBpaW9fY2hhbl90
eXBlIHsNCj4gIAlJSU9fVVZJTkRFWCwNCj4gIAlJSU9fRUxFQ1RSSUNBTENPTkRVQ1RJVklUWSwN
Cj4gIAlJSU9fR1JBVklUWSwNCj4gKwlJSU9fTElORUFSX0FDQ0VMLA0KPiAgfTsNCj4gIA0KPiAg
ZW51bSBpaW9fbW9kaWZpZXIgew0KPiBkaWZmIC0tZ2l0IGEvdG9vbHMvaWlvL2lpb19ldmVudF9t
b25pdG9yLmMgDQo+IGIvdG9vbHMvaWlvL2lpb19ldmVudF9tb25pdG9yLmMgaW5kZXggYjYxMjQ1
ZS4uMTE2NjQ0YSAxMDA2NDQNCj4gLS0tIGEvdG9vbHMvaWlvL2lpb19ldmVudF9tb25pdG9yLmMN
Cj4gKysrIGIvdG9vbHMvaWlvL2lpb19ldmVudF9tb25pdG9yLmMNCj4gQEAgLTU4LDYgKzU4LDcg
QEANCj4gIAlbSUlPX1BIXSA9ICJwaCIsDQo+ICAJW0lJT19VVklOREVYXSA9ICJ1dmluZGV4IiwN
Cj4gIAlbSUlPX0dSQVZJVFldID0gImdyYXZpdHkiLA0KPiArCVtJSU9fTElORUFSX0FDQ0VMXSA9
ICJsaW5lYXJhY2NlbCIsDQo+ICB9Ow0KPiAgDQo+ICBzdGF0aWMgY29uc3QgY2hhciAqIGNvbnN0
IGlpb19ldl90eXBlX3RleHRbXSA9IHsgQEAgLTE1MSw2ICsxNTIsNyBAQCANCj4gc3RhdGljIGJv
b2wgZXZlbnRfaXNfa25vd24oc3RydWN0IGlpb19ldmVudF9kYXRhICpldmVudCkNCj4gIAljYXNl
IElJT19QSDoNCj4gIAljYXNlIElJT19VVklOREVYOg0KPiAgCWNhc2UgSUlPX0dSQVZJVFk6DQo+
ICsJY2FzZSBJSU9fTElORUFSX0FDQ0VMOg0KPiAgCQlicmVhazsNCj4gIAlkZWZhdWx0Og0KPiAg
CQlyZXR1cm4gZmFsc2U7DQo+IA0KDQotLSANCg0KUGV0ZXIgTWVlcndhbGQtU3RhZGxlcg0KKzQz
LTY2NC0yNDQ0NDE4IChtb2JpbGUpDQo=

RE: [PATCH 1/2] iio: Add support for linear accel

[Peter Meerwald-Stadler]

Hi,

> 	 I checked and find that iio device name is usually named to be with underline if it has more than one word, so I assigned to be " linear_accel_3d".
>  I think the device property node named to be "in_linear_accel_x_raw" is better than " in_linearaccel_x_raw" Just follow the former coding style.
> "linearaccel" is only a name which specify IIO type [IIO_LINEAR_ACCEL]
> I name [IIO_LINEAR_ACCEL] to be "linearaccel" just follow the history code style in " iio_chan_type_name_spec[]" which do not have any underline.

> > +What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_x_raw
> > +What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_y_raw
> > +What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_z_raw
> 
> I think this would be in_linearaccel_x_raw, etc.?

> > @@ -82,6 +82,7 @@ struct bus_type iio_bus_type = {
> >  	[IIO_UVINDEX] = "uvindex",
> >  	[IIO_ELECTRICALCONDUCTIVITY] = "electricalconductivity",
> >  	[IIO_GRAVITY]  = "gravity",
> > +	[IIO_LINEAR_ACCEL] = "linearaccel",
> >  };


linearaccel vs. linear_accel is a matter of taste, I have no preference;
nevertheless, the documentation should match what IIO outputs

if you have "linearaccel" in iio_bus_type, I think the name of a 
LINEAR_ACCEL channel will end up as "in_linearaccel_x_raw" and must be 
documented like that -- i.e. there is a mismatch between 
documentation and actual code/output

probably your patches should be rebased, iio/testing branch has IIO_COUNT 
and IIO_INDEX channels

regards, p.


-- 

Peter Meerwald-Stadler
+43-664-2444418 (mobile)

RE: [PATCH 1/2] iio: Add support for linear accel

[Peter Meerwald-Stadler]

Hi,

> 	 I checked and find that iio device name is usually named to be with underline if it has more than one word, so I assigned to be " linear_accel_3d".
>  I think the device property node named to be "in_linear_accel_x_raw" is better than " in_linearaccel_x_raw" Just follow the former coding style.
> "linearaccel" is only a name which specify IIO type [IIO_LINEAR_ACCEL]
> I name [IIO_LINEAR_ACCEL] to be "linearaccel" just follow the history code style in " iio_chan_type_name_spec[]" which do not have any underline.

> > +What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_x_raw
> > +What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_y_raw
> > +What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_z_raw
> 
> I think this would be in_linearaccel_x_raw, etc.?

> > @@ -82,6 +82,7 @@ struct bus_type iio_bus_type = {
> >  	[IIO_UVINDEX] = "uvindex",
> >  	[IIO_ELECTRICALCONDUCTIVITY] = "electricalconductivity",
> >  	[IIO_GRAVITY]  = "gravity",
> > +	[IIO_LINEAR_ACCEL] = "linearaccel",
> >  };


linearaccel vs. linear_accel is a matter of taste, I have no preference;
nevertheless, the documentation should match what IIO outputs

if you have "linearaccel" in iio_bus_type, I think the name of a 
LINEAR_ACCEL channel will end up as "in_linearaccel_x_raw" and must be 
documented like that -- i.e. there is a mismatch between 
documentation and actual code/output

probably your patches should be rebased, iio/testing branch has IIO_COUNT 
and IIO_INDEX channels

regards, p.


-- 

Peter Meerwald-Stadler
+43-664-2444418 (mobile)

Re: [PATCH 1/2] iio: Add support for linear accel

[Lars-Peter Clausen]

On 01/03/2017 09:04 AM, Peter Meerwald-Stadler wrote:
> Hi,
> 
>> 	 I checked and find that iio device name is usually named to be with underline if it has more than one word, so I assigned to be " linear_accel_3d".
>>  I think the device property node named to be "in_linear_accel_x_raw" is better than " in_linearaccel_x_raw" Just follow the former coding style.
>> "linearaccel" is only a name which specify IIO type [IIO_LINEAR_ACCEL]
>> I name [IIO_LINEAR_ACCEL] to be "linearaccel" just follow the history code style in " iio_chan_type_name_spec[]" which do not have any underline.
> 
>>> +What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_x_raw
>>> +What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_y_raw
>>> +What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_z_raw
>>
>> I think this would be in_linearaccel_x_raw, etc.?
> 
>>> @@ -82,6 +82,7 @@ struct bus_type iio_bus_type = {
>>>  	[IIO_UVINDEX] = "uvindex",
>>>  	[IIO_ELECTRICALCONDUCTIVITY] = "electricalconductivity",
>>>  	[IIO_GRAVITY]  = "gravity",
>>> +	[IIO_LINEAR_ACCEL] = "linearaccel",
>>>  };
> 
> 
> linearaccel vs. linear_accel is a matter of taste, I have no preference;
> nevertheless, the documentation should match what IIO outputs

We use underscores as the field separator in the channel name. Having a
underscore as part of a field adds ambiguity and makes it a lot harder
to machine parse it. It's already complicated enough as it is. We should
avoid adding types with underscores in them.

[PATCH 1/2] iio: Add support for linear accel

[Song Hongyan]

Add new channel types support for linear accel sensor.

Linear acceleration differs from a standard accelerometor,
its value depends on standard accel sensor and gravity sensor.
Conceptually, this three sensors have following relationship:
linear acceleration = acceleration - acceleration due to gravity

At rest, standard accelerometer displays 1g due to earth’s
gravitational pull while a liner accelerometer will show 0g.

More information can be found in:
http://www.usb.org/developers/hidpage/HUTRR59_-_Usages_for_Wearables.pdf

Signed-off-by: Song Hongyan <hongyan.song-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 Documentation/ABI/testing/sysfs-bus-iio | 10 ++++++++++
 drivers/iio/industrialio-core.c         |  1 +
 include/uapi/linux/iio/types.h          |  1 +
 tools/iio/iio_event_monitor.c           |  2 ++
 4 files changed, 14 insertions(+)

diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
index 60b7406..8091f3d 100644
--- a/Documentation/ABI/testing/sysfs-bus-iio
+++ b/Documentation/ABI/testing/sysfs-bus-iio
@@ -170,6 +170,16 @@ Description:
 		Has all of the equivalent parameters as per voltageY. Units
 		after application of scale and offset are m/s^2.
 
+What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_x_raw
+What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_y_raw
+What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_z_raw
+KernelVersion:	4.11
+Contact:	linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
+Description:
+		Linear Acceleration in direction x, y or z (may be arbitrarily assigned
+		but should match other such assignments on device).
+		Has all of the equivalent parameters as per voltageY. Units
+		after application of scale and offset are m/s^2.
 
 What:		/sys/bus/iio/devices/iio:deviceX/in_gravity_x_raw
 What:		/sys/bus/iio/devices/iio:deviceX/in_gravity_y_raw
diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
index 72fc96a..da78c26 100644
--- a/drivers/iio/industrialio-core.c
+++ b/drivers/iio/industrialio-core.c
@@ -82,6 +82,7 @@ struct bus_type iio_bus_type = {
 	[IIO_UVINDEX] = "uvindex",
 	[IIO_ELECTRICALCONDUCTIVITY] = "electricalconductivity",
 	[IIO_GRAVITY]  = "gravity",
+	[IIO_LINEAR_ACCEL] = "linearaccel",
 };
 
 static const char * const iio_modifier_names[] = {
diff --git a/include/uapi/linux/iio/types.h b/include/uapi/linux/iio/types.h
index d3f7ba7..d6df101 100644
--- a/include/uapi/linux/iio/types.h
+++ b/include/uapi/linux/iio/types.h
@@ -41,6 +41,7 @@ enum iio_chan_type {
 	IIO_UVINDEX,
 	IIO_ELECTRICALCONDUCTIVITY,
 	IIO_GRAVITY,
+	IIO_LINEAR_ACCEL,
 };
 
 enum iio_modifier {
diff --git a/tools/iio/iio_event_monitor.c b/tools/iio/iio_event_monitor.c
index b61245e..116644a 100644
--- a/tools/iio/iio_event_monitor.c
+++ b/tools/iio/iio_event_monitor.c
@@ -58,6 +58,7 @@
 	[IIO_PH] = "ph",
 	[IIO_UVINDEX] = "uvindex",
 	[IIO_GRAVITY] = "gravity",
+	[IIO_LINEAR_ACCEL] = "linearaccel",
 };
 
 static const char * const iio_ev_type_text[] = {
@@ -151,6 +152,7 @@ static bool event_is_known(struct iio_event_data *event)
 	case IIO_PH:
 	case IIO_UVINDEX:
 	case IIO_GRAVITY:
+	case IIO_LINEAR_ACCEL:
 		break;
 	default:
 		return false;
-- 
1.9.1

[PATCH 1/2] iio: Add support for linear accel

[Song Hongyan]

Add new channel types support for linear accel sensor.

Linear acceleration differs from a standard accelerometor,
its value depends on standard accel sensor and gravity sensor.
Conceptually, this three sensors have following relationship:
linear acceleration = acceleration - acceleration due to gravity

At rest, standard accelerometer displays 1g due to earth’s
gravitational pull while a liner accelerometer will show 0g.

More information can be found in:
http://www.usb.org/developers/hidpage/HUTRR59_-_Usages_for_Wearables.pdf

Signed-off-by: Song Hongyan <hongyan.song@intel.com>
---
 Documentation/ABI/testing/sysfs-bus-iio | 10 ++++++++++
 drivers/iio/industrialio-core.c         |  1 +
 include/uapi/linux/iio/types.h          |  1 +
 tools/iio/iio_event_monitor.c           |  2 ++
 4 files changed, 14 insertions(+)

diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
index 60b7406..8091f3d 100644
--- a/Documentation/ABI/testing/sysfs-bus-iio
+++ b/Documentation/ABI/testing/sysfs-bus-iio
@@ -170,6 +170,16 @@ Description:
 		Has all of the equivalent parameters as per voltageY. Units
 		after application of scale and offset are m/s^2.
 
+What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_x_raw
+What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_y_raw
+What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_z_raw
+KernelVersion:	4.11
+Contact:	linux-iio@vger.kernel.org
+Description:
+		Linear Acceleration in direction x, y or z (may be arbitrarily assigned
+		but should match other such assignments on device).
+		Has all of the equivalent parameters as per voltageY. Units
+		after application of scale and offset are m/s^2.
 
 What:		/sys/bus/iio/devices/iio:deviceX/in_gravity_x_raw
 What:		/sys/bus/iio/devices/iio:deviceX/in_gravity_y_raw
diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
index 72fc96a..da78c26 100644
--- a/drivers/iio/industrialio-core.c
+++ b/drivers/iio/industrialio-core.c
@@ -82,6 +82,7 @@ struct bus_type iio_bus_type = {
 	[IIO_UVINDEX] = "uvindex",
 	[IIO_ELECTRICALCONDUCTIVITY] = "electricalconductivity",
 	[IIO_GRAVITY]  = "gravity",
+	[IIO_LINEAR_ACCEL] = "linearaccel",
 };
 
 static const char * const iio_modifier_names[] = {
diff --git a/include/uapi/linux/iio/types.h b/include/uapi/linux/iio/types.h
index d3f7ba7..d6df101 100644
--- a/include/uapi/linux/iio/types.h
+++ b/include/uapi/linux/iio/types.h
@@ -41,6 +41,7 @@ enum iio_chan_type {
 	IIO_UVINDEX,
 	IIO_ELECTRICALCONDUCTIVITY,
 	IIO_GRAVITY,
+	IIO_LINEAR_ACCEL,
 };
 
 enum iio_modifier {
diff --git a/tools/iio/iio_event_monitor.c b/tools/iio/iio_event_monitor.c
index b61245e..116644a 100644
--- a/tools/iio/iio_event_monitor.c
+++ b/tools/iio/iio_event_monitor.c
@@ -58,6 +58,7 @@
 	[IIO_PH] = "ph",
 	[IIO_UVINDEX] = "uvindex",
 	[IIO_GRAVITY] = "gravity",
+	[IIO_LINEAR_ACCEL] = "linearaccel",
 };
 
 static const char * const iio_ev_type_text[] = {
@@ -151,6 +152,7 @@ static bool event_is_known(struct iio_event_data *event)
 	case IIO_PH:
 	case IIO_UVINDEX:
 	case IIO_GRAVITY:
+	case IIO_LINEAR_ACCEL:
 		break;
 	default:
 		return false;
-- 
1.9.1

[PATCH 2/2] iio: Add linear accel sensor hid support

[Song Hongyan]

Linear acceleration is a soft sensor it differs from a standard
accel sensor, it provides a three-dimensional vector representing
acceleration along each device axis, excluding gravity.
The sensor data is derives from standard accelerometer device
by filtering out the acceleration which is caused by the force
of Earth’s gravity.

The value can be used to perform gesture detection, it can also
serve as input to an inertial navigation system, which uses
dead reckoning.

More information can be found in:
http://www.usb.org/developers/hidpage/HUTRR59_-_Usages_for_Wearables.pdf

Linear accel sensor, gravity sensor and accelerometer have similar
channels and share channel usage ids. So the most of the code for
accel_3d can be reused.

Signed-off-by: Song Hongyan <hongyan.song-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 drivers/iio/accel/hid-sensor-accel-3d.c | 42 +++++++++++++++++++++++++++++++++
 include/linux/hid-sensor-ids.h          |  3 +++
 2 files changed, 45 insertions(+)

diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c b/drivers/iio/accel/hid-sensor-accel-3d.c
index 9edd574..6ce460f 100644
--- a/drivers/iio/accel/hid-sensor-accel-3d.c
+++ b/drivers/iio/accel/hid-sensor-accel-3d.c
@@ -91,6 +91,41 @@ struct accel_3d_state {
 };
 
 /* Channel definitions */
+static const struct iio_chan_spec linear_accel_3d_channels[] = {
+	{
+		.type = IIO_LINEAR_ACCEL,
+		.modified = 1,
+		.channel2 = IIO_MOD_X,
+		.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
+		.info_mask_shared_by_type = BIT(IIO_CHAN_INFO_OFFSET) |
+		BIT(IIO_CHAN_INFO_SCALE) |
+		BIT(IIO_CHAN_INFO_SAMP_FREQ) |
+		BIT(IIO_CHAN_INFO_HYSTERESIS),
+		.scan_index = CHANNEL_SCAN_INDEX_X,
+	}, {
+		.type = IIO_LINEAR_ACCEL,
+		.modified = 1,
+		.channel2 = IIO_MOD_Y,
+		.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
+		.info_mask_shared_by_type = BIT(IIO_CHAN_INFO_OFFSET) |
+		BIT(IIO_CHAN_INFO_SCALE) |
+		BIT(IIO_CHAN_INFO_SAMP_FREQ) |
+		BIT(IIO_CHAN_INFO_HYSTERESIS),
+		.scan_index = CHANNEL_SCAN_INDEX_Y,
+	}, {
+		.type = IIO_LINEAR_ACCEL,
+		.modified = 1,
+		.channel2 = IIO_MOD_Z,
+		.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
+		.info_mask_shared_by_type = BIT(IIO_CHAN_INFO_OFFSET) |
+		BIT(IIO_CHAN_INFO_SCALE) |
+		BIT(IIO_CHAN_INFO_SAMP_FREQ) |
+		BIT(IIO_CHAN_INFO_HYSTERESIS),
+		.scan_index = CHANNEL_SCAN_INDEX_Z,
+	}
+};
+
+/* Channel definitions */
 static const struct iio_chan_spec gravity_channels[] = {
 	{
 		.type = IIO_GRAVITY,
@@ -354,6 +389,10 @@ static int hid_accel_3d_probe(struct platform_device *pdev)
 		name = "accel_3d";
 		channel_spec = accel_3d_channels;
 		channel_size = sizeof(accel_3d_channels);
+	} else if (hsdev->usage == HID_USAGE_SENSOR_LINEAR_ACCEL_3D) {
+		name = "linear_accel_3d";
+		channel_spec = linear_accel_3d_channels;
+		channel_size = sizeof(linear_accel_3d_channels);
 	} else {
 		name = "gravity";
 		channel_spec = gravity_channels;
@@ -452,6 +491,9 @@ static int hid_accel_3d_remove(struct platform_device *pdev)
 	{	/* gravity sensor */
 		.name = "HID-SENSOR-20007b",
 	},
+	{	/* linear_accel sensor */
+		.name = "HID-SENSOR-20007c",
+	},
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(platform, hid_accel_3d_ids);
diff --git a/include/linux/hid-sensor-ids.h b/include/linux/hid-sensor-ids.h
index b6778fd2..b0b26a0 100644
--- a/include/linux/hid-sensor-ids.h
+++ b/include/linux/hid-sensor-ids.h
@@ -55,6 +55,9 @@
 /* Gravity vector */
 #define HID_USAGE_SENSOR_GRAVITY_VECTOR				0x20007B
 
+/* linear accel */
+#define HID_USAGE_SENSOR_LINEAR_ACCEL_3D			0x20007C
+
 /* ORIENTATION: Compass 3D: (200083) */
 #define HID_USAGE_SENSOR_COMPASS_3D				0x200083
 #define HID_USAGE_SENSOR_DATA_ORIENTATION			0x200470
-- 
1.9.1

[PATCH 2/2] iio: Add linear accel sensor hid support

[Song Hongyan]

Linear acceleration is a soft sensor it differs from a standard
accel sensor, it provides a three-dimensional vector representing
acceleration along each device axis, excluding gravity.
The sensor data is derives from standard accelerometer device
by filtering out the acceleration which is caused by the force
of Earth’s gravity.

The value can be used to perform gesture detection, it can also
serve as input to an inertial navigation system, which uses
dead reckoning.

More information can be found in:
http://www.usb.org/developers/hidpage/HUTRR59_-_Usages_for_Wearables.pdf

Linear accel sensor, gravity sensor and accelerometer have similar
channels and share channel usage ids. So the most of the code for
accel_3d can be reused.

Signed-off-by: Song Hongyan <hongyan.song@intel.com>
---
 drivers/iio/accel/hid-sensor-accel-3d.c | 42 +++++++++++++++++++++++++++++++++
 include/linux/hid-sensor-ids.h          |  3 +++
 2 files changed, 45 insertions(+)

diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c b/drivers/iio/accel/hid-sensor-accel-3d.c
index 9edd574..6ce460f 100644
--- a/drivers/iio/accel/hid-sensor-accel-3d.c
+++ b/drivers/iio/accel/hid-sensor-accel-3d.c
@@ -91,6 +91,41 @@ struct accel_3d_state {
 };
 
 /* Channel definitions */
+static const struct iio_chan_spec linear_accel_3d_channels[] = {
+	{
+		.type = IIO_LINEAR_ACCEL,
+		.modified = 1,
+		.channel2 = IIO_MOD_X,
+		.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
+		.info_mask_shared_by_type = BIT(IIO_CHAN_INFO_OFFSET) |
+		BIT(IIO_CHAN_INFO_SCALE) |
+		BIT(IIO_CHAN_INFO_SAMP_FREQ) |
+		BIT(IIO_CHAN_INFO_HYSTERESIS),
+		.scan_index = CHANNEL_SCAN_INDEX_X,
+	}, {
+		.type = IIO_LINEAR_ACCEL,
+		.modified = 1,
+		.channel2 = IIO_MOD_Y,
+		.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
+		.info_mask_shared_by_type = BIT(IIO_CHAN_INFO_OFFSET) |
+		BIT(IIO_CHAN_INFO_SCALE) |
+		BIT(IIO_CHAN_INFO_SAMP_FREQ) |
+		BIT(IIO_CHAN_INFO_HYSTERESIS),
+		.scan_index = CHANNEL_SCAN_INDEX_Y,
+	}, {
+		.type = IIO_LINEAR_ACCEL,
+		.modified = 1,
+		.channel2 = IIO_MOD_Z,
+		.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
+		.info_mask_shared_by_type = BIT(IIO_CHAN_INFO_OFFSET) |
+		BIT(IIO_CHAN_INFO_SCALE) |
+		BIT(IIO_CHAN_INFO_SAMP_FREQ) |
+		BIT(IIO_CHAN_INFO_HYSTERESIS),
+		.scan_index = CHANNEL_SCAN_INDEX_Z,
+	}
+};
+
+/* Channel definitions */
 static const struct iio_chan_spec gravity_channels[] = {
 	{
 		.type = IIO_GRAVITY,
@@ -354,6 +389,10 @@ static int hid_accel_3d_probe(struct platform_device *pdev)
 		name = "accel_3d";
 		channel_spec = accel_3d_channels;
 		channel_size = sizeof(accel_3d_channels);
+	} else if (hsdev->usage == HID_USAGE_SENSOR_LINEAR_ACCEL_3D) {
+		name = "linear_accel_3d";
+		channel_spec = linear_accel_3d_channels;
+		channel_size = sizeof(linear_accel_3d_channels);
 	} else {
 		name = "gravity";
 		channel_spec = gravity_channels;
@@ -452,6 +491,9 @@ static int hid_accel_3d_remove(struct platform_device *pdev)
 	{	/* gravity sensor */
 		.name = "HID-SENSOR-20007b",
 	},
+	{	/* linear_accel sensor */
+		.name = "HID-SENSOR-20007c",
+	},
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(platform, hid_accel_3d_ids);
diff --git a/include/linux/hid-sensor-ids.h b/include/linux/hid-sensor-ids.h
index b6778fd2..b0b26a0 100644
--- a/include/linux/hid-sensor-ids.h
+++ b/include/linux/hid-sensor-ids.h
@@ -55,6 +55,9 @@
 /* Gravity vector */
 #define HID_USAGE_SENSOR_GRAVITY_VECTOR				0x20007B
 
+/* linear accel */
+#define HID_USAGE_SENSOR_LINEAR_ACCEL_3D			0x20007C
+
 /* ORIENTATION: Compass 3D: (200083) */
 #define HID_USAGE_SENSOR_COMPASS_3D				0x200083
 #define HID_USAGE_SENSOR_DATA_ORIENTATION			0x200470
-- 
1.9.1

RE: [PATCH 1/2] iio: Add support for linear accel

[Song, Hongyan]

Hi Lars & Peter,

-----Original Message-----
From: Lars-Peter Clausen [mailto:lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org] 
Sent: Tuesday, January 3, 2017 5:49 PM
To: Peter Meerwald-Stadler <pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>; Song, Hongyan <hongyan.song-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; jikos-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; Pandruvada, Srinivas <srinivas.pandruvada-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 1/2] iio: Add support for linear accel

On 01/03/2017 09:04 AM, Peter Meerwald-Stadler wrote:
> Hi,
> 
>> 	 I checked and find that iio device name is usually named to be with underline if it has more than one word, so I assigned to be " linear_accel_3d".
>>  I think the device property node named to be "in_linear_accel_x_raw" is better than " in_linearaccel_x_raw" Just follow the former coding style.
>> "linearaccel" is only a name which specify IIO type 
>> [IIO_LINEAR_ACCEL] I name [IIO_LINEAR_ACCEL] to be "linearaccel" just follow the history code style in " iio_chan_type_name_spec[]" which do not have any underline.
> 
>>> +What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_x_raw
>>> +What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_y_raw
>>> +What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_z_raw
>>
>> I think this would be in_linearaccel_x_raw, etc.?
> 
>>> @@ -82,6 +82,7 @@ struct bus_type iio_bus_type = {
>>>  	[IIO_UVINDEX] = "uvindex",
>>>  	[IIO_ELECTRICALCONDUCTIVITY] = "electricalconductivity",
>>>  	[IIO_GRAVITY]  = "gravity",
>>> +	[IIO_LINEAR_ACCEL] = "linearaccel",
>>>  };
> 
> 
> >linearaccel vs. linear_accel is a matter of taste, I have no 
> >preference; nevertheless, the documentation should match what IIO 
>> outputs

>We use underscores as the field separator in the channel name. Having a underscore as part of a field adds ambiguity and makes it a lot  >
>harder to machine parse it. It's already complicated enough as it is. We should avoid adding types with underscores in them.

Thanks for your advice, I will update the patch.

BR
Song Hongyan

RE: [PATCH 1/2] iio: Add support for linear accel

[Song, Hongyan]

Hi Lars & Peter,

-----Original Message-----
From: Lars-Peter Clausen [mailto:lars@metafoo.de]=20
Sent: Tuesday, January 3, 2017 5:49 PM
To: Peter Meerwald-Stadler <pmeerw@pmeerw.net>; Song, Hongyan <hongyan.song=
@intel.com>
Cc: linux-input@vger.kernel.org; linux-iio@vger.kernel.org; jikos@kernel.or=
g; jic23@kernel.org; Pandruvada, Srinivas <srinivas.pandruvada@intel.com>
Subject: Re: [PATCH 1/2] iio: Add support for linear accel

On 01/03/2017 09:04 AM, Peter Meerwald-Stadler wrote:
> Hi,
>=20
>> 	 I checked and find that iio device name is usually named to be with un=
derline if it has more than one word, so I assigned to be " linear_accel_3d=
".
>>  I think the device property node named to be "in_linear_accel_x_raw" is=
 better than " in_linearaccel_x_raw" Just follow the former coding style.
>> "linearaccel" is only a name which specify IIO type=20
>> [IIO_LINEAR_ACCEL] I name [IIO_LINEAR_ACCEL] to be "linearaccel" just fo=
llow the history code style in " iio_chan_type_name_spec[]" which do not ha=
ve any underline.
>=20
>>> +What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_x_raw
>>> +What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_y_raw
>>> +What:		/sys/bus/iio/devices/iio:deviceX/in_linear_accel_z_raw
>>
>> I think this would be in_linearaccel_x_raw, etc.?
>=20
>>> @@ -82,6 +82,7 @@ struct bus_type iio_bus_type =3D {
>>>  	[IIO_UVINDEX] =3D "uvindex",
>>>  	[IIO_ELECTRICALCONDUCTIVITY] =3D "electricalconductivity",
>>>  	[IIO_GRAVITY]  =3D "gravity",
>>> +	[IIO_LINEAR_ACCEL] =3D "linearaccel",
>>>  };
>=20
>=20
> >linearaccel vs. linear_accel is a matter of taste, I have no=20
> >preference; nevertheless, the documentation should match what IIO=20
>> outputs

>We use underscores as the field separator in the channel name. Having a un=
derscore as part of a field adds ambiguity and makes it a lot  >
>harder to machine parse it. It's already complicated enough as it is. We s=
hould avoid adding types with underscores in them.

Thanks for your advice, I will update the patch.

BR
Song Hongyan