From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964997AbdACQVE (ORCPT ); Tue, 3 Jan 2017 11:21:04 -0500 Received: from mail-pg0-f41.google.com ([74.125.83.41]:34969 "EHLO mail-pg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759014AbdACQUI (ORCPT ); Tue, 3 Jan 2017 11:20:08 -0500 From: Max Bires To: gregkh@linuxfoundation.org Cc: arnd@arndb.de, josh@joshtriplett.org, linux-kernel@vger.kernel.org, geert@linux-m68k.org, Max Bires Subject: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Date: Tue, 3 Jan 2017 08:18:07 -0800 Message-Id: <1483460287-88892-1-git-send-email-jbires@google.com> X-Mailer: git-send-email 2.8.0.rc3.226.g39d4020 In-Reply-To: <1483453593-67987-1-git-send-email-jbires@google.com> References: <1483453593-67987-1-git-send-email-jbires@google.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This esnured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if it's not being used. Adding a message here in order to make this user visible. Signed-off-by: Max Bires Acked-by: Arnd Bergmann --- drivers/char/Kconfig | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig index fde005e..4ee2a10 100644 --- a/drivers/char/Kconfig +++ b/drivers/char/Kconfig @@ -571,9 +571,12 @@ config TELCLOCK controlling the behavior of this hardware. config DEVPORT - bool + bool "/dev/port character device" depends on ISA || PCI default y + help + Say Y here if you want to support the /dev/port device. The /dev/port + device is similar to /dev/mem, but for I/O ports. source "drivers/s390/char/Kconfig" -- 2.8.0.rc3.226.g39d4020