All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "Malinen, Jouni" <jouni@qca.qualcomm.com>
Cc: Arend Van Spriel <arend.vanspriel@broadcom.com>,
	"Vamsi, Krishna" <vamsin@qti.qualcomm.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] cfg80211: Add support to sched scan to report better BSSs
Date: Wed, 04 Jan 2017 14:34:27 +0100	[thread overview]
Message-ID: <1483536867.7312.9.camel@sipsolutions.net> (raw)
In-Reply-To: <20161220205221.GB9756@jouni.qca.qualcomm.com>

On Tue, 2016-12-20 at 20:52 +0000, Malinen, Jouni wrote:

> > I think between that (unless we add that, we could technically
> > extend flag attributes to allow them being an int as well, or add a
> > new one) and the fact that the device may not support different
> > relative RSSI matches in different matchsets, I'm almost convinced
> > that adding new attributes is better.
> 
> I'm not completely sure how to interpret all this and also the last
> email from Arend in this thread. Could either (or both :) of you
> providemore detailed suggestion on what exactly you would like us to 
> change, if anything, in the attribute design now so that we can try
> to close on this?

I guess I'm thinking out loud too much :-)

Moving to the (band,adjustment) struct thing, like we have it in the
BSS select now, would be good I think - instead of the single value
that has the band hardcoded in the name. It's fairly useless with just
two bands since you can adjust one or the other to achieve the same
result, but for consistency it'd be good.

And then doing a match attribute we more or less discarded here, so
conceptually nothing else really changes.

johannes

  parent reply	other threads:[~2017-01-04 13:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-02 21:59 [PATCH v2 1/2] nl80211: Use different attrs for BSSID and random MAC addr in scan req Jouni Malinen
2016-12-02 21:59 ` [PATCH v2 2/2] cfg80211: Add support to sched scan to report better BSSs Jouni Malinen
2016-12-07  9:25   ` Johannes Berg
2016-12-07  9:33     ` Vamsi, Krishna
2016-12-07 20:03       ` Arend Van Spriel
2016-12-08 17:52         ` Malinen, Jouni
2016-12-08 20:35           ` Arend Van Spriel
2016-12-13 15:56             ` Johannes Berg
2016-12-15 11:06               ` Malinen, Jouni
2016-12-16  9:56                 ` Johannes Berg
2016-12-20 20:52                   ` Malinen, Jouni
2016-12-21  9:18                     ` Arend Van Spriel
2017-01-04 13:32                       ` Johannes Berg
2017-01-04 13:34                     ` Johannes Berg [this message]
2016-12-07 20:11   ` Arend Van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1483536867.7312.9.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=arend.vanspriel@broadcom.com \
    --cc=jouni@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=vamsin@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.