From: Mike Crowe <mac@mcrowe.com>
To: linux-mtd@lists.infradead.org
Cc: Mike Crowe <mac@mcrowe.com>
Subject: [PATCH 1/2] nandwrite: Add --skip-bad-blocks-to-start option
Date: Wed, 4 Jan 2017 14:18:05 +0000 [thread overview]
Message-ID: <1483539486-16165-2-git-send-email-mac@mcrowe.com> (raw)
In-Reply-To: <1483539486-16165-1-git-send-email-mac@mcrowe.com>
The --skip-bad-blocks-to-start option will increase the seek offset by the
size of each bad block encountered between the start of the partition and
the specified start address.
This can be useful when writing part way through a partition that will be
read using a simple bad-block-skipping algorithm.
---
nand-utils/nandwrite.c | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/nand-utils/nandwrite.c b/nand-utils/nandwrite.c
index 9602a6e..880990f 100644
--- a/nand-utils/nandwrite.c
+++ b/nand-utils/nandwrite.c
@@ -56,6 +56,8 @@ static void display_help(int status)
" -o, --oob Input contains oob data\n"
" -O, --onlyoob Input contains oob data and only write the oob part\n"
" -s addr, --start=addr Set output start address (default is 0)\n"
+" --skip-bad-blocks-to-start"
+" Skip bad blocks when seeking to the start address\n"
" -p, --pad Pad writes to page size\n"
" -b, --blockalign=1|2|4 Set multiple of eraseblocks to align to\n"
" --input-skip=length Skip |length| bytes of the input file\n"
@@ -96,6 +98,7 @@ static bool autoplace = false;
static bool skipallffs = false;
static bool noskipbad = false;
static bool pad = false;
+static bool skip_bad_blocks_to_start = false;
static int blockalign = 1; /* default to using actual block size */
static void process_options(int argc, char * const argv[])
@@ -110,6 +113,7 @@ static void process_options(int argc, char * const argv[])
{"version", no_argument, 0, 'V'},
{"input-skip", required_argument, 0, 0},
{"input-size", required_argument, 0, 0},
+ {"skip-bad-blocks-to-start", no_argument, 0, 0},
{"help", no_argument, 0, 'h'},
{"blockalign", required_argument, 0, 'b'},
{"markbad", no_argument, 0, 'm'},
@@ -139,6 +143,9 @@ static void process_options(int argc, char * const argv[])
case 2: /* --input-size */
inputsize = simple_strtoll(optarg, &error);
break;
+ case 3: /* --skip-bad-blocks-to-start */
+ skip_bad_blocks_to_start = true;
+ break;
}
break;
case 'V':
@@ -349,6 +356,25 @@ int main(int argc, char * const argv[])
goto closeall;
}
+ /* Skip bad blocks on the way to the start address if necessary */
+ if (skip_bad_blocks_to_start) {
+ unsigned long long bbs_offset = 0;
+ while (bbs_offset < mtdoffset) {
+ ret = mtd_is_bad(&mtd, fd, bbs_offset / ebsize_aligned);
+ if (ret < 0) {
+ sys_errmsg("%s: MTD get bad block failed", mtd_device);
+ goto closeall;
+ } else if (ret == 1) {
+ if (!quiet)
+ fprintf(stderr, "Bad block at %llx, %u block(s) "
+ "from %llx will be skipped\n",
+ bbs_offset, blockalign, bbs_offset);
+ mtdoffset += ebsize_aligned;
+ }
+ bbs_offset += ebsize_aligned;
+ }
+ }
+
/* Check, if length fits into device */
if ((imglen / pagelen) * mtd.min_io_size > mtd.size - mtdoffset) {
fprintf(stderr, "Image %lld bytes, NAND page %d bytes, OOB area %d"
--
2.1.4
next prev parent reply other threads:[~2017-01-04 14:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 14:18 [PATCH 0/2] Support skipping bad blocks when seeking to start address Mike Crowe
2017-01-04 14:18 ` Mike Crowe [this message]
2017-01-04 14:18 ` [PATCH 2/2] nanddump: Add --skip-bad-blocks-to-start option Mike Crowe
2017-01-05 13:38 ` [PATCH 0/2] Support skipping bad blocks when seeking to start address goliath
2017-01-05 14:18 ` Mike Crowe
2017-01-05 14:48 ` Boris Brezillon
2017-01-05 15:04 ` Mike Crowe
2017-01-09 12:18 ` David Oberhollenzer
2017-01-09 14:51 ` Mike Crowe
2017-01-11 16:22 ` Mike Crowe
2017-01-17 11:54 Mike Crowe
2017-01-17 11:54 ` [PATCH 1/2] nandwrite: Add --skip-bad-blocks-to-start option Mike Crowe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483539486-16165-2-git-send-email-mac@mcrowe.com \
--to=mac@mcrowe.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.