From: Marcel Apfelbaum <marcel@redhat.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com, marcel@redhat.com, yvugenfi@redhat.com
Subject: [Qemu-devel] [PATCH 2/4] hw/virtio: fix error enabling flags in Device Control register
Date: Wed, 4 Jan 2017 21:57:16 +0200 [thread overview]
Message-ID: <1483559838-8797-3-git-send-email-marcel@redhat.com> (raw)
In-Reply-To: <1483559838-8797-1-git-send-email-marcel@redhat.com>
When the virtio devices are PCI Express, make error-enabling flags
writable to respect the PCIe spec.
Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
---
hw/virtio/virtio-pci.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index 21c2b9d..da2124f 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
@@ -1802,6 +1802,8 @@ static void virtio_pci_realize(PCIDevice *pci_dev, Error **errp)
* PCI Power Management Interface Specification.
*/
pci_set_word(pci_dev->config + pos + PCI_PM_PMC, 0x3);
+ /* Init error enabling flags */
+ pcie_cap_deverr_init(pci_dev);
} else {
/*
* make future invocations of pci_is_express() return false
@@ -1828,6 +1830,7 @@ static void virtio_pci_reset(DeviceState *qdev)
{
VirtIOPCIProxy *proxy = VIRTIO_PCI(qdev);
VirtioBusState *bus = VIRTIO_BUS(&proxy->bus);
+ PCIDevice *dev = PCI_DEVICE(qdev);
int i;
virtio_pci_stop_ioeventfd(proxy);
@@ -1837,6 +1840,10 @@ static void virtio_pci_reset(DeviceState *qdev)
for (i = 0; i < VIRTIO_QUEUE_MAX; i++) {
proxy->vqs[i].enabled = 0;
}
+
+ if (pci_is_express(dev)) {
+ pcie_cap_deverr_reset(dev);
+ }
}
static Property virtio_pci_properties[] = {
--
2.5.5
next prev parent reply other threads:[~2017-01-04 19:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 19:57 [Qemu-devel] [PATCH 0/4] hw/virtio: fix several PCI Express compliance issues Marcel Apfelbaum
2017-01-04 19:57 ` [Qemu-devel] [PATCH 1/4] hw/pcie: fix Extended Configuration Space for devices with no Extended Capabilities Marcel Apfelbaum
2017-01-10 3:13 ` Michael S. Tsirkin
2017-01-27 16:12 ` Marcel Apfelbaum
2017-01-04 19:57 ` Marcel Apfelbaum [this message]
2017-01-10 3:07 ` [Qemu-devel] [PATCH 2/4] hw/virtio: fix error enabling flags in Device Control register Michael S. Tsirkin
2017-01-27 16:07 ` Marcel Apfelbaum
2017-01-04 19:57 ` [Qemu-devel] [PATCH 3/4] hw/virtio: fix Link Control Register for PCI Express virtio devices Marcel Apfelbaum
2017-01-10 3:07 ` Michael S. Tsirkin
2017-01-04 19:57 ` [Qemu-devel] [PATCH 4/4] hw/virtio: fix Power Management " Marcel Apfelbaum
2017-01-10 3:07 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483559838-8797-3-git-send-email-marcel@redhat.com \
--to=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yvugenfi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.