Re: [Qemu-devel] [PATCH 0/6] CAN bus support for QEMU (SJA1000 PCI so far)

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Message-id: cover.1483655893.git.pisa@cmp.felk.cvut.cz
Subject: [Qemu-devel] [PATCH 0/6] CAN bus support for QEMU (SJA1000 PCI so far)
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/cover.1483655893.git.pisa@cmp.felk.cvut.cz -> patchew/cover.1483655893.git.pisa@cmp.felk.cvut.cz
Switched to a new branch 'test'
e262272 CAN bus MIOe-3680 PCI (dual SJA1000 channel) emulation added.
4c15cb0 Minor clean-up of can_pcm3680_pci.
e30986a Fixed IRQ problem for CAN device can_pcm3680_pci.
aa7b853 CAN bus PCM-3680I PCI (dual SJA1000 channel) emulation added.
d264f8a CAN bus Kvaser PCI CAN-S (single SJA1000 channel) emulation added.
4e0a159 CAN bus simple SJA1000 PCI card emulation for QEMU

=== OUTPUT BEGIN ===
Checking PATCH 1/6: CAN bus simple SJA1000 PCI card emulation for QEMU...
WARNING: architecture specific defines should be avoided
#99: FILE: hw/can/can_core.c:34:
+#ifdef __linux__

WARNING: line over 80 characters
#121: FILE: hw/can/can_core.c:56:
+static QTAILQ_HEAD(, CanBusState) can_buses = QTAILQ_HEAD_INITIALIZER(can_buses);

WARNING: architecture specific defines should be avoided
#217: FILE: hw/can/can_core.c:152:
+#ifdef __linux__

WARNING: line over 80 characters
#239: FILE: hw/can/can_core.c:174:
+    CanBusHostConnectState *c = container_of(client, CanBusHostConnectState, bus_client);

WARNING: line over 80 characters
#251: FILE: hw/can/can_core.c:186:
+    CanBusHostConnectState *c = container_of(client, CanBusHostConnectState, bus_client);

WARNING: line over 80 characters
#277: FILE: hw/can/can_core.c:212:
+    CanBusHostConnectState *c = container_of(client, CanBusHostConnectState, bus_client);

ERROR: line over 90 characters
#286: FILE: hw/can/can_core.c:221:
+int can_bus_host_set_filters(CanBusClientState *, const struct qemu_can_filter *filters, size_t filters_cnt);

ERROR: externs should be avoided in .c files
#286: FILE: hw/can/can_core.c:221:
+int can_bus_host_set_filters(CanBusClientState *, const struct qemu_can_filter *filters, size_t filters_cnt);

ERROR: line over 90 characters
#288: FILE: hw/can/can_core.c:223:
+int can_bus_host_set_filters(CanBusClientState *client, const struct qemu_can_filter *filters, size_t filters_cnt)

WARNING: line over 80 characters
#290: FILE: hw/can/can_core.c:225:
+    CanBusHostConnectState *c = container_of(client, CanBusHostConnectState, bus_client);

ERROR: line over 90 characters
#302: FILE: hw/can/can_core.c:237:
+        printf("[%i]  id=0x%08x maks=0x%08x\n", i, filters[i].can_id, filters[i].can_mask);

WARNING: line over 80 characters
#361: FILE: hw/can/can_core.c:296:
+    c->rfilter[0].can_id = 0; /* Receive all data frame. If |= CAN_INV_FILTER no data. */

ERROR: Error messages should not contain newlines
#394: FILE: hw/can/can_core.c:329:
+        error_report("CAN bus setup of host connect to \"%s\" failed\n",

ERROR: Error messages should not contain newlines
#400: FILE: hw/can/can_core.c:335:
+        error_report("CAN host device \"%s\" connect to bus \"%s\" failed\n",

WARNING: line over 80 characters
#411: FILE: hw/can/can_core.c:346:
+    error_report("CAN bus connect to host device not supported on this system\n");

ERROR: Error messages should not contain newlines
#411: FILE: hw/can/can_core.c:346:
+    error_report("CAN bus connect to host device not supported on this system\n");

ERROR: Error messages should not contain newlines
#545: FILE: hw/can/can_pci.c:125:
+                         "the model %s is not supported now.\n", d->model);

ERROR: Error messages should not contain newlines
#552: FILE: hw/can/can_pci.c:132:
+        error_report("Cannot create can find/allocate CAN bus\n");

WARNING: line over 80 characters
#559: FILE: hw/can/can_pci.c:139:
+            error_report("Cannot connect CAN bus to host device \"%s\"\n", d->host);

ERROR: Error messages should not contain newlines
#559: FILE: hw/can/can_pci.c:139:
+            error_report("Cannot connect CAN bus to host device \"%s\"\n", d->host);

ERROR: Error messages should not contain newlines
#574: FILE: hw/can/can_pci.c:154:
+        error_report("can_sja_connect_to_bus failed\n");

WARNING: line over 80 characters
#581: FILE: hw/can/can_pci.c:161:
+    pci_register_bar(pci_dev, /*BAR*/ 0, PCI_BASE_ADDRESS_SPACE_MEMORY, &d->sja_mmio);

WARNING: line over 80 characters
#610: FILE: hw/can/can_pci.c:190:
+        VMSTATE_STRUCT(sja_state, CanPCIState, 0, vmstate_can_sja, CanSJA1000State),

ERROR: do not use C99 // comments
#699: FILE: hw/can/can_sja1000.c:34:
+//#define DEBUG_FILTER

WARNING: line over 80 characters
#733: FILE: hw/can/can_sja1000.c:68:
+static int can_sja_accept_filter(CanSJA1000State *s, const qemu_can_frame *frame)

ERROR: spaces required around that '+' (ctx:VxV)
#831: FILE: hw/can/can_sja1000.c:166:
+            frame->data[i] = buff[5+i];
                                    ^

ERROR: spaces required around that '+' (ctx:VxV)
#840: FILE: hw/can/can_sja1000.c:175:
+            frame->data[i] = buff[3+i];
                                    ^

ERROR: spaces required around that '+' (ctx:VxV)
#860: FILE: hw/can/can_sja1000.c:195:
+        frame->data[i] = buff[2+i];
                                ^

WARNING: line over 80 characters
#893: FILE: hw/can/can_sja1000.c:228:
+        buff[++count] = (frame->can_id << 05) & 0xe0; /* ID.02~ID.00,x,x,x,x,x */

WARNING: line over 80 characters
#936: FILE: hw/can/can_sja1000.c:271:
+void can_sja_mem_write(CanSJA1000State *s, hwaddr addr, uint64_t val, unsigned size)

WARNING: line over 80 characters
#943: FILE: hw/can/can_sja1000.c:278:
+    DPRINTF("write 0x%02llx addr 0x%02x\n", (unsigned long long)val, (unsigned int)addr);

WARNING: line over 80 characters
#1068: FILE: hw/can/can_sja1000.c:403:
+                s->statusP &= ~(3 << 2); /* Clear transmission complete status, */

WARNING: line over 80 characters
#1171: FILE: hw/can/can_sja1000.c:506:
+                s->statusB &= ~(3 << 2); /* Clear transmission complete status, */

WARNING: line over 80 characters
#1193: FILE: hw/can/can_sja1000.c:528:
+                    printf(" %02X", s->rx_buff[(s->rxbuf_start + i) % SJA_RCV_BUF_LEN]);

WARNING: line over 80 characters
#1287: FILE: hw/can/can_sja1000.c:622:
+        case 8: /* Output control register, hardware related, not support now. */

WARNING: line over 80 characters
#1318: FILE: hw/can/can_sja1000.c:653:
+                temp = s->rx_buff[(s->rxbuf_start + addr - 16) % SJA_RCV_BUF_LEN];

ERROR: line over 90 characters
#1376: FILE: hw/can/can_sja1000.c:711:
+    DPRINTF("     %d bytes of 0x%lx from addr %d\n", size, (long unsigned int)temp, (int)addr);

ERROR: line over 90 characters
#1398: FILE: hw/can/can_sja1000.c:733:
+ssize_t can_sja_receive(CanBusClientState *client, const qemu_can_frame *frames, size_t frames_cnt)

ERROR: line over 90 characters
#1493: FILE: hw/can/can_sja1000.c:828:
+        printf("RCV B ret=%2d, ptr=%2d cnt=%2d msg=%2d\n", ret, s->rx_ptr, s->rx_cnt, s->rxmsg_cnt);

ERROR: do not use C99 // comments
#1653: FILE: hw/can/can_sja1000.h:39:
+//#define DEBUG_CAN

WARNING: line over 80 characters
#1670: FILE: hw/can/can_sja1000.h:56:
+    uint8_t         interrupt_en;  /* PeliCAN, addr 4, Interrupt Enable register */

WARNING: line over 80 characters
#1671: FILE: hw/can/can_sja1000.h:57:
+    uint8_t         rxmsg_cnt;     /* PeliCAN, addr 29, RX message counter. DS-p49 */

ERROR: line over 90 characters
#1672: FILE: hw/can/can_sja1000.h:58:
+    uint8_t         rxbuf_start;   /* PeliCAN, addr 30, RX buffer start address register, DS-p49 */

WARNING: line over 80 characters
#1673: FILE: hw/can/can_sja1000.h:59:
+    uint8_t         clock;         /* PeliCAN, addr 31, Clock Divider register, DS-p55 */

WARNING: line over 80 characters
#1687: FILE: hw/can/can_sja1000.h:73:
+    uint8_t         code;          /* BasicCAN, addr 4, Acceptance code register */

WARNING: line over 80 characters
#1688: FILE: hw/can/can_sja1000.h:74:
+    uint8_t         mask;          /* BasicCAN, addr 5, Acceptance mask register */

WARNING: line over 80 characters
#1733: FILE: hw/can/can_sja1000.h:119:
+/* ID bytes (11 bits in 0 and 1 or 16 bits in 0,1 and 13 bits in 2,3 (extended)) */

WARNING: line over 80 characters
#1764: FILE: hw/can/can_sja1000.h:150:
+void can_sja_mem_write(CanSJA1000State *s, hwaddr addr, uint64_t val, unsigned size);

ERROR: line over 90 characters
#1773: FILE: hw/can/can_sja1000.h:159:
+ssize_t can_sja_receive(CanBusClientState *client, const qemu_can_frame *frames, size_t frames_cnt);

WARNING: architecture specific defines should be avoided
#1828: FILE: include/can/can_emu.h:45:
+#if defined(__GNUC__) || defined(__linux__)

ERROR: line over 90 characters
#1865: FILE: include/can/can_emu.h:82:
+typedef ssize_t (CanBusClientReceive)(CanBusClientState *, const struct qemu_can_frame *frames, size_t frames_cnt);

ERROR: line over 90 characters
#1902: FILE: include/can/can_emu.h:119:
+ssize_t can_bus_client_send(CanBusClientState *, const struct qemu_can_frame *frames, size_t frames_cnt);

ERROR: line over 90 characters
#1903: FILE: include/can/can_emu.h:120:
+int can_bus_client_set_filters(CanBusClientState *, const struct qemu_can_filter *filters, size_t filters_cnt);

total: 24 errors, 29 warnings, 1837 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/6: CAN bus Kvaser PCI CAN-S (single SJA1000 channel) emulation added....
ERROR: braces {} are necessary for all arms of this statement
#124: FILE: hw/can/can_kvaser_pci.c:100:
+    if (d->s5920_intcsr & S5920_INTCSR_ADDON_INTENABLE_M)
[...]

WARNING: line over 80 characters
#144: FILE: hw/can/can_kvaser_pci.c:120:
+static uint64_t kvaser_pci_s5920_io_read(void *opaque, hwaddr addr, unsigned size)

WARNING: line over 80 characters
#203: FILE: hw/can/can_kvaser_pci.c:179:
+static uint64_t kvaser_pci_xilinx_io_read(void *opaque, hwaddr addr, unsigned size)

ERROR: Error messages should not contain newlines
#261: FILE: hw/can/can_kvaser_pci.c:237:
+                         "the model %s is not supported now.\n", d->model);

ERROR: Error messages should not contain newlines
#268: FILE: hw/can/can_kvaser_pci.c:244:
+        error_report("Cannot create can find/allocate CAN bus\n");

WARNING: line over 80 characters
#275: FILE: hw/can/can_kvaser_pci.c:251:
+            error_report("Cannot connect CAN bus to host device \"%s\"\n", d->host);

ERROR: Error messages should not contain newlines
#275: FILE: hw/can/can_kvaser_pci.c:251:
+            error_report("Cannot connect CAN bus to host device \"%s\"\n", d->host);

ERROR: Error messages should not contain newlines
#290: FILE: hw/can/can_kvaser_pci.c:266:
+        error_report("can_sja_connect_to_bus failed\n");

WARNING: line over 80 characters
#298: FILE: hw/can/can_kvaser_pci.c:274:
+    memory_region_init_io(&d->xilinx_io, OBJECT(d), &kvaser_pci_xilinx_io_ops, d,

WARNING: line over 80 characters
#301: FILE: hw/can/can_kvaser_pci.c:277:
+    pci_register_bar(&d->dev, /*BAR*/ 0, PCI_BASE_ADDRESS_SPACE_IO, &d->s5920_io);

WARNING: line over 80 characters
#303: FILE: hw/can/can_kvaser_pci.c:279:
+    pci_register_bar(&d->dev, /*BAR*/ 2, PCI_BASE_ADDRESS_SPACE_IO, &d->xilinx_io);

WARNING: line over 80 characters
#337: FILE: hw/can/can_kvaser_pci.c:313:
+        VMSTATE_STRUCT(sja_state, KvaserPCIState, 0, vmstate_can_sja, CanSJA1000State),

total: 5 errors, 7 warnings, 368 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/6: CAN bus PCM-3680I PCI (dual SJA1000 channel) emulation added....
WARNING: line over 80 characters
#68: FILE: hw/can/can_pcm3680_pci.c:46:
+#define PCM3680i_PCI_VENDOR_ID1     0x13fe    /* the PCI device and vendor IDs */

WARNING: line over 80 characters
#111: FILE: hw/can/can_pcm3680_pci.c:89:
+static uint64_t pcm3680i_pci_sja1_io_read(void *opaque, hwaddr addr, unsigned size)

WARNING: line over 80 characters
#136: FILE: hw/can/can_pcm3680_pci.c:114:
+static uint64_t pcm3680i_pci_sja2_io_read(void *opaque, hwaddr addr, unsigned size)

ERROR: Error messages should not contain newlines
#193: FILE: hw/can/can_pcm3680_pci.c:171:
+                         "the model %s is not supported now.\n", d->model);

ERROR: Error messages should not contain newlines
#200: FILE: hw/can/can_pcm3680_pci.c:178:
+        error_report("Cannot create can find/allocate CAN bus #1\n");

ERROR: Error messages should not contain newlines
#206: FILE: hw/can/can_pcm3680_pci.c:184:
+        error_report("Cannot create can find/allocate CAN bus #2\n");

WARNING: line over 80 characters
#212: FILE: hw/can/can_pcm3680_pci.c:190:
+            error_report("Cannot connect CAN bus to host #1 device \"%s\"\n", d->host[0]);

ERROR: Error messages should not contain newlines
#212: FILE: hw/can/can_pcm3680_pci.c:190:
+            error_report("Cannot connect CAN bus to host #1 device \"%s\"\n", d->host[0]);

WARNING: line over 80 characters
#219: FILE: hw/can/can_pcm3680_pci.c:197:
+            error_report("Cannot connect CAN bus to host #2 device \"%s\"\n", d->host[1]);

ERROR: Error messages should not contain newlines
#219: FILE: hw/can/can_pcm3680_pci.c:197:
+            error_report("Cannot connect CAN bus to host #2 device \"%s\"\n", d->host[1]);

ERROR: Error messages should not contain newlines
#233: FILE: hw/can/can_pcm3680_pci.c:211:
+        error_report("can_sja_connect_to_bus failed\n");

ERROR: Error messages should not contain newlines
#238: FILE: hw/can/can_pcm3680_pci.c:216:
+        error_report("can_sja_connect_to_bus failed\n");

WARNING: line over 80 characters
#242: FILE: hw/can/can_pcm3680_pci.c:220:
+    memory_region_init_io(&d->sja_io[0], OBJECT(d), &pcm3680i_pci_sja1_io_ops, d,

ERROR: spaces required around that '/' (ctx:VxV)
#243: FILE: hw/can/can_pcm3680_pci.c:221:
+                          "pcm3680i_pci-sja1", PCM3680i_PCI_SJA_RANGE/2);
                                                                      ^

WARNING: line over 80 characters
#244: FILE: hw/can/can_pcm3680_pci.c:222:
+    memory_region_init_io(&d->sja_io[1], OBJECT(d), &pcm3680i_pci_sja2_io_ops, d,

ERROR: spaces required around that '/' (ctx:VxV)
#245: FILE: hw/can/can_pcm3680_pci.c:223:
+                          "pcm3680i_pci-sja2", PCM3680i_PCI_SJA_RANGE/2);
                                                                      ^

WARNING: line over 80 characters
#247: FILE: hw/can/can_pcm3680_pci.c:225:
+    pci_register_bar(&d->dev, /*BAR*/ 0, PCI_BASE_ADDRESS_SPACE_IO, &d->sja_io[0]);

WARNING: line over 80 characters
#248: FILE: hw/can/can_pcm3680_pci.c:226:
+    pci_register_bar(&d->dev, /*BAR*/ 1, PCI_BASE_ADDRESS_SPACE_IO, &d->sja_io[1]);

ERROR: line over 90 characters
#282: FILE: hw/can/can_pcm3680_pci.c:260:
+        VMSTATE_STRUCT(sja_state[0], Pcm3680iPCIState, 0, vmstate_can_sja, CanSJA1000State),

ERROR: line over 90 characters
#283: FILE: hw/can/can_pcm3680_pci.c:261:
+        VMSTATE_STRUCT(sja_state[1], Pcm3680iPCIState, 0, vmstate_can_sja, CanSJA1000State),

ERROR: do not use C99 // comments
#316: FILE: hw/can/can_pcm3680_pci.c:294:
+//  k->is_bridge = 0;

ERROR: do not use C99 // comments
#317: FILE: hw/can/can_pcm3680_pci.c:295:
+//  k->is_express = 0;

ERROR: Missing Signed-off-by: line(s)

total: 14 errors, 9 warnings, 319 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/6: Fixed IRQ problem for CAN device can_pcm3680_pci....
Checking PATCH 5/6: Minor clean-up of can_pcm3680_pci....
Checking PATCH 6/6: CAN bus MIOe-3680 PCI (dual SJA1000 channel) emulation added....
WARNING: line over 80 characters
#68: FILE: hw/can/can_mioe3680_pci.c:46:
+#define MIOe3680_PCI_VENDOR_ID1     0x13fe    /* the PCI device and vendor IDs */

WARNING: line over 80 characters
#118: FILE: hw/can/can_mioe3680_pci.c:96:
+static uint64_t mioe3680_pci_sja1_io_read(void *opaque, hwaddr addr, unsigned size)

WARNING: line over 80 characters
#143: FILE: hw/can/can_mioe3680_pci.c:121:
+static uint64_t mioe3680_pci_sja2_io_read(void *opaque, hwaddr addr, unsigned size)

ERROR: Error messages should not contain newlines
#200: FILE: hw/can/can_mioe3680_pci.c:178:
+                         "the model %s is not supported now.\n", d->model);

ERROR: Error messages should not contain newlines
#207: FILE: hw/can/can_mioe3680_pci.c:185:
+        error_report("Cannot create can find/allocate CAN bus #1\n");

ERROR: Error messages should not contain newlines
#213: FILE: hw/can/can_mioe3680_pci.c:191:
+        error_report("Cannot create can find/allocate CAN bus #2\n");

WARNING: line over 80 characters
#219: FILE: hw/can/can_mioe3680_pci.c:197:
+            error_report("Cannot connect CAN bus to host #1 device \"%s\"\n", d->host[0]);

ERROR: Error messages should not contain newlines
#219: FILE: hw/can/can_mioe3680_pci.c:197:
+            error_report("Cannot connect CAN bus to host #1 device \"%s\"\n", d->host[0]);

WARNING: line over 80 characters
#226: FILE: hw/can/can_mioe3680_pci.c:204:
+            error_report("Cannot connect CAN bus to host #2 device \"%s\"\n", d->host[1]);

ERROR: Error messages should not contain newlines
#226: FILE: hw/can/can_mioe3680_pci.c:204:
+            error_report("Cannot connect CAN bus to host #2 device \"%s\"\n", d->host[1]);

ERROR: Error messages should not contain newlines
#242: FILE: hw/can/can_mioe3680_pci.c:220:
+        error_report("can_sja_connect_to_bus failed\n");

ERROR: Error messages should not contain newlines
#247: FILE: hw/can/can_mioe3680_pci.c:225:
+        error_report("can_sja_connect_to_bus failed\n");

WARNING: line over 80 characters
#251: FILE: hw/can/can_mioe3680_pci.c:229:
+    memory_region_init_io(&d->sja_io[0], OBJECT(d), &mioe3680_pci_sja1_io_ops, d,

ERROR: spaces required around that '/' (ctx:VxV)
#252: FILE: hw/can/can_mioe3680_pci.c:230:
+                          "mioe3680_pci-sja1", MIOe3680_PCI_SJA_RANGE/2);
                                                                      ^

WARNING: line over 80 characters
#253: FILE: hw/can/can_mioe3680_pci.c:231:
+    memory_region_init_io(&d->sja_io[1], OBJECT(d), &mioe3680_pci_sja2_io_ops, d,

ERROR: spaces required around that '/' (ctx:VxV)
#254: FILE: hw/can/can_mioe3680_pci.c:232:
+                          "mioe3680_pci-sja2", MIOe3680_PCI_SJA_RANGE/2);
                                                                      ^

WARNING: line over 80 characters
#256: FILE: hw/can/can_mioe3680_pci.c:234:
+    pci_register_bar(&d->dev, /*BAR*/ 0, PCI_BASE_ADDRESS_SPACE_IO, &d->sja_io[0]);

WARNING: line over 80 characters
#257: FILE: hw/can/can_mioe3680_pci.c:235:
+    pci_register_bar(&d->dev, /*BAR*/ 1, PCI_BASE_ADDRESS_SPACE_IO, &d->sja_io[1]);

ERROR: line over 90 characters
#292: FILE: hw/can/can_mioe3680_pci.c:270:
+        VMSTATE_STRUCT(sja_state[0], Mioe3680PCIState, 0, vmstate_can_sja, CanSJA1000State),

ERROR: line over 90 characters
#293: FILE: hw/can/can_mioe3680_pci.c:271:
+        VMSTATE_STRUCT(sja_state[1], Mioe3680PCIState, 0, vmstate_can_sja, CanSJA1000State),

ERROR: do not use C99 // comments
#326: FILE: hw/can/can_mioe3680_pci.c:304:
+//  k->is_bridge = 0;

ERROR: do not use C99 // comments
#327: FILE: hw/can/can_mioe3680_pci.c:305:
+//  k->is_express = 0;

ERROR: Missing Signed-off-by: line(s)

total: 14 errors, 9 warnings, 329 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org