Re: [Qemu-devel] [PATCH v4 0/4] Introduce a new --only-migratable option

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH v4 0/4] Introduce a new --only-migratable option
Message-id: 1483981368-9965-1-git-send-email-ashijeetacharya@gmail.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/1483981368-9965-1-git-send-email-ashijeetacharya@gmail.com -> patchew/1483981368-9965-1-git-send-email-ashijeetacharya@gmail.com
Switched to a new branch 'test'
757f972 migration: Fail migration blocker for --only-migratble
dd5e052 migration: disallow migrate_add_blocker during migration
bb70ea7 migration: Allow "device add" options to only add migratable devices
88b5312 migration: Add a new option to enable only-migratable

=== OUTPUT BEGIN ===
Checking PATCH 1/4: migration: Add a new option to enable only-migratable...
ERROR: do not initialise globals to 0 or NULL
#56: FILE: vl.c:183:
+int only_migratable = 0; /* turn it off unless user states otherwise */

total: 1 errors, 0 warnings, 40 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/4: migration: Allow "device add" options to only add migratable devices...
Checking PATCH 3/4: migration: disallow migrate_add_blocker during migration...
ERROR: do not use C99 // comments
#159: FILE: block/vvfat.c:1205:
+    //    assert(is_consistent(s));

total: 1 errors, 0 warnings, 490 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/4: migration: Fail migration blocker for --only-migratble...
ERROR: space prohibited before that close parenthesis ')'
#159: FILE: hw/intc/arm_gic_kvm.c:517:
+        if (ret < 0 ) {

total: 1 errors, 0 warnings, 219 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org