All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] power_i2c.c: Fix unused variable warning
Date: Wed, 11 Jan 2017 09:17:31 -0500	[thread overview]
Message-ID: <1484144251-8642-1-git-send-email-trini@konsulko.com> (raw)
In-Reply-To: <0552d6e0-8e70-31a8-5678-d66c8cfe2d47@samsung.com>

The variable ret was added but never set as we did not make calls to
other functions that we needed to check the return value on.

Fixes: 505cf4750ae5 ("power: change from meaningless value to error number")
Signed-off-by: Tom Rini <trini@konsulko.com>
---
 drivers/power/power_i2c.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/power/power_i2c.c b/drivers/power/power_i2c.c
index dd22ece53cd2..8a8ea10e33ef 100644
--- a/drivers/power/power_i2c.c
+++ b/drivers/power/power_i2c.c
@@ -19,7 +19,6 @@
 int pmic_reg_write(struct pmic *p, u32 reg, u32 val)
 {
 	unsigned char buf[4] = { 0 };
-	int ret;
 
 	if (check_reg(p, reg))
 		return -EINVAL;
-- 
1.9.1

  reply	other threads:[~2017-01-11 14:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170110054802epcas5p47773e1927ecb61adccb970ff738c45a2@epcas5p4.samsung.com>
2017-01-10  5:48 ` [U-Boot] [GIT PULL] Please pull u-boot-mmc master Jaehoon Chung
2017-01-10 17:32   ` Tom Rini
2017-01-11  2:11     ` Jaehoon Chung
2017-01-11 12:39     ` Jaehoon Chung
2017-01-11 14:17       ` Tom Rini [this message]
2017-01-11 16:28         ` [U-Boot] [PATCH] power_i2c.c: Fix unused variable warning Tom Rini
2017-01-11 16:28       ` [U-Boot] [GIT PULL] Please pull u-boot-mmc master Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484144251-8642-1-git-send-email-trini@konsulko.com \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.