From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752109AbdAMPzV (ORCPT ); Fri, 13 Jan 2017 10:55:21 -0500 Received: from mga14.intel.com ([192.55.52.115]:53696 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751880AbdAMPzU (ORCPT ); Fri, 13 Jan 2017 10:55:20 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,222,1477983600"; d="scan'208";a="1112154156" Message-ID: <1484322907.2133.113.camel@linux.intel.com> Subject: Re: [PATCH 8/9] serdev: add a tty port controller driver From: Andy Shevchenko To: Rob Herring Cc: Greg Kroah-Hartman , Marcel Holtmann , Jiri Slaby , Sebastian Reichel , Arnd Bergmann , "Dr . H . Nikolaus Schaller" , Peter Hurley , Alan Cox , Loic Poulain , Pavel Machek , NeilBrown , Linus Walleij , "open list:BLUETOOTH DRIVERS" , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Fri, 13 Jan 2017 17:55:07 +0200 In-Reply-To: References: <20170106162635.19677-1-robh@kernel.org> <20170106162635.19677-9-robh@kernel.org> <1483798314.26691.3.camel@linux.intel.com> <1484319863.2133.110.camel@linux.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-01-13 at 09:28 -0600, Rob Herring wrote: > On Fri, Jan 13, 2017 at 9:04 AM, Andy Shevchenko > wrote: > > On Thu, 2017-01-12 at 10:01 -0600, Rob Herring wrote: > > > On Sat, Jan 7, 2017 at 8:11 AM, Andy Shevchenko > > > wrote: > > > > On Fri, 2017-01-06 at 10:26 -0600, Rob Herring wrote: > > > Yes, otherwise the bus can be built as a module and this driver > > > can > > > still be enabled breaking the build. I could drop supporting > > > building > > > the bus as a module because as long as this is the only controller > > > driver, it all has to be built-in. > > > > Would > > > > if SERIAL_DEV_BUS=y > > > > work for you? > > Yes, until we add a driver that doesn't have to be built-in. What > about "depends on SERIAL_DEV_BUS != m"? That would be a bit more clear > what the reason is. Ah, good point. Yes, it would also work. My concern was here is not add confusing  'depend on MENU_OPTION'. -- Andy Shevchenko Intel Finland Oy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1484322907.2133.113.camel@linux.intel.com> Subject: Re: [PATCH 8/9] serdev: add a tty port controller driver From: Andy Shevchenko To: Rob Herring Cc: Greg Kroah-Hartman , Marcel Holtmann , Jiri Slaby , Sebastian Reichel , Arnd Bergmann , "Dr . H . Nikolaus Schaller" , Peter Hurley , Alan Cox , Loic Poulain , Pavel Machek , NeilBrown , Linus Walleij , "open list:BLUETOOTH DRIVERS" , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Fri, 13 Jan 2017 17:55:07 +0200 In-Reply-To: References: <20170106162635.19677-1-robh@kernel.org> <20170106162635.19677-9-robh@kernel.org> <1483798314.26691.3.camel@linux.intel.com> <1484319863.2133.110.camel@linux.intel.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 List-ID: On Fri, 2017-01-13 at 09:28 -0600, Rob Herring wrote: > On Fri, Jan 13, 2017 at 9:04 AM, Andy Shevchenko > wrote: > > On Thu, 2017-01-12 at 10:01 -0600, Rob Herring wrote: > > > On Sat, Jan 7, 2017 at 8:11 AM, Andy Shevchenko > > > wrote: > > > > On Fri, 2017-01-06 at 10:26 -0600, Rob Herring wrote: > > > Yes, otherwise the bus can be built as a module and this driver > > > can > > > still be enabled breaking the build. I could drop supporting > > > building > > > the bus as a module because as long as this is the only controller > > > driver, it all has to be built-in. > > > > Would > > > > if SERIAL_DEV_BUS=y > > > > work for you? > > Yes, until we add a driver that doesn't have to be built-in. What > about "depends on SERIAL_DEV_BUS != m"? That would be a bit more clear > what the reason is. Ah, good point. Yes, it would also work. My concern was here is not add confusing  'depend on MENU_OPTION'. -- Andy Shevchenko Intel Finland Oy From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH 8/9] serdev: add a tty port controller driver Date: Fri, 13 Jan 2017 17:55:07 +0200 Message-ID: <1484322907.2133.113.camel@linux.intel.com> References: <20170106162635.19677-1-robh@kernel.org> <20170106162635.19677-9-robh@kernel.org> <1483798314.26691.3.camel@linux.intel.com> <1484319863.2133.110.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Sender: linux-bluetooth-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: Greg Kroah-Hartman , Marcel Holtmann , Jiri Slaby , Sebastian Reichel , Arnd Bergmann , "Dr . H . Nikolaus Schaller" , Peter Hurley , Alan Cox , Loic Poulain , Pavel Machek , NeilBrown , Linus Walleij , "open list:BLUETOOTH DRIVERS" , "linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-serial@vger.kernel.org On Fri, 2017-01-13 at 09:28 -0600, Rob Herring wrote: > On Fri, Jan 13, 2017 at 9:04 AM, Andy Shevchenko > wrote: > > On Thu, 2017-01-12 at 10:01 -0600, Rob Herring wrote: > > > On Sat, Jan 7, 2017 at 8:11 AM, Andy Shevchenko > > > wrote: > > > > On Fri, 2017-01-06 at 10:26 -0600, Rob Herring wrote: > > > Yes, otherwise the bus can be built as a module and this driver > > > can > > > still be enabled breaking the build. I could drop supporting > > > building > > > the bus as a module because as long as this is the only controller > > > driver, it all has to be built-in. > > > > Would > > > > if SERIAL_DEV_BUS=y > > > > work for you? > > Yes, until we add a driver that doesn't have to be built-in. What > about "depends on SERIAL_DEV_BUS != m"? That would be a bit more clear > what the reason is. Ah, good point. Yes, it would also work. My concern was here is not add confusing  'depend on MENU_OPTION'. -- Andy Shevchenko Intel Finland Oy