From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751383AbdAMUDA convert rfc822-to-8bit (ORCPT ); Fri, 13 Jan 2017 15:03:00 -0500 Received: from mout.gmx.net ([212.227.15.15]:51760 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750789AbdAMUCw (ORCPT ); Fri, 13 Jan 2017 15:02:52 -0500 Message-ID: <1484337634.1720.4.camel@gmx.de> Subject: Re: [PATCH v9 4/4] console: Make persistent scrollback a boot parameter From: Manuel =?ISO-8859-1?Q?Sch=F6lling?= To: Adam Borowski Cc: gregkh@linuxfoundation.org, jslaby@suse.com, lkml14@scotdoyle.com, rdunlap@infradead.org, shorne@gmail.com, andrey_utkin@fastmail.com, akpm@linux-foundation.org, paul.burton@imgtec.com, daniel.vetter@ffwll.ch, tj@kernel.org, hdegoede@redhat.com, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Date: Fri, 13 Jan 2017 21:00:34 +0100 In-Reply-To: <20170110225846.gd2pqczplnkl74d3@angband.pl> References: <4640722.jsFVORW8WM@amdc3058> <20170110212838.16175-5-manuel.schoelling@gmx.de> <20170110225846.gd2pqczplnkl74d3@angband.pl> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8BIT X-Provags-ID: V03:K0:TewFuuCaWa7dREkMrE+zpdscWXUWYv8zjlQBy1fzBND2tK/Rimb wzcpZJGssT5iYk6lynPZ28qNs7sH6eAsbnQVODQ8ToOAgaUVj6OxRGUaqjdjwtllW7cDlaN J4zp2PEcPawgPDuk2naxbpH3Qwo/zE4YY/+lQCp1cSPiZ5w1/AxCNkFe5YhJpdJ3+Vkkh3c X9fM7pAiRQxEQk0YeLp6A== X-UI-Out-Filterresults: notjunk:1;V01:K0:eUKfY3dKYRg=:zZZzIA/+RiX4IYxIZxjCeN ex4gGGFXHqJtq7G+ql7FY5JaScfEsoqH8s/C6PjtK3L952uu3XisK0EWwcDWygpPbeMJxqFx2 L4fapCMsMlyDrr/5mNXf+3gj4Wjt3zHnIj6ODycfO2F83iTSVnBoKZanIdQfVNICymxMpgOrY GwnqY4+u3gh0Kg0VdHPmdEti42PIYJP0SIRnO42/Hdz7dzGYmdfOj2qWGO0ggO06zlrJZ8z3i nVAJ7AfMLh43ctAx8DmIL140ADW1ELvfELtqA9Xjz2pc9zD2xopVhzHAReHBpXrOeq8eAts3b oU6x1uKdRsq5AJI+WBGfCBQTT5POy2n6IGps22/oNojDIPe0zvTz6gvsXvIqdd7Iv2fQ4iD+/ USgmzJWwVuO2JktinKH/he3PyTRX70Zt6/5HlVBktwtA0ABmBoyfp+y3sU0srT+7Ex058xKvb UYHshbECMUdgP3sDHjmMFi2uM5fLPRfELtm0XLRcLqF4NMB1HOgDfNQXM7XOh9ZgEIQO4rURj tQs1G8+HE67lmnOBJXT+bbEvqzQNxus0BGQVlZH5tzgaD72h7xp4aRps5XoAW2Lj2FoVjOyxX a4WNPBh27hskoOUxQ08tN57Y79cemoFfTpN6CxI3dADCSocLKMCT+P/I11iFmRD+dJ5ILrIU7 JmWhRTM62lGG6TNAcX7C1TNEyok1AyEUrcpdaKTtryy0ugSyP9n9MEoRP5wrK2DB927oSSs+c cicszg08BjZr6ahUZseVo1ePyvSgrfpQbF/siphZ9rVTpqdU6QJLtIfAyDjUPB8jgcNd/BbNH LuJVBe8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-01-10 at 23:58 +0100, Adam Borowski wrote: > On Tue, Jan 10, 2017 at 10:28:38PM +0100, Manuel Schölling wrote: > > The impact of the persistent scrollback feature on the code size is > > rather small, so the config option is removed. The feature stays > > disabled by default and can be enabled by using the boot command > > line > > parameter 'vgacon.scrollback_persistent=1' or by setting > > VGACON_SOFT_SCROLLBACK_PERSISTENT_ENABLE_BY_DEFAULT=y. > > > > Signed-off-by: Manuel Schölling > > Suggested-by: Bartlomiej Zolnierkiewicz > > +module_param_named(scrollback_persistent, scrollback_persistent, > > bool, 0000); > > +MODULE_PARM_DESC(scrollback_persistent, "Enable persistent > > scrollback for all vga consoles"); > > A command-line knob settable by the end-user is something more > persistent > than a config option.  As you're going to extend this code beyond > vgacon in > the near future, perhaps it'd be better to have a shared setting for > all > console drivers? According to the guys at #kernelnewbies on IRC everybody hates new command line options. I'd rather stick to the module parameter for now and maybe introduce a new cmd line option later, once this feature has been implemented in several console drivers. Bye, Manuel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manuel =?ISO-8859-1?Q?Sch=F6lling?= Date: Fri, 13 Jan 2017 20:00:34 +0000 Subject: Re: [PATCH v9 4/4] console: Make persistent scrollback a boot parameter Message-Id: <1484337634.1720.4.camel@gmx.de> List-Id: References: <4640722.jsFVORW8WM@amdc3058> <20170110212838.16175-5-manuel.schoelling@gmx.de> <20170110225846.gd2pqczplnkl74d3@angband.pl> In-Reply-To: <20170110225846.gd2pqczplnkl74d3@angband.pl> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Adam Borowski Cc: gregkh@linuxfoundation.org, jslaby@suse.com, lkml14@scotdoyle.com, rdunlap@infradead.org, shorne@gmail.com, andrey_utkin@fastmail.com, akpm@linux-foundation.org, paul.burton@imgtec.com, daniel.vetter@ffwll.ch, tj@kernel.org, hdegoede@redhat.com, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org On Tue, 2017-01-10 at 23:58 +0100, Adam Borowski wrote: > On Tue, Jan 10, 2017 at 10:28:38PM +0100, Manuel Schölling wrote: > > The impact of the persistent scrollback feature on the code size is > > rather small, so the config option is removed. The feature stays > > disabled by default and can be enabled by using the boot command > > line > > parameter 'vgacon.scrollback_persistent=1' or by setting > > VGACON_SOFT_SCROLLBACK_PERSISTENT_ENABLE_BY_DEFAULT=y. > > > > Signed-off-by: Manuel Schölling > > Suggested-by: Bartlomiej Zolnierkiewicz > > +module_param_named(scrollback_persistent, scrollback_persistent, > > bool, 0000); > > +MODULE_PARM_DESC(scrollback_persistent, "Enable persistent > > scrollback for all vga consoles"); > > A command-line knob settable by the end-user is something more > persistent > than a config option.  As you're going to extend this code beyond > vgacon in > the near future, perhaps it'd be better to have a shared setting for > all > console drivers? According to the guys at #kernelnewbies on IRC everybody hates new command line options. I'd rather stick to the module parameter for now and maybe introduce a new cmd line option later, once this feature has been implemented in several console drivers. Bye, Manuel