From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751449AbdAPQOq (ORCPT ); Mon, 16 Jan 2017 11:14:46 -0500 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:54394 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750863AbdAPQOn (ORCPT ); Mon, 16 Jan 2017 11:14:43 -0500 Message-ID: <1484583279.2540.37.camel@HansenPartnership.com> Subject: Re: [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination" From: James Bottomley To: Christoph Hellwig , Bart Van Assche Cc: "torvalds@linux-foundation.org" , "mingo@kernel.org" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "sathya.prakash@broadcom.com" , "suganath-prabu.subramani@broadcom.com" , "hare@suse.de" , "akpm@linux-foundation.org" , "linux-scsi@vger.kernel.org" , "Sreekanth.Reddy@broadcom.com" , "chaitra.basappa@broadcom.com" Date: Mon, 16 Jan 2017 08:14:39 -0800 In-Reply-To: <20170116152721.GA6677@infradead.org> References: <1484319727.2527.8.camel@HansenPartnership.com> <20170115091925.GA26656@gmail.com> <1484496665.2405.2.camel@HansenPartnership.com> <1484507599.2405.16.camel@HansenPartnership.com> <1484509776.2405.21.camel@HansenPartnership.com> <1484517756.11850.1.camel@sandisk.com> <20170116152721.GA6677@infradead.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-01-16 at 07:27 -0800, Christoph Hellwig wrote: > On Sun, Jan 15, 2017 at 10:02:51PM +0000, Bart Van Assche wrote: > > I disagree. Even if my patch would be reverted that still wouldn't > > fix the severe race condition that was introduced in the mpt3sas > > driver by the patch that triggers the lockup during boot. As I > > explained two weeks ago (see also > > https://www.spinics.net/lists/kernel/msg2411413.htm > > l), commit 18f6084a989b ("scsi: mpt3sas: Fix secure erase premature > > termination") is the one that should be reverted instead of my > > patch. I agree with Linus that the offending mpt3sas patch already > > should have been reverted. > > In addition to that ATA passthrough through scsi CDBs is a fringe > feature compared to normal operation of the HBA. So how about, instead of arguing about reversion, one or other of you reviews the proposed fix of the fix which would avoid having to revert anything? James From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination" Date: Mon, 16 Jan 2017 08:14:39 -0800 Message-ID: <1484583279.2540.37.camel@HansenPartnership.com> References: <1484319727.2527.8.camel@HansenPartnership.com> <20170115091925.GA26656@gmail.com> <1484496665.2405.2.camel@HansenPartnership.com> <1484507599.2405.16.camel@HansenPartnership.com> <1484509776.2405.21.camel@HansenPartnership.com> <1484517756.11850.1.camel@sandisk.com> <20170116152721.GA6677@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170116152721.GA6677@infradead.org> Sender: linux-kernel-owner@vger.kernel.org To: Christoph Hellwig , Bart Van Assche Cc: "torvalds@linux-foundation.org" , "mingo@kernel.org" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "sathya.prakash@broadcom.com" , "suganath-prabu.subramani@broadcom.com" , "hare@suse.de" , "akpm@linux-foundation.org" , "linux-scsi@vger.kernel.org" , "Sreekanth.Reddy@broadcom.com" , "chaitra.basappa@broadcom.com" List-Id: linux-scsi@vger.kernel.org On Mon, 2017-01-16 at 07:27 -0800, Christoph Hellwig wrote: > On Sun, Jan 15, 2017 at 10:02:51PM +0000, Bart Van Assche wrote: > > I disagree. Even if my patch would be reverted that still wouldn't > > fix the severe race condition that was introduced in the mpt3sas > > driver by the patch that triggers the lockup during boot. As I > > explained two weeks ago (see also > > https://www.spinics.net/lists/kernel/msg2411413.htm > > l), commit 18f6084a989b ("scsi: mpt3sas: Fix secure erase premature > > termination") is the one that should be reverted instead of my > > patch. I agree with Linus that the offending mpt3sas patch already > > should have been reverted. > > In addition to that ATA passthrough through scsi CDBs is a fringe > feature compared to normal operation of the HBA. So how about, instead of arguing about reversion, one or other of you reviews the proposed fix of the fix which would avoid having to revert anything? James