* [PATCH] irqchip/renesas-rza1: Use semicolons instead of commas
@ 2021-09-15 9:47 Geert Uytterhoeven
2021-09-21 10:52 ` Ulrich Hecht
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2021-09-15 9:47 UTC (permalink / raw)
To: Thomas Gleixner, Marc Zyngier
Cc: Julia Lawall, linux-renesas-soc, linux-kernel, Geert Uytterhoeven
This code works, but it is cleaner to use semicolons at the end of
statements instead of commas.
Extracted from a big anonymous patch by Julia Lawall
<julia.lawall@inria.fr>.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/irqchip/irq-renesas-rza1.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/irqchip/irq-renesas-rza1.c b/drivers/irqchip/irq-renesas-rza1.c
index b0d46ac42b892340..72c06e883d1c5fd5 100644
--- a/drivers/irqchip/irq-renesas-rza1.c
+++ b/drivers/irqchip/irq-renesas-rza1.c
@@ -223,12 +223,12 @@ static int rza1_irqc_probe(struct platform_device *pdev)
goto out_put_node;
}
- priv->chip.name = "rza1-irqc",
- priv->chip.irq_mask = irq_chip_mask_parent,
- priv->chip.irq_unmask = irq_chip_unmask_parent,
- priv->chip.irq_eoi = rza1_irqc_eoi,
- priv->chip.irq_retrigger = irq_chip_retrigger_hierarchy,
- priv->chip.irq_set_type = rza1_irqc_set_type,
+ priv->chip.name = "rza1-irqc";
+ priv->chip.irq_mask = irq_chip_mask_parent;
+ priv->chip.irq_unmask = irq_chip_unmask_parent;
+ priv->chip.irq_eoi = rza1_irqc_eoi;
+ priv->chip.irq_retrigger = irq_chip_retrigger_hierarchy;
+ priv->chip.irq_set_type = rza1_irqc_set_type;
priv->chip.flags = IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_SKIP_SET_WAKE;
priv->irq_domain = irq_domain_add_hierarchy(parent, 0, IRQC_NUM_IRQ,
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] irqchip/renesas-rza1: Use semicolons instead of commas
2021-09-15 9:47 [PATCH] irqchip/renesas-rza1: Use semicolons instead of commas Geert Uytterhoeven
@ 2021-09-21 10:52 ` Ulrich Hecht
0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Hecht @ 2021-09-21 10:52 UTC (permalink / raw)
To: Geert Uytterhoeven, Thomas Gleixner, Marc Zyngier
Cc: Julia Lawall, linux-renesas-soc, linux-kernel
> On 09/15/2021 11:47 AM Geert Uytterhoeven <geert+renesas@glider.be> wrote:
>
>
> This code works, but it is cleaner to use semicolons at the end of
> statements instead of commas.
>
> Extracted from a big anonymous patch by Julia Lawall
> <julia.lawall@inria.fr>.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/irqchip/irq-renesas-rza1.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/irqchip/irq-renesas-rza1.c b/drivers/irqchip/irq-renesas-rza1.c
> index b0d46ac42b892340..72c06e883d1c5fd5 100644
> --- a/drivers/irqchip/irq-renesas-rza1.c
> +++ b/drivers/irqchip/irq-renesas-rza1.c
> @@ -223,12 +223,12 @@ static int rza1_irqc_probe(struct platform_device *pdev)
> goto out_put_node;
> }
>
> - priv->chip.name = "rza1-irqc",
> - priv->chip.irq_mask = irq_chip_mask_parent,
> - priv->chip.irq_unmask = irq_chip_unmask_parent,
> - priv->chip.irq_eoi = rza1_irqc_eoi,
> - priv->chip.irq_retrigger = irq_chip_retrigger_hierarchy,
> - priv->chip.irq_set_type = rza1_irqc_set_type,
> + priv->chip.name = "rza1-irqc";
> + priv->chip.irq_mask = irq_chip_mask_parent;
> + priv->chip.irq_unmask = irq_chip_unmask_parent;
> + priv->chip.irq_eoi = rza1_irqc_eoi;
> + priv->chip.irq_retrigger = irq_chip_retrigger_hierarchy;
> + priv->chip.irq_set_type = rza1_irqc_set_type;
> priv->chip.flags = IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_SKIP_SET_WAKE;
>
> priv->irq_domain = irq_domain_add_hierarchy(parent, 0, IRQC_NUM_IRQ,
> --
> 2.25.1
Reviewed-by: Ulrich Hecht <uli+renesas@fpond.eu>
CU
Uli
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-21 10:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-15 9:47 [PATCH] irqchip/renesas-rza1: Use semicolons instead of commas Geert Uytterhoeven
2021-09-21 10:52 ` Ulrich Hecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.