From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v5 21/24] tools: L2 CAT: support get HW info
	for L2 CAT.
Date: Wed, 18 Jan 2017 09:33:48 +0100
Message-ID: <1484728428.7492.45.camel@citrix.com>
References: <1484704967-5609-1-git-send-email-yi.y.sun@linux.intel.com>
 <1484704967-5609-22-git-send-email-yi.y.sun@linux.intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9080269513266274677=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <prvs=1845145f2=dario.faggioli@citrix.com>)
 id 1cTlgv-00011V-5J
 for xen-devel@lists.xenproject.org; Wed, 18 Jan 2017 08:34:01 +0000
In-Reply-To: <1484704967-5609-22-git-send-email-yi.y.sun@linux.intel.com>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Yi Sun <yi.y.sun@linux.intel.com>, xen-devel@lists.xenproject.org
Cc: wei.liu2@citrix.com, konrad.wilk@oracle.com, andrew.cooper3@citrix.com, he.chen@linux.intel.com, ian.jackson@eu.citrix.com, mengxu@cis.upenn.edu, jbeulich@suse.com, chao.p.peng@linux.intel.com
List-Id: xen-devel@lists.xenproject.org

--===============9080269513266274677==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="=-Ub4QCAK7xrcIcnJQGNAj"

--=-Ub4QCAK7xrcIcnJQGNAj
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2017-01-18 at 10:02 +0800, Yi Sun wrote:
> This patch implements xl/xc changes to support get HW info
> for L2 CAT.
>=20
> 'xl psr-hwinfo' is updated to show both L3 CAT and L2 CAT
> info.
>=20
> Example(on machine which only supports L2 CAT):
> Cache Monitoring Technology (CMT):
> Enabled=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0: 0
> Cache Allocation Technology (CAT): L3
> libxl: error: libxl_psr.c:100:libxl__psr_cat_log_err_msg: CAT is not
> enabled on the socket: No such file or directory
> Failed to get l3 cat info
> Cache Allocation Technology (CAT): L2
> Socket ID=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0: 0
> Maximum COS=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0: 3
> CBM length=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0: 8
> Default CBM=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0: 0xff
>
I think we settled, in v4, for not having this awkward error message
showing itself in this way "only" because of (legitimate!) lack of
hardware support for some of the features?

https://lists.xenproject.org/archives/html/xen-devel/2017-01/msg00604.html
https://lists.xenproject.org/archives/html/xen-devel/2017-01/msg00792.html
https://lists.xenproject.org/archives/html/xen-devel/2017-01/msg00797.html

Nevertheless, I've had a look at the code, and it looks good to me.

Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
--=-Ub4QCAK7xrcIcnJQGNAj
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJYfyhsAAoJEBZCeImluHPu8QkP/1Tq7dC5hXNbxc3tenHgJ9IM
7VYEFR++RCLjj7nCV4MzVNkrJ5TX7PMfpWzR+iS3dKF5dt/rWWhr2ulyYBlj4FnT
1rEal7QN1RKIH7RdCxGss0Y5hWM2QG/kp82XfS9Lsr0xAdpo7i2GE4t/sBh9oUu0
mMpZFDVw0hJUgw2kTj7DkG+AuqiOoR/uqPIriA3rplmpg2hxwy2FyMpYGmz7FXrJ
x5pZWhCkUAq25QeHCs0m6+Jsm4wPf61UiyXNyFJppPpSiuPXpzcEEVPMrkxYWfCH
K63qtSGyL1bKVwcCU7rfY8AK8gE3zSbFHF54026nIGTcuPQKFIeseo/9S365Zaq+
clBxfb1R8itvwWaWQTujODCiuAROYFyhNPY9cHz7ioFWcoUTPfccKrd3BYU8iXPq
hUQLpfbn1NA3AydBXiFUSvGwSHoDA8L3Q4njVvdW59121RoGVkF0brCMrhAv18pC
mCKxR+bSCOtqIExRjc+6kvTgPiaP/7fhLZuEpt9QUnTq31dYqzRFUozKppcPn1kE
bgx897Q9bm74pB7AkoVANYpEAzVU60/YIhsTQi0DrNUVhUpm94FF/C98tdjOK8Nk
WSa8U7rpY2P7kfCEf0+7fOgLG77NzLkzHRNnKT4KnNMSTAsSikXs86u14YQLaN7X
X1sSsdmqIe8VvrMAPv2b
=iCsh
-----END PGP SIGNATURE-----

--=-Ub4QCAK7xrcIcnJQGNAj--


--===============9080269513266274677==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v
cmcveGVuLWRldmVsCg==

--===============9080269513266274677==--