* [PATCH] kni: add bulk function to free mbufs
@ 2017-01-18 9:23 Sergey Vyazmitinov
2017-01-18 10:06 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Sergey Vyazmitinov @ 2017-01-18 9:23 UTC (permalink / raw)
To: olivier.matz
Cc: konstantin.ananyev, stephen, yuanhan.liu, ferruh.yigit, dev,
Sergey Vyazmitinov
Suggested-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Sergey Vyazmitinov <s.vyazmitinov@brain4net.com>
---
v3:
* Fixed issue with possible different mempools in buffer list.
* Fixed issue with wrong rte_pktmbuf_alloc_bulk function return value
processing in the kni_allocate_mbufs.
---
lib/librte_mbuf/rte_mbuf.h | 49 ++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 49 insertions(+)
diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index 4476d75..69d314f 100644
--- a/lib/librte_mbuf/rte_mbuf.h
+++ b/lib/librte_mbuf/rte_mbuf.h
@@ -306,6 +306,9 @@ extern "C" {
/** Alignment constraint of mbuf private area. */
#define RTE_MBUF_PRIV_ALIGN 8
+/** Maximum number of mbufs freed in bulk. */
+#define RTE_MBUF_BULK_FREE 64
+
/**
* Get the name of a RX offload flag
*
@@ -1261,6 +1264,52 @@ static inline void rte_pktmbuf_free(struct rte_mbuf *m)
}
/**
+ * Free n packets mbuf back into its original mempool.
+ *
+ * Free each mbuf, and all its segments in case of chained buffers. Each
+ * segment is added back into its original mempool.
+ *
+ * @param mp
+ * The packets mempool.
+ * @param mbufs
+ * The packets mbufs array to be freed.
+ * @param n
+ * Number of packets.
+ */
+static inline void rte_pktmbuf_free_bulk(struct rte_mbuf **mbufs,
+ unsigned int n)
+{
+ void *tofree[RTE_MBUF_BULK_FREE];
+ struct rte_mempool *mp = NULL;
+ unsigned int i, count = 0;
+
+ for (i = 0; i < n; i++) {
+ struct rte_mbuf *m, *m_next;
+
+ for (m = mbufs[i]; m; m = m_next) {
+ m_next = m->next;
+
+ if (count > 0 &&
+ (unlikely(m->pool != mp ||
+ count == RTE_MBUF_BULK_FREE))) {
+ rte_mempool_put_bulk(mp, tofree, count);
+ count = 0;
+ }
+
+ mp = m->pool;
+
+ if (likely(__rte_pktmbuf_prefree_seg(m) != NULL)) {
+ m->next = NULL;
+ tofree[count++] = m;
+ }
+ }
+ }
+
+ if (likely(count > 0))
+ rte_mempool_put_bulk(mp, tofree, count);
+}
+
+/**
* Creates a "clone" of the given packet mbuf.
*
* Walks through all segments of the given packet mbuf, and for each of them:
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kni: add bulk function to free mbufs
2017-01-18 9:23 [PATCH] kni: add bulk function to free mbufs Sergey Vyazmitinov
@ 2017-01-18 10:06 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2017-01-18 10:06 UTC (permalink / raw)
To: Sergey Vyazmitinov, olivier.matz
Cc: konstantin.ananyev, stephen, yuanhan.liu, dev
On 1/18/2017 9:23 AM, Sergey Vyazmitinov wrote:
> Suggested-by: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Sergey Vyazmitinov <s.vyazmitinov@brain4net.com>
> ---
> v3:
> * Fixed issue with possible different mempools in buffer list.
> * Fixed issue with wrong rte_pktmbuf_alloc_bulk function return value
> processing in the kni_allocate_mbufs.
Hi Sergey,
Thank you for the patch. I aware you sent this patch to separate mbuf
changes, but kni v3 patch should reflect this update.
Would you mind doing a v4, as patchset, which consists of two pathes:
1- This patch
2- kni v3 patch without mbuf changes.
There are a few copies of patch around, I am marking all as "Changes
Requested" in patchwork, fyi.
Thanks,
ferruh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-18 10:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-18 9:23 [PATCH] kni: add bulk function to free mbufs Sergey Vyazmitinov
2017-01-18 10:06 ` Ferruh Yigit
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.