From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40AB0C4320A for ; Wed, 18 Aug 2021 04:43:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 21DF46108B for ; Wed, 18 Aug 2021 04:43:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237726AbhHREoE (ORCPT ); Wed, 18 Aug 2021 00:44:04 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:45221 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237577AbhHREoC (ORCPT ); Wed, 18 Aug 2021 00:44:02 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1629261808; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: References: Cc: To: Subject: From: Sender; bh=84d/b9xhLIn1Jlz2CQezqi4i1lRkW5aMddLb9rwJBHg=; b=bzchOXhGxi3vGkAR/3bNZQhvKdkZOpku5hLehJshCk3iBPKMgBHtPRtM8q5+8zDmQnQxDqWB 2PaX5095YWidUR3oXHza4lCtluNIZle6YZhjFPvAUFwwFq9IfaoF7wUVDtOjIE499OFlrUqc PzUgQwOX41OH2Zz9CscqR/rPiuI= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 611c8ff03f142481723e3453 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 18 Aug 2021 04:43:28 GMT Sender: mdtipton=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 20FA4C4361A; Wed, 18 Aug 2021 04:43:28 +0000 (UTC) Received: from [192.168.1.159] (ip70-179-20-127.sd.sd.cox.net [70.179.20.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mdtipton) by smtp.codeaurora.org (Postfix) with ESMTPSA id 63EACC4360C; Wed, 18 Aug 2021 04:43:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 63EACC4360C Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org From: Mike Tipton Subject: Re: [PATCH v2 4/4] interconnect: qcom: icc-rpmh: Add BCMs to commit list in pre_aggregate To: Bjorn Andersson , Stephen Boyd Cc: djakov@kernel.org, agross@kernel.org, saravanak@google.com, okukatla@codeaurora.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Alex Elder References: <20210721175432.2119-1-mdtipton@codeaurora.org> <20210721175432.2119-5-mdtipton@codeaurora.org> Message-ID: <1484f6d6-0eac-b3e0-57e5-0443043debd1@codeaurora.org> Date: Tue, 17 Aug 2021 21:43:25 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 8/10/2021 5:18 PM, Bjorn Andersson wrote: > On Tue 10 Aug 18:31 CDT 2021, Stephen Boyd wrote: > >> Quoting Mike Tipton (2021-07-21 10:54:32) >>> We're only adding BCMs to the commit list in aggregate(), but there are >>> cases where pre_aggregate() is called without subsequently calling >>> aggregate(). In particular, in icc_sync_state() when a node with initial >>> BW has zero requests. Since BCMs aren't added to the commit list in >>> these cases, we don't actually send the zero BW request to HW. So the >>> resources remain on unnecessarily. >>> >>> Add BCMs to the commit list in pre_aggregate() instead, which is always >>> called even when there are no requests. >>> >>> Fixes: 976daac4a1c5 ("interconnect: qcom: Consolidate interconnect RPMh support") >>> Signed-off-by: Mike Tipton >>> --- >> >> This patch breaks reboot for me on sc7180 Lazor >> > > FWIW, it prevents at least SM8150 from booting (need to check my other > boards as well), because its no longer okay to have the interconnect > providers defined without having all client paths specified. My testing was limited to sdm845, which didn't show any boot issues. But it's not terribly surprising for this to cause problems on some targets. Previously every node was enabled by default and left on permanently if nobody explicitly voted for them. This would happen even if these nodes weren't enabled in bootloaders, since most of the qcom providers aren't defining a get_bw() callback and thus the framework defaults init_avg/init_peak to INT_MAX. So any drivers relying on this default-on behavior would break. We can try to get dumps of the NOC error registers at the time of failure to pinpoint the problematic access. Or we could try to narrow it down by marking more BCMs as keepalive. If they're marked as keepalive then we won't let them turn off even with this patch. > > Regards, > Bjorn >