* [PATCH 1/1] nvmet: avoid dereferencing nvmet_req
@ 2017-01-23 9:01 Max Gurtovoy
2017-01-23 18:38 ` Christoph Hellwig
2017-01-23 19:52 ` Sagi Grimberg
0 siblings, 2 replies; 3+ messages in thread
From: Max Gurtovoy @ 2017-01-23 9:01 UTC (permalink / raw)
No need to dereference req twice to get the cmd when we already
have it stored in a local variable.
Signed-off-by: Max Gurtovoy <maxg at mellanox.com>
Reviewed-by: Parav Pandit <parav at mellanox.com>
---
drivers/nvme/target/fabrics-cmd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/nvme/target/fabrics-cmd.c b/drivers/nvme/target/fabrics-cmd.c
index f408819..11c6682 100644
--- a/drivers/nvme/target/fabrics-cmd.c
+++ b/drivers/nvme/target/fabrics-cmd.c
@@ -220,7 +220,7 @@ int nvmet_parse_connect_cmd(struct nvmet_req *req)
req->ns = NULL;
- if (req->cmd->common.opcode != nvme_fabrics_command) {
+ if (cmd->common.opcode != nvme_fabrics_command) {
pr_err("invalid command 0x%x on unconnected queue.\n",
cmd->fabrics.opcode);
return NVME_SC_INVALID_OPCODE | NVME_SC_DNR;
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 1/1] nvmet: avoid dereferencing nvmet_req
2017-01-23 9:01 [PATCH 1/1] nvmet: avoid dereferencing nvmet_req Max Gurtovoy
@ 2017-01-23 18:38 ` Christoph Hellwig
2017-01-23 19:52 ` Sagi Grimberg
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2017-01-23 18:38 UTC (permalink / raw)
On Mon, Jan 23, 2017@11:01:12AM +0200, Max Gurtovoy wrote:
> No need to dereference req twice to get the cmd when we already
> have it stored in a local variable.
>
> Signed-off-by: Max Gurtovoy <maxg at mellanox.com>
> Reviewed-by: Parav Pandit <parav at mellanox.com>
Looks good (for 4.11)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] nvmet: avoid dereferencing nvmet_req
2017-01-23 9:01 [PATCH 1/1] nvmet: avoid dereferencing nvmet_req Max Gurtovoy
2017-01-23 18:38 ` Christoph Hellwig
@ 2017-01-23 19:52 ` Sagi Grimberg
1 sibling, 0 replies; 3+ messages in thread
From: Sagi Grimberg @ 2017-01-23 19:52 UTC (permalink / raw)
Looks fine,
Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-23 19:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-23 9:01 [PATCH 1/1] nvmet: avoid dereferencing nvmet_req Max Gurtovoy
2017-01-23 18:38 ` Christoph Hellwig
2017-01-23 19:52 ` Sagi Grimberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.