* [Qemu-devel] [PATCH 2/2] niagara: check if a serial port is available
@ 2017-01-23 21:22 Artyom Tarasenko
2017-01-24 8:25 ` Markus Armbruster
0 siblings, 1 reply; 2+ messages in thread
From: Artyom Tarasenko @ 2017-01-23 21:22 UTC (permalink / raw)
To: qemu-devel; +Cc: mark.cave-ayland, armbru, Artyom Tarasenko
Reported-by:Markus Armbruster <armbru@redhat.com>
Signed-off-by: Artyom Tarasenko <atar4qemu@gmail.com>
---
hw/sparc64/niagara.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/sparc64/niagara.c b/hw/sparc64/niagara.c
index e945b5a..a14724f 100644
--- a/hw/sparc64/niagara.c
+++ b/hw/sparc64/niagara.c
@@ -154,9 +154,10 @@ static void niagara_init(MachineState *machine)
exit(1);
}
}
- serial_mm_init(sysmem, NIAGARA_UART_BASE, 0, NULL, 115200,
- serial_hds[0], DEVICE_BIG_ENDIAN);
-
+ if (serial_hds[0]) {
+ serial_mm_init(sysmem, NIAGARA_UART_BASE, 0, NULL, 115200,
+ serial_hds[0], DEVICE_BIG_ENDIAN);
+ }
empty_slot_init(NIAGARA_IOBBASE, NIAGARA_IOBSIZE);
sun4v_rtc_init(NIAGARA_RTC_BASE);
}
--
2.7.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] niagara: check if a serial port is available
2017-01-23 21:22 [Qemu-devel] [PATCH 2/2] niagara: check if a serial port is available Artyom Tarasenko
@ 2017-01-24 8:25 ` Markus Armbruster
0 siblings, 0 replies; 2+ messages in thread
From: Markus Armbruster @ 2017-01-24 8:25 UTC (permalink / raw)
To: Artyom Tarasenko; +Cc: qemu-devel, mark.cave-ayland
Your series lacks threading: the patches don't carry In-Reply-To and
References headers. The easiest way to fix that is sending them with
git-send-email --thread. You should be able to omit --thread; it's the
default unless configured otherwise.
Artyom Tarasenko <atar4qemu@gmail.com> writes:
> Reported-by:Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Artyom Tarasenko <atar4qemu@gmail.com>
> ---
> hw/sparc64/niagara.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/hw/sparc64/niagara.c b/hw/sparc64/niagara.c
> index e945b5a..a14724f 100644
> --- a/hw/sparc64/niagara.c
> +++ b/hw/sparc64/niagara.c
> @@ -154,9 +154,10 @@ static void niagara_init(MachineState *machine)
> exit(1);
> }
> }
> - serial_mm_init(sysmem, NIAGARA_UART_BASE, 0, NULL, 115200,
> - serial_hds[0], DEVICE_BIG_ENDIAN);
> -
> + if (serial_hds[0]) {
> + serial_mm_init(sysmem, NIAGARA_UART_BASE, 0, NULL, 115200,
> + serial_hds[0], DEVICE_BIG_ENDIAN);
> + }
> empty_slot_init(NIAGARA_IOBBASE, NIAGARA_IOBSIZE);
> sun4v_rtc_init(NIAGARA_RTC_BASE);
> }
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-24 8:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-23 21:22 [Qemu-devel] [PATCH 2/2] niagara: check if a serial port is available Artyom Tarasenko
2017-01-24 8:25 ` Markus Armbruster
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.