From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750807AbdAXGMx (ORCPT ); Tue, 24 Jan 2017 01:12:53 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:45195 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750718AbdAXGMw (ORCPT ); Tue, 24 Jan 2017 01:12:52 -0500 Message-ID: <1485238365.30572.5.camel@mtksdaap41> Subject: Re: [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions From: CK Hu To: Bibby Hsieh CC: David Airlie , Matthias Brugger , Daniel Vetter , , , Yingjoe Chen , Cawa Cheng , Daniel Kurtz , "Philipp Zabel" , YT Shen , "Thierry Reding" , Mao Huang , , , "Sascha Hauer" Date: Tue, 24 Jan 2017 14:12:45 +0800 In-Reply-To: <1485234604-19889-1-git-send-email-bibby.hsieh@mediatek.com> References: <1485234604-19889-1-git-send-email-bibby.hsieh@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Bibby: On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wrote: > Current Mediatek DRM driver does not support interlaced mode, and > will hang if such resolution is used: Filter those to prevent > kernel hangs, until the DRM driver is fixed properly. > > Signed-off-by: Bibby Hsieh Acked-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c > index 0e8c4d9..e33678d 100644 > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c > @@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn, > return MODE_BAD; > } > > + if (mode->flags & DRM_MODE_FLAG_INTERLACE) > + return MODE_NO_INTERLACE; > if (mode->clock < 27000) > return MODE_CLOCK_LOW; > if (mode->clock > 297000) From mboxrd@z Thu Jan 1 00:00:00 1970 From: CK Hu Subject: Re: [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions Date: Tue, 24 Jan 2017 14:12:45 +0800 Message-ID: <1485238365.30572.5.camel@mtksdaap41> References: <1485234604-19889-1-git-send-email-bibby.hsieh@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1485234604-19889-1-git-send-email-bibby.hsieh@mediatek.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Bibby Hsieh Cc: linux-kernel@vger.kernel.org, Sascha Hauer , Daniel Vetter , Cawa Cheng , dri-devel@lists.freedesktop.org, Mao Huang , linux-mediatek@lists.infradead.org, Matthias Brugger , Yingjoe Chen , linux-arm-kernel@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org SGksIEJpYmJ5OgoKT24gVHVlLCAyMDE3LTAxLTI0IGF0IDEzOjEwICswODAwLCBCaWJieSBIc2ll aCB3cm90ZToKPiBDdXJyZW50IE1lZGlhdGVrIERSTSBkcml2ZXIgZG9lcyBub3Qgc3VwcG9ydCBp bnRlcmxhY2VkIG1vZGUsIGFuZAo+IHdpbGwgaGFuZyBpZiBzdWNoIHJlc29sdXRpb24gaXMgdXNl ZDogRmlsdGVyIHRob3NlIHRvIHByZXZlbnQKPiBrZXJuZWwgaGFuZ3MsIHVudGlsIHRoZSBEUk0g ZHJpdmVyIGlzIGZpeGVkIHByb3Blcmx5Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IEJpYmJ5IEhzaWVo IDxiaWJieS5oc2llaEBtZWRpYXRlay5jb20+CgpBY2tlZC1ieTogQ0sgSHUgPGNrLmh1QG1lZGlh dGVrLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfaGRtaS5jIHwg MiArKwo+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfaGRtaS5jIGIvZHJpdmVycy9ncHUvZHJtL21l ZGlhdGVrL210a19oZG1pLmMKPiBpbmRleCAwZThjNGQ5Li5lMzM2NzhkIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfaGRtaS5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL21lZGlhdGVrL210a19oZG1pLmMKPiBAQCAtMTI0NCw2ICsxMjQ0LDggQEAgc3RhdGljIGlu dCBtdGtfaGRtaV9jb25uX21vZGVfdmFsaWQoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm4sCj4g IAkJCXJldHVybiBNT0RFX0JBRDsKPiAgCX0KPiAgCj4gKwlpZiAobW9kZS0+ZmxhZ3MgJiBEUk1f TU9ERV9GTEFHX0lOVEVSTEFDRSkKPiArCQlyZXR1cm4gTU9ERV9OT19JTlRFUkxBQ0U7Cj4gIAlp ZiAobW9kZS0+Y2xvY2sgPCAyNzAwMCkKPiAgCQlyZXR1cm4gTU9ERV9DTE9DS19MT1c7Cj4gIAlp ZiAobW9kZS0+Y2xvY2sgPiAyOTcwMDApCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: ck.hu@mediatek.com (CK Hu) Date: Tue, 24 Jan 2017 14:12:45 +0800 Subject: [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions In-Reply-To: <1485234604-19889-1-git-send-email-bibby.hsieh@mediatek.com> References: <1485234604-19889-1-git-send-email-bibby.hsieh@mediatek.com> Message-ID: <1485238365.30572.5.camel@mtksdaap41> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Bibby: On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wrote: > Current Mediatek DRM driver does not support interlaced mode, and > will hang if such resolution is used: Filter those to prevent > kernel hangs, until the DRM driver is fixed properly. > > Signed-off-by: Bibby Hsieh Acked-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c > index 0e8c4d9..e33678d 100644 > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c > @@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn, > return MODE_BAD; > } > > + if (mode->flags & DRM_MODE_FLAG_INTERLACE) > + return MODE_NO_INTERLACE; > if (mode->clock < 27000) > return MODE_CLOCK_LOW; > if (mode->clock > 297000)