All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gregory Fong <Gregory.Fong@virgingalactic.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] pci: don't skip vendor ID 0
Date: Wed, 25 Jan 2017 05:25:27 +0000	[thread overview]
Message-ID: <1485321910-12648-1-git-send-email-gregory.fong@virgingalactic.com> (raw)

Unlike 0xffff, 0 is not an invalid vendor ID.

Signed-off-by: Gregory Fong <gregory.fong@virgingalactic.com>
---
Based on question initially asked here:
http://lists.denx.de/pipermail/u-boot/2016-December/276172.html

I've been looking through the book I have on PCI and through various online
resources, and haven't been able to find evidence that a vendor ID of 0 is
invalid, even if it's unusual.  There are still issues in how this will be
handled in e.g. drivers/pci/pci_common.c because pci_hose_find_devices() still
assumes that a vendor and device ID of 0 mean that the last pci_device_id is
reached, but this change at least allows the device's PCI BARs to get
programmed if the vendor ID is 0.

 drivers/pci/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 6b36c18..3ee7180 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -366,7 +366,7 @@ int pci_hose_scan_bus(struct pci_controller *hose, int bus)
 
 		pci_hose_read_config_word(hose, dev, PCI_VENDOR_ID, &vendor);
 
-		if (vendor == 0xffff || vendor == 0x0000)
+		if (vendor == 0xffff)
 			continue;
 
 		if (!PCI_FUNC(dev))
-- 
1.9.1

             reply	other threads:[~2017-01-25  5:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-25  5:25 Gregory Fong [this message]
2017-01-25 14:14 ` [U-Boot] [PATCH] pci: don't skip vendor ID 0 Bin Meng
2017-01-25 21:23   ` Gregory Fong
2017-01-26 10:08     ` Bin Meng
2017-01-26 12:26       ` Leon Woestenberg
2017-01-26 13:19         ` Gregory Fong
2017-01-26 13:57           ` Leon Woestenberg
2017-01-27  3:11             ` Gregory Fong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485321910-12648-1-git-send-email-gregory.fong@virgingalactic.com \
    --to=gregory.fong@virgingalactic.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.