All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kristian Amlie <kristian.amlie@mender.io>
To: Openembedded-core@lists.openembedded.org,
	Richard Purdie <richard.purdie@linuxfoundation.org>
Subject: Re: Overriding fixmepath
Date: Wed, 25 Jan 2017 14:53:16 +0100	[thread overview]
Message-ID: <1485352397-18383-1-git-send-email-kristian.amlie@mender.io> (raw)
In-Reply-To: <1485347971.30673.95.camel@linuxfoundation.org>


>> Take a look at the attached file, to me the inclusion of .a files in
>> the
>> fixmepath file seems wrong, so I can start with that, unless you have
>> better idea.
> 
> I think this is a very good lead. The code searches for replacements to
> make with: "grep -Irl" (see sstate.bbclass) and it looks like its
> matching these files and shouldn't. We may need to make sstate.bbclass
> look something like:
> 
> SSTATE_SCAN_CMD ?= 'find ${SSTATE_BUILDDIR} \( -name "${@"\" -o -name \"".join(d.getVar("SSTATE_SCAN_FILES").split())}" \) -type f'
> SSTATE_SCAN_CMD_NATIVE ?= 'grep -Irl -e ${RECIPE_SYSROOT} -e ${RECIPE_SYSROOT_NATIVE} ${SSTATE_BUILDDIR}'
> 
> and then:
>     if bb.data.inherits_class('native', d) or bb.data.inherits_class('cross', d) or bb.data.inherits_class('sdk', d) or bb.data.inherits_class('crosssdk', d):
>         d.setVar('SSTATE_SCAN_CMD', '${SSTATE_SCAN_CMD_NATIVE}')
> 
> which means you'd be able to override the command being used to exclude
> .a files?

Thanks, good suggestion!

In order to make this overridable from any recipe, may I propose the following
patch instead? It has the advantage of avoiding the Python logic altogether, and
using weak defaults so that it can be easily overridden. One thing to note is
that I couldn't find the "sdk" class that was referenced in the Python
code. Does it exist anymore?

The mentioned patch is what I used, and it worked for me when I also added:

  SSTATE_SCAN_CMD = "true"

to the Go recipe.

-- 
Kristian


  reply	other threads:[~2017-01-25 13:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-25 10:43 Overriding fixmepath Kristian Amlie
2017-01-25 11:24 ` Richard Purdie
2017-01-25 12:22   ` Kristian Amlie
2017-01-25 12:39     ` Richard Purdie
2017-01-25 13:53       ` Kristian Amlie [this message]
2017-01-25 13:53         ` [PATCH] Make SSTATE_SCAN_CMD vars configurable using weak defaults Kristian Amlie
2017-01-25 14:23       ` ✗ patchtest: failure for " Patchwork
2017-01-25 14:34         ` Kristian Amlie
2017-01-25 14:38           ` Richard Purdie
2017-01-25 14:46             ` [PATCH] sstate: " Kristian Amlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485352397-18383-1-git-send-email-kristian.amlie@mender.io \
    --to=kristian.amlie@mender.io \
    --cc=Openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.