From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751891AbdAYQlX (ORCPT ); Wed, 25 Jan 2017 11:41:23 -0500 Received: from mga01.intel.com ([192.55.52.88]:55865 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751813AbdAYQlV (ORCPT ); Wed, 25 Jan 2017 11:41:21 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,284,1477983600"; d="scan'208";a="1117721785" Message-ID: <1485362475.2133.329.camel@linux.intel.com> Subject: Re: [PATCH 0/2] dmaengine: Add DW AXI DMAC driver From: Andy Shevchenko To: Eugeniy Paltsev , dmaengine@vger.kernel.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-snps-arc@lists.infradead.org, Dan Williams , Vinod Koul , Mark Rutland , Rob Herring , Alexey Brodkin Date: Wed, 25 Jan 2017 18:41:15 +0200 In-Reply-To: <1485358457-22957-1-git-send-email-Eugeniy.Paltsev@synopsys.com> References: <1485358457-22957-1-git-send-email-Eugeniy.Paltsev@synopsys.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-01-25 at 18:34 +0300, Eugeniy Paltsev wrote: > This patch series add support for the DW AXI DMAC controller. > > DW AXI DMAC is a part of upcoming development board from Synopsys. > > In this driver implementation only DMA_MEMCPY and DMA_SG transfers > are supported. > > Changes for v0: >  * Switch to virt-dma API (according to previous RFC) >  * Small fixies according to previous RFC Yeah, seems you didn't address some of the comments and didn't comment why... >  * Add DT bindings > > Eugeniy Paltsev (2): >   dt-bindings: Document the Synopsys DW AXI DMA bindings >   dmaengine: Add DW AXI DMAC driver > >  .../devicetree/bindings/dma/snps,axi-dw-dmac.txt   |   33 + >  drivers/dma/Kconfig                                |    8 + >  drivers/dma/Makefile                               |    1 + >  drivers/dma/axi_dma_platform.c                     | 1060 > ++++++++++++++++++++ This surprises me. I would expect more then 100+ LOC reduction when switched to virt-dma API. Can you double check that you are using it effectively? >  drivers/dma/axi_dma_platform.h                     |  124 +++ >  drivers/dma/axi_dma_platform_reg.h                 |  189 ++++ >  6 files changed, 1415 insertions(+) >  create mode 100644 Documentation/devicetree/bindings/dma/snps,axi-dw- > dmac.txt >  create mode 100644 drivers/dma/axi_dma_platform.c >  create mode 100644 drivers/dma/axi_dma_platform.h >  create mode 100644 drivers/dma/axi_dma_platform_reg.h > -- Andy Shevchenko Intel Finland Oy From mboxrd@z Thu Jan 1 00:00:00 1970 From: andriy.shevchenko@linux.intel.com (Andy Shevchenko) Date: Wed, 25 Jan 2017 18:41:15 +0200 Subject: [PATCH 0/2] dmaengine: Add DW AXI DMAC driver In-Reply-To: <1485358457-22957-1-git-send-email-Eugeniy.Paltsev@synopsys.com> References: <1485358457-22957-1-git-send-email-Eugeniy.Paltsev@synopsys.com> List-ID: Message-ID: <1485362475.2133.329.camel@linux.intel.com> To: linux-snps-arc@lists.infradead.org On Wed, 2017-01-25@18:34 +0300, Eugeniy Paltsev wrote: > This patch series add support for the DW AXI DMAC controller. > > DW AXI DMAC is a part of upcoming development board from Synopsys. > > In this driver implementation only DMA_MEMCPY and DMA_SG transfers > are supported. > > Changes for v0: > ?* Switch to virt-dma API (according to previous RFC) > ?* Small fixies according to previous RFC Yeah, seems you didn't address some of the comments and didn't comment why... > ?* Add DT bindings > > Eugeniy Paltsev (2): > ? dt-bindings: Document the Synopsys DW AXI DMA bindings > ? dmaengine: Add DW AXI DMAC driver > > ?.../devicetree/bindings/dma/snps,axi-dw-dmac.txt???|???33 + > ?drivers/dma/Kconfig????????????????????????????????|????8 + > ?drivers/dma/Makefile???????????????????????????????|????1 + > ?drivers/dma/axi_dma_platform.c?????????????????????| 1060 > ++++++++++++++++++++ This surprises me. I would expect more then 100+ LOC reduction when switched to virt-dma API. Can you double check that you are using it effectively? > ?drivers/dma/axi_dma_platform.h?????????????????????|??124 +++ > ?drivers/dma/axi_dma_platform_reg.h?????????????????|??189 ++++ > ?6 files changed, 1415 insertions(+) > ?create mode 100644 Documentation/devicetree/bindings/dma/snps,axi-dw- > dmac.txt > ?create mode 100644 drivers/dma/axi_dma_platform.c > ?create mode 100644 drivers/dma/axi_dma_platform.h > ?create mode 100644 drivers/dma/axi_dma_platform_reg.h > -- Andy Shevchenko Intel Finland Oy