Re: [PATCH v15] This is the ABI for the two halves of a para-virtualized sound driver to communicate with each to other.

From: Dario Faggioli <dario.faggioli@citrix.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: lars.kurth@citrix.com, iurii.konovalenko@globallogic.com,
	vlad.babchuk@gmail.com, ian.jackson@eu.citrix.com,
	oleksandr.dmytryshyn@globallogic.com, tim@xen.org,
	julien.grall@arm.com, andrii.anisov@gmail.com,
	olekstysh@gmail.com, embedded-pv-devel@lists.xenproject.org,
	al1img@gmail.com, david.vrabel@citrix.com, JBeulich@suse.com,
	xen-devel@lists.xenproject.org, joculator@gmail.com
Subject: Re: [PATCH v15] This is the ABI for the two halves of a para-virtualized sound driver to communicate with each to other.
Date: Thu, 26 Jan 2017 12:09:30 +0100	[thread overview]
Message-ID: <1485428970.32103.143.camel@citrix.com> (raw)
In-Reply-To: <e5d1736a-baf1-269d-1fbf-a2b40052783b@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 2101 bytes --]

On Thu, 2017-01-26 at 12:02 +0200, Oleksandr Andrushchenko wrote:
> Hi, Konrad!
> 
> First of all thank you very much for the valuable comments
> 
> and your time!
> 
> The number of changes (mostly in description) is going to
> 
> be huge, so do you think I can publish something like
> 
> "RFC v16" so we can discuss the updated patch?
> 
Konrad's call, but why you want to introduce the 'RFC' tag now? I'd
just go with v16...

> On 01/24/2017 09:13 PM, Konrad Rzeszutek Wilk wrote:
> > On Mon, Dec 05, 2016 at 03:05:29PM +0200, Oleksandr Andrushchenko
> > wrote:
> > > 
> > > + * Example for the frontend running in domain 5, instance of the
> > > driver
> > > + * in the front is 0 (single or first PV driver), device id 2,
> > > + * first stream (0):
> > > + * /local/domain/<frontend_id>/device/vsnd/<drv_idx>/
> > > + *         device/<dev_id>/stream/<stream_idx>/type = "p"
> > > + * /local/domain/5/device/vsnd/0/device/2/stream/0/type = "p"
> > Why do you need 'device' ?
> just for clarity: the hierarchy of the sound driver would
> be that a device may have multiple different streams.
> So, from readability POV I would still have "device" in place
>  From xenstore documentation: "Data should generally be
> human-readable for ease of management and debugging "
> I assume this also applies to the structure as well
>
Perhaps:

 /local/domain/<frontend_id>/device/vsnd/<drv_idx>/dev-<dev_id>/stream-<stream_idx>/...

> > Could not this be:
> > 
> > /local/domain/5/device/vsnd/0/2/stream/0/type = "p" ?
> then one has to know that "2" stands for device.
> see above, I would keep "device" here
> > > 

 /local/domain/5/device/vsnd/0/dev-2/stream-0/type = "p"

Or, with no '-':

 /local/domain/5/device/vsnd/0/dev2/stream0/type = "p"

Just my 2 cents...

Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel