From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752811AbdAZLu4 (ORCPT ); Thu, 26 Jan 2017 06:50:56 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35947 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751332AbdAZLuy (ORCPT ); Thu, 26 Jan 2017 06:50:54 -0500 From: Bilal Amarni To: arnd@arndb.de Cc: bilal.amarni@gmail.com, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] security/keys: add CONFIG_KEYS_COMPAT to Kconfig Date: Thu, 26 Jan 2017 12:49:28 +0100 Message-Id: <1485431368-8662-1-git-send-email-bilal.amarni@gmail.com> X-Mailer: git-send-email 2.7.2 In-Reply-To: <6063453.l76hsdyeRH@wuerfel> References: <6063453.l76hsdyeRH@wuerfel> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org CONFIG_KEYS_COMPAT is defined in arch-specific Kconfigs and is missing for several 64-bit architectures : arm64, mips, parisc, tile. At the moment and for those architectures, calling in 32-bit userspace the keyctl syscall would return an ENOSYS error. This patch moves the CONFIG_KEYS_COMPAT option to security/keys/Kconfig, to make sure the compatibility wrapper is registered by default for any 64-bit architecture as long as it is configured with CONFIG_COMPAT. Signed-off-by: Bilal Amarni --- arch/powerpc/Kconfig | 5 ----- arch/s390/Kconfig | 3 --- arch/sparc/Kconfig | 3 --- arch/x86/Kconfig | 5 ----- security/keys/Kconfig | 4 ++++ 5 files changed, 4 insertions(+), 16 deletions(-) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index a8ee573..5947ea2 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -1128,11 +1128,6 @@ source "arch/powerpc/Kconfig.debug" source "security/Kconfig" -config KEYS_COMPAT - bool - depends on COMPAT && KEYS - default y - source "crypto/Kconfig" config PPC_LIB_RHEAP diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig index c6722112..633f553 100644 --- a/arch/s390/Kconfig +++ b/arch/s390/Kconfig @@ -362,9 +362,6 @@ config COMPAT config SYSVIPC_COMPAT def_bool y if COMPAT && SYSVIPC -config KEYS_COMPAT - def_bool y if COMPAT && KEYS - config SMP def_bool y prompt "Symmetric multi-processing support" diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig index cf4034c..2b07f0a 100644 --- a/arch/sparc/Kconfig +++ b/arch/sparc/Kconfig @@ -571,9 +571,6 @@ config SYSVIPC_COMPAT depends on COMPAT && SYSVIPC default y -config KEYS_COMPAT - def_bool y if COMPAT && KEYS - endmenu source "net/Kconfig" diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index e487493..e92b62b 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -2769,11 +2769,6 @@ config SYSVIPC_COMPAT def_bool y depends on SYSVIPC -config KEYS_COMPAT - def_bool y - depends on KEYS -endif - endmenu diff --git a/security/keys/Kconfig b/security/keys/Kconfig index d942c7c..f44d8be 100644 --- a/security/keys/Kconfig +++ b/security/keys/Kconfig @@ -20,6 +20,10 @@ config KEYS If you are unsure as to whether this is required, answer N. +config KEYS_COMPAT + def_bool y + depends on COMPAT && KEYS + config PERSISTENT_KEYRINGS bool "Enable register of persistent per-UID keyrings" depends on KEYS -- 2.7.2 From mboxrd@z Thu Jan 1 00:00:00 1970 From: bilal.amarni@gmail.com (Bilal Amarni) Date: Thu, 26 Jan 2017 12:49:28 +0100 Subject: [PATCH] security/keys: add CONFIG_KEYS_COMPAT to Kconfig In-Reply-To: <6063453.l76hsdyeRH@wuerfel> References: <6063453.l76hsdyeRH@wuerfel> Message-ID: <1485431368-8662-1-git-send-email-bilal.amarni@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org CONFIG_KEYS_COMPAT is defined in arch-specific Kconfigs and is missing for several 64-bit architectures : arm64, mips, parisc, tile. At the moment and for those architectures, calling in 32-bit userspace the keyctl syscall would return an ENOSYS error. This patch moves the CONFIG_KEYS_COMPAT option to security/keys/Kconfig, to make sure the compatibility wrapper is registered by default for any 64-bit architecture as long as it is configured with CONFIG_COMPAT. Signed-off-by: Bilal Amarni --- arch/powerpc/Kconfig | 5 ----- arch/s390/Kconfig | 3 --- arch/sparc/Kconfig | 3 --- arch/x86/Kconfig | 5 ----- security/keys/Kconfig | 4 ++++ 5 files changed, 4 insertions(+), 16 deletions(-) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index a8ee573..5947ea2 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -1128,11 +1128,6 @@ source "arch/powerpc/Kconfig.debug" source "security/Kconfig" -config KEYS_COMPAT - bool - depends on COMPAT && KEYS - default y - source "crypto/Kconfig" config PPC_LIB_RHEAP diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig index c6722112..633f553 100644 --- a/arch/s390/Kconfig +++ b/arch/s390/Kconfig @@ -362,9 +362,6 @@ config COMPAT config SYSVIPC_COMPAT def_bool y if COMPAT && SYSVIPC -config KEYS_COMPAT - def_bool y if COMPAT && KEYS - config SMP def_bool y prompt "Symmetric multi-processing support" diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig index cf4034c..2b07f0a 100644 --- a/arch/sparc/Kconfig +++ b/arch/sparc/Kconfig @@ -571,9 +571,6 @@ config SYSVIPC_COMPAT depends on COMPAT && SYSVIPC default y -config KEYS_COMPAT - def_bool y if COMPAT && KEYS - endmenu source "net/Kconfig" diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index e487493..e92b62b 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -2769,11 +2769,6 @@ config SYSVIPC_COMPAT def_bool y depends on SYSVIPC -config KEYS_COMPAT - def_bool y - depends on KEYS -endif - endmenu diff --git a/security/keys/Kconfig b/security/keys/Kconfig index d942c7c..f44d8be 100644 --- a/security/keys/Kconfig +++ b/security/keys/Kconfig @@ -20,6 +20,10 @@ config KEYS If you are unsure as to whether this is required, answer N. +config KEYS_COMPAT + def_bool y + depends on COMPAT && KEYS + config PERSISTENT_KEYRINGS bool "Enable register of persistent per-UID keyrings" depends on KEYS -- 2.7.2