From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752432AbdAZMOn (ORCPT ); Thu, 26 Jan 2017 07:14:43 -0500 Received: from smtprelay0005.hostedemail.com ([216.40.44.5]:52862 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751638AbdAZMOl (ORCPT ); Thu, 26 Jan 2017 07:14:41 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:2897:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:4321:5007:8603:10004:10400:10450:10455:10848:11026:11232:11473:11658:11914:12043:12296:12438:12740:12760:12895:13069:13311:13357:13439:14659:14721:19904:19999:21080:30012:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: ship30_7fcd719458b10 X-Filterd-Recvd-Size: 1986 Message-ID: <1485432877.12563.100.camel@perches.com> Subject: Re: [PATCH 0/6 v3] kvmalloc From: Joe Perches To: Michal Hocko , Daniel Borkmann Cc: Alexei Starovoitov , Andrew Morton , Vlastimil Babka , Mel Gorman , Johannes Weiner , linux-mm , LKML , "netdev@vger.kernel.org" , marcelo.leitner@gmail.com Date: Thu, 26 Jan 2017 04:14:37 -0800 In-Reply-To: <20170126103216.GG6590@dhcp22.suse.cz> References: <588907AA.1020704@iogearbox.net> <20170126074354.GB8456@dhcp22.suse.cz> <5889C331.7020101@iogearbox.net> <20170126100802.GF6590@dhcp22.suse.cz> <20170126103216.GG6590@dhcp22.suse.cz> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-01-26 at 11:32 +0100, Michal Hocko wrote: > So I have folded the following to the patch 1. It is in line with > kvmalloc and hopefully at least tell more than the current code. [] > diff --git a/mm/vmalloc.c b/mm/vmalloc.c [] > @@ -1741,6 +1741,13 @@ void *__vmalloc_node_range(unsigned long size, unsigned long align, > * Allocate enough pages to cover @size from the page level > * allocator with @gfp_mask flags. Map them into contiguous > * kernel virtual space, using a pagetable protection of @prot. > + * > + * Reclaim modifiers in @gfp_mask - __GFP_NORETRY, __GFP_REPEAT > + * and __GFP_NOFAIL are not supported Maybe add a BUILD_BUG or a WARN_ON_ONCE to catch new occurrences? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot0-f199.google.com (mail-ot0-f199.google.com [74.125.82.199]) by kanga.kvack.org (Postfix) with ESMTP id 48DCD6B0268 for ; Thu, 26 Jan 2017 07:14:41 -0500 (EST) Received: by mail-ot0-f199.google.com with SMTP id f9so180227267otd.4 for ; Thu, 26 Jan 2017 04:14:41 -0800 (PST) Received: from smtprelay.hostedemail.com (smtprelay0133.hostedemail.com. [216.40.44.133]) by mx.google.com with ESMTPS id j127si1687801itj.118.2017.01.26.04.14.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Jan 2017 04:14:40 -0800 (PST) Message-ID: <1485432877.12563.100.camel@perches.com> Subject: Re: [PATCH 0/6 v3] kvmalloc From: Joe Perches Date: Thu, 26 Jan 2017 04:14:37 -0800 In-Reply-To: <20170126103216.GG6590@dhcp22.suse.cz> References: <588907AA.1020704@iogearbox.net> <20170126074354.GB8456@dhcp22.suse.cz> <5889C331.7020101@iogearbox.net> <20170126100802.GF6590@dhcp22.suse.cz> <20170126103216.GG6590@dhcp22.suse.cz> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko , Daniel Borkmann Cc: Alexei Starovoitov , Andrew Morton , Vlastimil Babka , Mel Gorman , Johannes Weiner , linux-mm , LKML , "netdev@vger.kernel.org" , marcelo.leitner@gmail.com On Thu, 2017-01-26 at 11:32 +0100, Michal Hocko wrote: > So I have folded the following to the patch 1. It is in line with > kvmalloc and hopefully at least tell more than the current code. [] > diff --git a/mm/vmalloc.c b/mm/vmalloc.c [] > @@ -1741,6 +1741,13 @@ void *__vmalloc_node_range(unsigned long size, unsigned long align, > * Allocate enough pages to cover @size from the page level > * allocator with @gfp_mask flags. Map them into contiguous > * kernel virtual space, using a pagetable protection of @prot. > + * > + * Reclaim modifiers in @gfp_mask - __GFP_NORETRY, __GFP_REPEAT > + * and __GFP_NOFAIL are not supported Maybe add a BUILD_BUG or a WARN_ON_ONCE to catch new occurrences? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org